[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190

Neal Gompa  changed:

   What|Removed |Added

 Blocks||1512217
   ||(PantheonDesktopPackageRevi
   ||ews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1512217
[Bug 1512217] Tracking: Pantheon Desktop related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-03-01 20:20:54



--- Comment #9 from Fedora Update System  ---
switchboard-plug-bluetooth-0.1-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
switchboard-plug-bluetooth-0.1-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ccab2c0578

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190



--- Comment #7 from Fedora Update System  ---
switchboard-plug-bluetooth-0.1-1.fc25 has been submitted as an update to Fedora
25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-ccab2c0578

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/switchboard-plug-bluetooth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190



--- Comment #4 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

C/C++:
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "GPL (v3 or later)", "Unknown or generated".
 94 files have unknown license. Detailed output of licensecheck in
 /home/makerpm/1425190-switchboard-plug-bluetooth/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/locale/rue, /usr/share/locale/ckb,
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/locale/ckb,
 /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/rue,
 /usr/share/locale/ckb/LC_MESSAGES
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 switchboard-plug-bluetooth-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if 

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Neal Gompa  ---
Ignoring the timeout error, since I know the LP link is valid (tested it
myself).

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190



--- Comment #3 from Fabio Valentini  ---
Fixed, same links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190



--- Comment #2 from Neal Gompa  ---
A quick poke into the package sources indicates that it has a runtime
requirement on bluez.

I'd suggest adding "Requires: bluez" and adjusting the Supplements so that it
is installed when switchboard and bluez are installed, similar to what was done
for some of the other plugs using boolean dependencies.

Also, make sure that your Supplements are archful, since this is a library that
links into switchboard.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1425190] Review Request: switchboard-plug-bluetooth - Switchboard Bluetooth plug

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1425190

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Neal Gompa  ---
Taking this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org