[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637

Dominik 'Rathann' Mierzejewski  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-12-18 13:45:55



--- Comment #10 from Dominik 'Rathann' Mierzejewski  ---
Sorry for the delay. Thanks for the review. Package imported and build for
rawhide with rpmlint errors fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-fypp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Björn "besser82" Esser  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (2 clause)", "Unknown or generated", "*No copyright* BSD
 (unspecified)". 15 files have unknown license. Detailed output of
 licensecheck in /home/besser82/fedora/review/1431637-python-
 fypp/licensecheck.txt

 ---> License is fine.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep


= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all 

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637



--- Comment #7 from Dominik 'Rathann' Mierzejewski  ---
Ping?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637



--- Comment #6 from Dominik 'Rathann' Mierzejewski  ---
Spec URL: https://rathann.fedorapeople.org/review/python-fypp/python-fypp.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-fypp/python-fypp-2.1.1-1.fc26.src.rpm

* Fri Oct 06 2017 Dominik Mierzejewski  2.1.1-1
- update to 2.1.1

Tests pass both in mock locally and in koji (scratch build):
https://koji.fedoraproject.org/koji/taskinfo?taskID=22295844

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637

Elliott Sales de Andrade  changed:

   What|Removed |Added

 CC||quantum.anal...@gmail.com



--- Comment #5 from Elliott Sales de Andrade  ---
I can reproduce the failures in mock and out, but your latest srpm link is
broken.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637



--- Comment #4 from Dominik 'Rathann' Mierzejewski  ---
Hm, I cannot reproduce your test failures either locally or in koji:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20266422
[...]
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.AW67YH
+ umask 022
+ cd /builddir/build/BUILD
+ cd fypp-2.0.1
+ test/runtests.sh /usr/bin/python3
Testing with interpreter '/usr/bin/python3'
.
--
Ran 377 tests in 0.281s
OK
All test runs finished successfully
+ exit 0
[...]

Anyway, small update:
Spec URL: https://rathann.fedorapeople.org/review/python-fypp/python-fypp.spec
SRPM URL:
https://rathann.fedorapeople.org/review/python-fypp/python-fypp-2.0-2.fc25.src.rpm

* Fri Jun 30 2017 Dominik Mierzejewski  2.0.1-2
- update upstream URL (bitbucket URL redirects to github)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637



--- Comment #3 from Dominik 'Rathann' Mierzejewski  ---
Thanks for the review and sorry for delayed response. I'll take a look at the
failures and talk to upstream if I can't fix them myself.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637



--- Comment #2 from Björn "besser82" Esser  ---
Tests are failing, but this gets silently ignored.  :/

+ test/runtests.sh /usr/bin/python3
Testing with interpreter '/usr/bin/python3'
Python detected LC_CTYPE=C: LC_CTYPE & LANG coerced to C.UTF-8 (set another
locale or PYTHONCOERCECLOCALE=0 to disable this locale coercion behavior).
E....
==
ERROR: test_import_module_current_dir (__main__.ImportTest)
Tests whether Fypp result matches expected output.
--
Traceback (most recent call last):
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 1952, in
import_module
imported = __import__(module, self._scope)
ModuleNotFoundError: No module named 'inimod'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "test_fypp.py", line 2662, in test_output
tool = fypp.Fypp(options)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2422, in __init__
options.moduledirs)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2514, in
_import_modules
evaluator.import_module(module)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 1956, in
import_module
raise FyppFatalError(msg, cause=exc)
fypp.FyppFatalError: FyppFatalError: failed to import module 'inimod'
No module named 'inimod'
==
ERROR: test_nested_include_in_folder_of_incfile (__main__.IncludeTest)
Tests whether Fypp result matches expected output.
--
Traceback (most recent call last):
  File "test_fypp.py", line 2663, in test_output
result = tool.process_text(inp)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2487, in process_text
return self._preprocessor.process_text(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2356, in process_text
self._parser.parse(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 280, in parse
self._parse(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 604, in _parse
self._process_control_dir(content, span)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 667, in
_process_control_dir
self._process_include(param, span)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 815, in
_process_include
raise FyppFatalError(msg, self._curfile, span)
fypp.FyppFatalError: FyppFatalError: file '', line 1
include file 'subfolder/include_fypp2.inc' not found
==
ERROR: test_nested_include_in_folder_of_incfile2 (__main__.IncludeTest)
Tests whether Fypp result matches expected output.
--
Traceback (most recent call last):
  File "test_fypp.py", line 2663, in test_output
result = tool.process_text(inp)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2487, in process_text
return self._preprocessor.process_text(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2356, in process_text
self._parser.parse(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 280, in parse
self._parse(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 604, in _parse
self._process_control_dir(content, span)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 667, in
_process_control_dir
self._process_include(param, span)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 815, in
_process_include
raise FyppFatalError(msg, self._curfile, span)
fypp.FyppFatalError: FyppFatalError: file '', line 1
include file 'subfolder/include_fypp2.inc' not found
==
ERROR: test_nested_include_in_incpath (__main__.IncludeTest)
Tests whether Fypp result matches expected output.
--
Traceback (most recent call last):
  File "test_fypp.py", line 2663, in test_output
result = tool.process_text(inp)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2487, in process_text
return self._preprocessor.process_text(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 2356, in process_text
self._parser.parse(txt)
  File "/builddir/build/BUILD/fypp-2.0/src/fypp.py", line 280, in parse
self._parse(txt)
  File 

[Bug 1431637] Review Request: python-fypp - Fortran preprocessor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431637

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||besse...@fedoraproject.org
   Assignee|nob...@fedoraproject.org|besse...@fedoraproject.org
  Flags||fedora-review?



--- Comment #1 from Björn "besser82" Esser  ---
Taken

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org