[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855

Mattia Verga  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |ERRATA
Last Closed||2021-06-04 08:14:30



--- Comment #8 from Mattia Verga  ---
Closing, since the package was imported and it's in Fedora repos.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-debrepo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855



--- Comment #6 from Ken Dreyer  ---
Awesome, thanks Julien!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855

Julien Enselme  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Julien Enselme  ---
You could rename python-setuptools to python2-setuptools but that's a detail.
Package looks good. Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855



--- Comment #4 from Ken Dreyer  ---
Thank you Julien, good catches. Here's the latest version.

* Thu Jul 06 2017 Ken Dreyer  - 0.0.3-2
- Drop duplicate BuildRequires: python2-devel
- Use %%global macro instead of %%define

Exact changes in Git:
https://github.com/ktdreyer/python-debrepo/commit/fbb7d4b9076790a369fba937c0e6a6243133fa0f

Spec:
https://raw.githubusercontent.com/ktdreyer/python-debrepo/master/python-debrepo.spec
SRPM:
https://ktdreyer.fedorapeople.org/reviews/python-debrepo-0.0.3-2.fc27.src.rpm

F27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20368654

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855



--- Comment #3 from Julien Enselme  ---
- BuildRequires:  python2-devel is present twice.
- I didn't catch it during initial review: Spec use %global instead of %define
unless justified. Note: %define requiring justification: %define srcname
debrepo Can you use %global or justify the %define?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855



--- Comment #2 from Ken Dreyer  ---
Julien, thank you very much for the review! I've addressed your comments and
updated to the latest upstream release.

* Mon Jul 03 2017 Ken Dreyer  - 0.0.3-1
- Update to latest upstream release
- Drop Requires: python3
- Require chardet
- Include LICENSE.rst
- More precise sitelib contents

Exact changes in Git:
https://github.com/ktdreyer/python-debrepo/commit/f9406e6525e5c3d79d8ff3fac97cf7178bcfcabb

F27 scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20348917

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1431855] Review Request: python-debrepo - Inspect and compare Debian repositories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1431855

Julien Enselme  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||juj...@jujens.eu
   Assignee|nob...@fedoraproject.org|juj...@jujens.eu
  Flags||fedora-review?



--- Comment #1 from Julien Enselme  ---
- I would rename python-devel into python2-devel
- `Requires:   python3` is not needed
- From the setup.py, you need to require python2-chardet and python3-chardet
- You must include the license file now
- I reocommand that you to be more precise in your %files section:
`%{python3_sitelib}/*` -> `%{python3_sitelib}/debrepo/` and
`%{python3_sitelib}/debrepo-%{version}-py%{python3_verison}.egg-info/`
- I believe RPM lints errors are false positive due to this change:
https://fedoraproject.org/wiki/Changes/python3_c.utf-8_locale

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[X]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3 or later)", "Unknown or generated". 9 files have
 unknown license. Detailed output of licensecheck in /tmp/1431855
 -python-debrepo/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
 process.
[X]: A package which is used by another package via an egg interface should
 provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[X]: If the source package does not include license