[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Peter Lemenkov  changed:

   What|Removed |Added

 Blocks|1436417 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436417
[Bug 1436417] Enable ac3 with liba52 in alsa-plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Blocks||1436417




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1436417
[Bug 1436417] Enable ac3 with liba52 in alsa-plugins
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2017-03-24 10:31:24



--- Comment #16 from Nicolas Chauvet (kwizart)  ---
a52dec package imported for el6 and later
description improved for AC3/AC-3
Thx for the review and package admin request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #15 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/a52dec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #14 from Yaakov Selkowitz  ---
(In reply to Peter Robinson from comment #13)
> (In reply to Wim Taymans from comment #10)
> > This is the GStreamer plugin for review:
> > 
> > SPEC:
> > https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-a52dec.spec
> > SRPM:
> > https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-a52dec-1.10.4-1.
> > fc25.src.rpm
> > 
> > Still using the old name though.
> 
> This needs to be done in a different review

Nack.  We need to move forward on -ugly-free in bug 1397261.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #13 from Peter Robinson  ---
(In reply to Wim Taymans from comment #10)
> This is the GStreamer plugin for review:
> 
> SPEC:
> https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-a52dec.spec
> SRPM:
> https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-a52dec-1.10.4-1.
> fc25.src.rpm
> 
> Still using the old name though.

This needs to be done in a different review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #12 from Peter Robinson  ---

> We already have -mpg123 from -ugly packaged. Maybe it's time to import the
> entire -ugly (w/o few remaining plugins we still cannot ship)?

Or have upstream move them to good/bad as appropriate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #11 from Peter Lemenkov  ---
(In reply to Wim Taymans from comment #10)
> This is the GStreamer plugin for review:
> 
> SPEC:
> https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-a52dec.spec
> SRPM:
> https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-a52dec-1.10.4-1.
> fc25.src.rpm
> 
> Still using the old name though.

We already have -mpg123 from -ugly packaged. Maybe it's time to import the
entire -ugly (w/o few remaining plugins we still cannot ship)?

See bug 1397261.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Wim Taymans  changed:

   What|Removed |Added

 CC||wtaym...@redhat.com



--- Comment #10 from Wim Taymans  ---
This is the GStreamer plugin for review:

SPEC: https://people.freedesktop.org/~wtay/SPECS/gstreamer1-plugin-a52dec.spec
SRPM:
https://people.freedesktop.org/~wtay/SRPMS/gstreamer1-plugin-a52dec-1.10.4-1.fc25.src.rpm

Still using the old name though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Matthew Miller  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Matthew Miller  ---
Looks good to me. Tested; plays sample files.


Non-blocking note: It would be useful for the summary and description to
describe this as "AC-3" (and possibly also AC3, to aid in searching.) (The
trademark for this is listed as "DEAD".)


Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[X]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[X]: License field in the package spec file matches the actual license.
[X]: License file installed when any subpackage combination is installed.
[X]: Package does not own files or directories owned by other packages.
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[X]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
 names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[X]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Useful -debuginfo package or justification otherwise.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[X]: Package complies to the Packaging Guidelines
[X]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[X]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[X]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in liba52 ,
 liba52-devel , a52dec-debuginfo
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
[X]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for supported 

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Matthew Miller  changed:

   What|Removed |Added

 CC||mat...@redhat.com
   Assignee|nob...@fedoraproject.org|mat...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #8 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/a52dec.spec
SRPM URL: http://dl.kwizart.net/review/a52dec-0.7.4-25.fc24.src.rpm
Description: Small test program for liba52

Changelog:
- Fixup Obsoletes/Provides for the devel
- Use sed instead of perl to avoid a build dependency

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #7 from Yaakov Selkowitz  ---
(In reply to Nicolas Chauvet (kwizart) from comment #6)
> Changelog:
> - Add obsoletes/provides for a52dec-devel

Not quite:

-Provides:   %{name} = %{version}-%{release}
-Obsoletes:  %{name} < 0.7.4-23
+Provides:   %{name}-devel = %{version}-%{release}
+Obsoletes:  %{name}-devel < 0.7.4-23

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #6 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/a52dec.spec
SRPM URL: http://dl.kwizart.net/review/a52dec-0.7.4-24.fc24.src.rpm
Description: Small test program for liba52

Changelog:
- Add obsoletes/provides for a52dec-devel

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758



--- Comment #5 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/a52dec.spec
SRPM URL: http://dl.kwizart.net/review/a52dec-0.7.4-23.fc24.src.rpm
Description: Small test program for liba52

(typo on SRPM URL address).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1433758] Review Request: a52dec - Small test program for liba52

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1433758

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

Summary|Review Request: a52dec - A  |Review Request: a52dec -
   |free ATSC A/52 stream   |Small test program for
   |decoder |liba52



--- Comment #4 from Nicolas Chauvet (kwizart)  ---
Spec URL: http://dl.kwizart.net/review/a52dec.spec
SRPM URL: http://dl.kwizart.net/review/a52dec-0.7.4-24.fc24.src.rpm
Description: Small test program for liba52

Changelog:
- Multilibs support - rhbz#1433758
- Simplify description
- Convert AUTHORS to UTF-8
- Drop Groups

rpmlint issue is about wrong fsf address are not expected to be patched:
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org