[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-09 23:58:52



--- Comment #7 from Fedora Update System  ---
pidgin-save-conv-order-1.0-2.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
pidgin-save-conv-order-1.0-2.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a9e21336ae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852



--- Comment #5 from Fedora Update System  ---
pidgin-save-conv-order-1.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a9e21336ae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/pidgin-save-conv-order

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Eduardo Mayorga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Eduardo Mayorga  ---
It looks fine.
PACKAGE APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852



--- Comment #2 from Daniel Vrátil  ---
Hi Eduardo, thanks for taking the review.

Spec URL: https://dvratil.fedorapeople.org/spec/pidgin-save-conv-order.spec
SRPM URL:
https://dvratil.fedorapeople.org/spec/pidgin-save-conv-order-1.0-2.fc25.src.rpm

* Fri Apr 07 2017 Daniel Vrátil  - 1.0-2
- use find_lang
- fix mixed tabs and spaces
- fix license
- add localized summary and description

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Eduardo Mayorga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||e...@mayorgalinux.com
   Assignee|nob...@fedoraproject.org|e...@mayorgalinux.com
  Flags||fedora-review?



--- Comment #1 from Eduardo Mayorga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- Locales are not being handled properly. Usage of %find_lang in packages
containing locales is a MUST.
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- License field in the spec file does not match the actual license. It's
actually GPLv2+.
- Summary(de): and
  %description -l de
  could be used to provide translations for non-English languages. The same for
fr and sr.
- rpmlint output is not clean.
  W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1)


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "CC0 GPL (v2 or
 later)", "Unknown or generated". 38 files have unknown license.
 Detailed output of licensecheck in /home/mayorga/reviews/1436852
 -pidgin-save-conv-order/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec 

[Bug 1436852] Review Request: pidgin-save-conv-order - Save and restore conversation order in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1436852

Daniel Vrátil  changed:

   What|Removed |Added

  Alias||pidgin-save-conv-order



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org