[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #14 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #13 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-10-06 15:58:01



--- Comment #12 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #11 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4bca68eb53

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #10 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-562d12d827

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f33a0f3f75

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #7 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc27 has been submitted as an update to
Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4bca68eb53

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #8 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc26 has been submitted as an update to
Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-f33a0f3f75

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #6 from Fedora Update System  ---
cppcodec-0-0.20171002.git.65e512d.fc25 has been submitted as an update to
Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-562d12d827

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/cppcodec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #4 from Jan Černý  ---
I'm sorry I have forgotten to set it. Thank you for reminder.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Jan Černý  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+
   |needinfo?(jce...@redhat.com |
   |)   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||needinfo?(jce...@redhat.com
   ||)



--- Comment #3 from Igor Gnatenko  ---
Mind setting fedora-review+ since there are no issues? I need this package ASAP
in order to process with bug blocked by this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Jaroslav Škarvada  changed:

   What|Removed |Added

 CC||jskar...@redhat.com



--- Comment #2 from Jaroslav Škarvada  ---
(In reply to Jan Černý from comment #1)
> Issues
> --
> Debuginfo is missing without a justification. Explanation should be provided.

The resulting RPM contains only header files, no binaries, so no debuginfo is
created and it's OK.

There are tools in the tool directory (e.g. base64dec) which are built, but
aren't installed. This is probably not a blocker - there are more sophisticated
replacement tools in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775



--- Comment #1 from Jan Černý  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: make gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 3 files have
 unknown license. Detailed output of licensecheck in
 /home/jcerny/1438775-cppcodec/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, 

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Jan Černý  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Jan Černý  changed:

   What|Removed |Added

 CC||jce...@redhat.com
   Assignee|nob...@fedoraproject.org|jce...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1438775] Review Request: cppcodec - Header-only C++11 library to encode/decode base64/base64url/ base32/base32hex/hex

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1438775

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks||1435221




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1435221
[Bug 1435221] nitrokey-app-1.0-beta.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org