[Bug 1439894] Review Request: python-ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894

Petr Oros  changed:

   What|Removed |Added

  Flags|needinfo?(po...@redhat.com) |



--- Comment #6 from Petr Oros  ---
Hi,
Latest version: https://github.com/orosp/ddiskit/archive/3.4.tar.gz

Fixed Issues:
- move scripts from %{python_sitelib} to /usr/share/ddiskit
- create man page - binary should have man page
- mark ddiskit.bash as config with %config(noreplace)
- if you have new directories in %files section, you need to define it before
  using with %dir - f.e. %dir %{datadir}/%{srcname}
- where you are using "ddiskit" in spec, you can use %{srcname} - it is more
  general solution
- empty files 'default' and 'rh-release' in 'profiles' directory - delete them
  or add into them some comments like "This file is for..."
- no need for %{srcname} global macro - you should use %{name} macro

dependency on kernel-devel - is it necessary? > YES

Many thanks,
-Petr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439894] Review Request: python-ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894

Stanislav Kozina  changed:

   What|Removed |Added

 CC||po...@redhat.com
  Flags|needinfo?(skoz...@redhat.co |needinfo?(po...@redhat.com)
   |m)  |



--- Comment #5 from Stanislav Kozina  ---
Petr?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439894] Review Request: python-ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894

Zdenek Dohnal  changed:

   What|Removed |Added

 CC||skoz...@redhat.com
  Flags||needinfo?(skoz...@redhat.co
   ||m)



--- Comment #4 from Zdenek Dohnal  ---
Hi,

sorry for delay, there is my review - there is some issues, but most "MUST" are
ok. So it will need some more work.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===
- move scripts from %{python_sitelib} to /usr/share/ddiskit
- create man page - binary should have man page
- mark ddiskit.bash as config with %config(noreplace)
- if you have new directories in %files section, you need to define it before
  using with %dir - f.e. %dir %{datadir}/%{srcname}
- where you are using "ddiskit" in spec, you can use %{srcname} - it is more
  general solution
- dependency on kernel-devel - is it necessary?
- empty files 'default' and 'rh-release' in 'profiles' directory - delete them
  or add into them some comments like "This file is for..."
- no need for %{srcname} global macro - you should use %{name} macro

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v3)", "Unknown or generated". 11 files have unknown
 license. Detailed output of licensecheck in
 /home/zdohnal/repo_upstream/ddiskit/review-ddiskit/licensecheck.txt
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/ddiskit/templates,
 /usr/share/ddiskit, /usr/share/ddiskit/profiles

- if you have new directories in %files section, you need to define it before
  using with %dir - f.e. %dir %{datadir}/%{srcname}

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/ddiskit/profiles,
 /usr/share/ddiskit/templates, /usr/share/ddiskit

- same as previous

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Each %files section contains %defattr if rpm < 4.4
 Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).

- you can use %{name} macro in spec

[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.

- dependency on kernel-devel?

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines

- it doesn't comply in issues mentioned before

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: 

[Bug 1439894] Review Request: python-ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894



--- Comment #3 from Zdenek Dohnal  ---
Output of rpmlint for built rpm:

$ rpmlint -iv python-ddiskit-3.1-1.fc25.noarch.rpm 
python-ddiskit.noarch: I: checking
python-ddiskit.noarch: E: devel-dependency kernel-devel
Your package has a dependency on a devel package but it's not a devel package
itself.

python-ddiskit.noarch: W: unexpanded-macro Summary(C) %{sum}
This package contains a file whose path contains something that looks like an
unexpanded macro; this is often the sign of a misspelling. Please check your
specfile.

python-ddiskit.noarch: W: invalid-url URL ddiskit
The value should be a valid, public HTTP, HTTPS, or FTP URL.

python-ddiskit.noarch: W: non-conffile-in-etc
/etc/bash_completion.d/ddiskit.bash
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

python-ddiskit.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/ddiskit/ddiskit.py 644 /usr/bin/python 
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-ddiskit.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/ddiskit/__init__.py 644 /usr/bin/python 
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

python-ddiskit.noarch: W: no-manual-page-for-binary ddiskit
Each executable in standard binary directories should have a man page.

1 packages and 0 specfiles checked; 3 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439894] Review Request: python-ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894



--- Comment #2 from Zdenek Dohnal  ---
Output of rpmlint for srpm:

rpmlint -iv python-ddiskit-3.1-1.fc26.src.rpm 
python-ddiskit.src: I: checking
python-ddiskit.src: W: unexpanded-macro Summary(C) %{sum}
This package contains a file whose path contains something that looks like an
unexpanded macro; this is often the sign of a misspelling. Please check your
specfile.

python-ddiskit.src: W: invalid-url URL ddiskit
The value should be a valid, public HTTP, HTTPS, or FTP URL.

python-ddiskit.src: E: unknown-key RSA#dec6ec3f (MD5
The package was signed, but with an unknown key. See the rpm --import option
for more information.

python-ddiskit.src: E: invalid-spec-name
Your spec filename must end with '.spec'. If it's not the case, rename your
file and rebuild your package.

python-ddiskit.src: W: invalid-url Source0: ddiskit-3.1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

1 packages and 0 specfiles checked; 2 errors, 3 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439894] Review Request: python-ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894

Zdenek Dohnal  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1439894] Review Request: python-ddiskit - tool for building Driver Update Disk modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1439894

Zdenek Dohnal  changed:

   What|Removed |Added

 CC||zdoh...@redhat.com
   Assignee|nob...@fedoraproject.org|zdoh...@redhat.com



--- Comment #1 from Zdenek Dohnal  ---
Hi Standa,

I will look into it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org