[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489



--- Comment #9 from Fedora Update System  ---
geometry-hpp-0.9.1-1.fc25, mapbox-variant-1.1.5-2.fc25 has been pushed to the
Fedora 25 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-08 10:21:01



--- Comment #8 from Fedora Update System  ---
geometry-hpp-0.9.1-1.fc26, mapbox-variant-1.1.5-2.fc26, wagyu-0.4.2-1.fc26 has
been pushed to the Fedora 26 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489
Bug 1440489 depends on bug 1440481, which changed state.

Bug 1440481 Summary: Review Request: mapbox-variant - A header-only alternative 
to boost::variant for C++11 and C++14
https://bugzilla.redhat.com/show_bug.cgi?id=1440481

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489



--- Comment #7 from Fedora Update System  ---
geometry-hpp-0.9.1-1.fc26, mapbox-variant-1.1.5-2.fc26, wagyu-0.4.2-1.fc26 has
been pushed to the Fedora 26 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f4c5f09cd5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
geometry-hpp-0.9.1-1.fc25, mapbox-variant-1.1.5-2.fc25 has been pushed to the
Fedora 25 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1a0090d6c8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489



--- Comment #5 from Fedora Update System  ---
geometry-hpp-0.9.1-1.fc25 mapbox-variant-1.1.5-2.fc25 has been submitted as an
update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1a0090d6c8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489



--- Comment #4 from Fedora Update System  ---
wagyu-0.4.2-1.fc26 geometry-hpp-0.9.1-1.fc26 mapbox-variant-1.1.5-2.fc26 has
been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f4c5f09cd5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/geometry-hpp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Parag AN(पराग)  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

==> this can be ignored.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "Unknown or generated". 19 files have unknown license.
 Detailed output of licensecheck in /home/parag/1440489-geometry-
 hpp/licensecheck.txt
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/include/mapbox(mapbox-
 variant-devel)

==> this is okay

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489

Tom Hughes  changed:

   What|Removed |Added

 Blocks||1438110




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1438110
[Bug 1438110] nodejs-mapnik-vector-tile-1.3.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489

Tom Hughes  changed:

   What|Removed |Added

 Blocks||1440508




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1440508
[Bug 1440508] Review Request: wagyu - A general library for geometry
operations of union, intersections, difference, and xor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489



--- Comment #1 from Tom Hughes  ---
Turns out there is a 0.9.1 tag:

Spec URL: http://tomh.fedorapeople.org//geometry-hpp.spec
SRPM URL: http://tomh.fedorapeople.org//geometry-hpp-0.9.1-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1440489] Review Request: geometry-hpp - Generic C++ interfaces for geometry types, collections, and features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1440489

Tom Hughes  changed:

   What|Removed |Added

 Depends On||1440481




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1440481
[Bug 1440481] Review Request: mapbox-variant - A header-only alternative to
boost::variant for C++11 and C++14
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org