[Bug 1442566] Review Request: nodejs-is-valid-app - Wrapper around is-valid-instance and is-registered for validating base plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442566

Jared Smith  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(jsmith.fedora@gma |needinfo?(mattia.verga@prot
   |il.com) |onmail.com)
Last Closed||2021-06-22 17:45:47



--- Comment #5 from Jared Smith  ---
@mattia.ve...@protonmail.com No, I'm no longer doing any NodeJS packaging in
Fedora.  Feel free to resubmit if you are interested in packaging it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1442566] Review Request: nodejs-is-valid-app - Wrapper around is-valid-instance and is-registered for validating base plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442566

Mattia Verga  changed:

   What|Removed |Added

 CC||mattia.ve...@protonmail.com
  Flags||needinfo?(jsmith.fedora@gma
   ||il.com)



--- Comment #4 from Mattia Verga  ---
Package was never imported, it will need a fresh review.

Jared, are you still interested in packaging this?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

[Bug 1442566] Review Request: nodejs-is-valid-app - Wrapper around is-valid-instance and is-registered for validating base plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442566

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/2WN7K4JMPYBW5WDLNJXSPOAFVJICPLZ3/

[Bug 1442566] Review Request: nodejs-is-valid-app - Wrapper around is-valid-instance and is-registered for validating base plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442566



--- Comment #2 from Jared Smith  ---
Can you please test again?  This is working fine for me:

https://koji.fedoraproject.org/koji/taskinfo?taskID=28446214

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/GQBGEESV7DNFSBIOBRDOVHENHQ57QTII/

[Bug 1442566] Review Request: nodejs-is-valid-app - Wrapper around is-valid-instance and is-registered for validating base plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1442566

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Tests fail:

+ /usr/bin/mocha -R spec
  is-valid-app

✓ should export a function

✓ should return false if the instance is not valid

1) should allow custom instance types

✓ should return false if a plugin is registered already
  3 passing (14ms)
  1 failing
  1) is-valid-app should allow custom instance types:
  AssertionError [ERR_ASSERTION]: 0 == 2
  + expected - actual
  +2
  -0

  at Context. (test.js:47:12)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org