[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397

Juan Orti  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2017-07-05 16:31:04



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #22 from Fedora Update System  ---
certbot-0.14.1-3.fc26, python-acme-0.14.1-1.fc26,
python-certbot-apache-0.14.1-1.fc26, python-certbot-nginx-0.14.1-1.fc26 has
been pushed to the Fedora 26 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #21 from Fedora Update System  ---
certbot-0.14.1-3.el7, python-acme-0.14.1-1.el7,
python-certbot-apache-0.14.1-1.el7, python-certbot-nginx-0.14.1-1.el7 has been
pushed to the Fedora EPEL 7 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #20 from Fedora Update System  ---
certbot-0.14.1-3.fc25, python-acme-0.14.1-1.fc25,
python-certbot-apache-0.14.1-1.fc25, python-certbot-nginx-0.14.1-1.fc25 has
been pushed to the Fedora 25 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #19 from Fedora Update System  ---
certbot-0.14.1-3.fc24, python-acme-0.14.1-1.fc24,
python-certbot-apache-0.14.1-1.fc24, python-certbot-nginx-0.14.1-1.fc24 has
been pushed to the Fedora 24 stable repository. If problems still persist,
please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #18 from Fedora Update System  ---
certbot-0.14.1-3.fc25, python-acme-0.14.1-1.fc25,
python-certbot-apache-0.14.1-1.fc25, python-certbot-nginx-0.14.1-1.fc25 has
been pushed to the Fedora 25 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1071b956e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #17 from Fedora Update System  ---
certbot-0.14.1-3.el7, python-acme-0.14.1-1.el7,
python-certbot-apache-0.14.1-1.el7, python-certbot-nginx-0.14.1-1.el7 has been
pushed to the Fedora EPEL 7 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-acdfbe8cfa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #16 from Fedora Update System  ---
certbot-0.14.1-3.fc24, python-acme-0.14.1-1.fc24,
python-certbot-apache-0.14.1-1.fc24, python-certbot-nginx-0.14.1-1.fc24 has
been pushed to the Fedora 24 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c651872919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
certbot-0.14.1-3.fc26, python-acme-0.14.1-1.fc26,
python-certbot-apache-0.14.1-1.fc26, python-certbot-nginx-0.14.1-1.fc26 has
been pushed to the Fedora 26 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64270716a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #14 from Fedora Update System  ---
certbot-0.14.1-3.fc25 python-acme-0.14.1-1.fc25
python-certbot-apache-0.14.1-1.fc25 python-certbot-nginx-0.14.1-1.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1071b956e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #13 from Fedora Update System  ---
certbot-0.14.1-3.fc25 python-acme-0.14.1-1.fc25
python-certbot-apache-0.14.1-1.fc25 python-certbot-nginx-0.14.1-1.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f1071b956e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #12 from Fedora Update System  ---
certbot-0.14.1-3.fc24 python-acme-0.14.1-1.fc24
python-certbot-apache-0.14.1-1.fc24 python-certbot-nginx-0.14.1-1.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c651872919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #11 from Fedora Update System  ---
certbot-0.14.1-3.fc24 python-acme-0.14.1-1.fc24
python-certbot-apache-0.14.1-1.fc24 python-certbot-nginx-0.14.1-1.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c651872919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #10 from Fedora Update System  ---
certbot-0.14.1-3.fc26 python-acme-0.14.1-1.fc26
python-certbot-apache-0.14.1-1.fc26 python-certbot-nginx-0.14.1-1.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64270716a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #9 from Fedora Update System  ---
certbot-0.14.1-3.fc26 python-acme-0.14.1-1.fc26
python-certbot-apache-0.14.1-1.fc26 python-certbot-nginx-0.14.1-1.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-64270716a0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #8 from Fedora Update System  ---
certbot-0.14.1-3.el7 python-acme-0.14.1-1.el7
python-certbot-apache-0.14.1-1.el7 python-certbot-nginx-0.14.1-1.el7 has been
submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-acdfbe8cfa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #7 from Fedora Update System  ---
certbot-0.14.1-3.el7 python-acme-0.14.1-1.el7
python-certbot-apache-0.14.1-1.el7 python-certbot-nginx-0.14.1-1.el7 has been
submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-acdfbe8cfa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-certbot-nginx

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397

Juan Orti  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Juan Orti  ---
Package is APPROVED.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 59 files have unknown license. Detailed output of
 licensecheck in /home/juan/1444397-python-certbot-
 nginx/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -certbot-nginx , python3-certbot-nginx
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are 

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #4 from James Hogarth  ---
Updated now that 0.14.1 was released with bugfixes:

Spec URL:
https://fedorapeople.org/~jhogarth/python-certbot-nginx/python-certbot-nginx.spec
SRPM URL:
https://fedorapeople.org/~jhogarth/python-certbot-nginx/python-certbot-nginx-0.14.1-1.fc27.src.rpm

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19590320

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #3 from James Hogarth  ---
Err used the wrong srpm that didn't include your comment about tests ..

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=19512549

The files above are correct though so fedora-review will work

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #2 from James Hogarth  ---
Oh, how embarrassing ... I'm sure my typing is only getting worse with age :/

Anyway .. 0.14.0 is out so 


Spec URL:
https://fedorapeople.org/~jhogarth/python-certbot-nginx/python-certbot-nginx.spec
SRPM URL:
https://fedorapeople.org/~jhogarth/python-certbot-nginx/python-certbot-nginx-0.14.0-1.fc27.src.rpm

Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19512495

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397



--- Comment #1 from Juan Orti  ---
You've misspelled nginx in the URL.

You have zero-lenght files in
/usr/lib/python2.7/site-packages/certbot_nginx/tests/testdata/etc_nginx/mime.types
and
/usr/lib/python3.6/site-packages/certbot_nginx/tests/testdata/etc_nginx/mime.types.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444397] Review Request: python-certbot-nginx - nginx plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444397

Juan Orti  changed:

   What|Removed |Added

 CC||j.orti.alca...@gmail.com
   Assignee|nob...@fedoraproject.org|j.orti.alca...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org