[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



--- Comment #12 from Fedora Update System  ---
nodejs-eventemitter3-2.0.3-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #11 from Parag Nemade  ---
I have been trying mockbuild then scratch build then realized nodejs-assume
failed to build on koji, hence its not available at the moment.

Looks like some issues with nodejs-balanced-match package. It also failed to
build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Jared Smith  changed:

   What|Removed |Added

 CC||jsmith.fed...@gmail.com



--- Comment #10 from Jared Smith  ---
For what it's worth, nodejs-assume is now packaged in Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Parag Nemade  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-05-05 00:34:57



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
nodejs-eventemitter3-2.0.3-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a94909ba87

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #8 from Fedora Update System  ---
nodejs-eventemitter3-2.0.3-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a94909ba87

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Jared Smith  changed:

   What|Removed |Added

 Blocks||1446571




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1446571
[Bug 1446571] Review Request: nodejs-http-proxy - A full-featured http
proxy for node.js
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #7 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-eventemitter3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #6 from Parag Nemade  ---
Thanks Tom for this package review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Tom Hughes  ---
Yes that's what I had in mind.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #4 from Parag Nemade  ---
I am not sure if I got you correct but here is the updated SRPM. Please ask if
this needs some change.

Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-eventemitter3.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-eventemitter3-2.0.3-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #3 from Tom Hughes  ---
The tests are really enabled so setting enable_tests is a bit misleading - the
real test can be run with "mocha test.js" and do pass but they require assume
which isn't packaged.

I suggest adding the code to tun the real tests but disabled and with a comment
explaining why, then make the basic load test run when tests are disabled.

Also there's an rpmlint waring about mixed spaces and tabs and test.js is
getting included in the built package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Tom Hughes  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||t...@compton.nu
   Assignee|nob...@fedoraproject.org|t...@compton.nu
  Flags||fedora-review?



--- Comment #2 from Tom Hughes  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 24 files have
 unknown license. Detailed output of licensecheck in /home/tom/1444766
 -nodejs-eventemitter3/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: 

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Parag Nemade  changed:

   What|Removed |Added

 Blocks||1447201




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1447201
[Bug 1447201] Review Request: nodejs-http-server - Simple,
zero-configuration command-line http server
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1444766] Review Request: nodejs-eventemitter3 - EventEmitter3 is a high performance EventEmmitter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1444766



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19174213

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org