[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321

Oliver Gutiérrez  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |EOL
Last Closed||2018-05-04 06:48:12



--- Comment #19 from Oliver Gutiérrez  ---
Package has been already added to Fedora and it is being maintained by me and
Alexander Bokovoy. Closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #18 from Fedora End Of Life  ---
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #17 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/freeipa-desktop-profile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321

Alberto Ruiz  changed:

   What|Removed |Added

 Status|MODIFIED|ASSIGNED
  Flags||fedora-review+



--- Comment #16 from Alberto Ruiz  ---
Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

  The installation error is caused by a problem in the freeipa package in
rawhide, the problem is well known and a bug
(https://pagure.io/freeipa/issue/6927) has been filed about it. 


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 8 files have unknown license. Detailed
 output of licensecheck in /home/aruiz/1445321-freeipa-desktop-
 profile/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should 

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321

Alberto Ruiz  changed:

   What|Removed |Added

 CC||aruiz...@redhat.com
   Assignee|oguti...@redhat.com |aruiz...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #15 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-i386/00545801-freeipa-desktop-profile/freeipa-desktop-profile-0.0.5-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #14 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-i386/00545782-freeipa-desktop-profile/freeipa-desktop-profile-0.0.5-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #13 from Oliver Gutiérrez  ---


Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00545779-freeipa-desktop-profile/freeipa-desktop-profile-0.0.5-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #12 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544832-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #11 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544827-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #10 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-i386/00544824-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-2.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #9 from Oliver Gutiérrez  ---

Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544816-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #8 from Oliver Gutiérrez  ---


Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544816-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.noarch.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #7 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544815-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #6 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544783-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #5 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544771-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #4 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00544715-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321

Oliver Gutiérrez  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



--- Comment #3 from Oliver Gutiérrez  ---
Spec URL:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ogutierrez/freeipa-desktop-profile/fedora-26-x86_64/00543607-freeipa-desktop-profile/freeipa-desktop-profile-0.0.4-1.fc26.src.rpm
Description: A module for FreeIPA to allow managing desktop profiles defined
by Fleet Commander.
Fedora Account System Username: ogutierrez

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321

Oliver Gutiérrez  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|oguti...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #2 from Oliver Gutiérrez  ---
rpmlint output:

freeipa-desktop-profile.spec:32: W: macro-in-comment %__mkdir_p
freeipa-desktop-profile.spec:32: W: macro-in-comment %buildroot
freeipa-desktop-profile.spec:32: W: macro-in-comment %_datadir
freeipa-desktop-profile.spec:38: W: macro-in-comment %__cp
freeipa-desktop-profile.spec:38: W: macro-in-comment %buildroot
freeipa-desktop-profile.spec:38: W: macro-in-comment %_datadir
freeipa-desktop-profile.spec:65: W: macro-in-comment %_datadir
freeipa-desktop-profile.spec: W: invalid-url Source0:
freeipa-desktop-profile-0.0.4.tar.gz
0 packages and 1 specfiles checked; 0 errors, 8 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321



--- Comment #1 from Oliver Gutiérrez  ---
Updated specfile to fix bogus date:
https://raw.githubusercontent.com/olivergs/freeipa-desktop-profile/master/freeipa-desktop-profile.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445321] Review Request: freeipa-desktop-profile - FreeIPA desktop profiles module for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445321

Oliver Gutiérrez  changed:

   What|Removed |Added

Version|rawhide |26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org