[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #18 from Fedora Update System  ---
unicode-emoji-4.0-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #17 from Fedora Update System  ---
unicode-emoji-4.0-3.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-15 08:52:31



--- Comment #16 from Fedora Update System  ---
unicode-emoji-4.0-3.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #15 from Fedora Update System  ---
unicode-emoji-4.0-3.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-984da542ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #14 from Fedora Update System  ---
unicode-emoji-4.0-3.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-eeff7034d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
unicode-emoji-4.0-3.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d09058cab4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #12 from Fedora Update System  ---
unicode-emoji-4.0-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-984da542ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #11 from Fedora Update System  ---
unicode-emoji-4.0-3.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-d09058cab4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #10 from Fedora Update System  ---
unicode-emoji-4.0-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-eeff7034d9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #9 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/unicode-emoji

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Parag AN(पराग)  ---
Above update looks good now.
Package APPROVED.

Proceed now with step 7 given on
https://fedoraproject.org/wiki/New_package_process_for_existing_contributors

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #7 from Mike FABIAN  ---

I updated the files to fix these issues:

Spec URL: https://mfabian.fedorapeople.org/misc/unicode-emoji.spec
SRPM URL:
https://mfabian.fedorapeople.org/misc/unicode-emoji-4.0-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #6 from Parag AN(पराग)  ---
Everytime package spec is modified/updated its good to increase the release
number and add appropriate changelog entry.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
1) The only remaining issue now is that after installing this updated package,
no package owns directory /usr/share/unicode/emoji. To fix this add following
to %files as well

%dir %{emojidir}

2) Shouldn't license be "Unicode"? Please check this
https://fedoraproject.org/wiki/Licensing/Unicode

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/unicode/emoji
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/unicode/emoji
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/unicode(unicode-
 ucd, cldr-emoji-annotation)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #5 from Mike FABIAN  ---
(In reply to Parag AN(पराग) from comment #4)
> 1) Fix following rpmlint issues
> unicode-emoji.src: E: description-line-too-long C Unicode Emoji Data Files
> are the machine-readable emoji data files associated with
> 
> unicode-emoji.src: W: file-size-mismatch copyright.html = 17417,
> http://www.unicode.org/copyright.html = 16571
> ==> Re-download the upstream file and build the srpm
> 
> 2)License file copyright.html is not marked as %license
> 
> 3) ReadMe.txt file should be marked as %doc

I updated the files to fix these issues:

Spec URL: https://mfabian.fedorapeople.org/misc/unicode-emoji.spec
SRPM URL:
https://mfabian.fedorapeople.org/misc/unicode-emoji-4.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #4 from Parag AN(पराग)  ---
1) Fix following rpmlint issues
unicode-emoji.src: E: description-line-too-long C Unicode Emoji Data Files are
the machine-readable emoji data files associated with

unicode-emoji.src: W: file-size-mismatch copyright.html = 17417,
http://www.unicode.org/copyright.html = 16571
==> Re-download the upstream file and build the srpm

2)License file copyright.html is not marked as %license

3) ReadMe.txt file should be marked as %doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #3 from Mike FABIAN  ---
Spec URL: https://mfabian.fedorapeople.org/misc/unicode-emoji.spec>
SRPM URL:
https://mfabian.fedorapeople.org/misc/unicode-emoji-4.0-1.fc27.src.rpm
Description: Unicode Emoji Data Files are the machine-readable emoji data files
associated with http://www.unicode.org/reports/tr51/index.html
Fedora Account System Username: mfabia

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #2 from Mike FABIAN  ---
Spec URL: https://mfabian.fedorapeople.org/misc/unicode-emoji.spechere>
SRPM URL:
https://mfabian.fedorapeople.org/misc/unicode-emoji-4.0-1.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445366] Review Request: unicode-emoji - Unicode Emoji Data Files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445366



--- Comment #1 from Mike FABIAN  ---
https://mfabian.fedorapeople.org/misc/unicode-emoji.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org