[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-05-04 11:31:39 |2017-07-07 18:54:41



--- Comment #12 from Fedora Update System  ---
python-cysignals-1.3.2-3.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|RAWHIDE |---
   Keywords||Reopened



--- Comment #11 from Fedora Update System  ---
python-cysignals-1.3.2-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-da8a082a94

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #10 from Fedora Update System  ---
python-cysignals-1.3.2-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-da8a082a94

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411

Paulo Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-05-04 11:31:39



--- Comment #9 from Paulo Andrade  ---
  f25 and f26 branches were asked. For the moment the
package is rawhide only, for sagemath update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-cysignals

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Jerry James  ---
Okay, that looks good.  This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #6 from Paulo Andrade  ---
Spec URL: https://pcpa.fedorapeople.org/python-cysignals.spec
SRPM URL: https://pcpa.fedorapeople.org/python-cysignals-1.3.2-2.fc27.src.rpm

  Changed to install .h, .pxi and .pxd files in a -devel package.
This should require changes to the spec of python-fpylll review
request, I will confirm.

  Sorry for the cut and not properly noticing the spaces only
in some BuildRequires. Fixed now.

  The Popen calls are on doctests of .pyx files. For safety I changed
the files before every build; no changes in %install because it
pass --skip-build in eval of %py{2,3}_install.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #5 from Jerry James  ---
(In reply to Paulo Andrade from comment #4)
>   I did not create a -devel at first subpackage because it is not the
> only python package installing private headers:

That makes sense for packages like python2-cffi and python2-Cython, which use
those header files for normal functioning.  Some of those seem like bugs to me,
though.  For this package, in particular, the header files won't be needed at
runtime, just the shared object, so I believe a -devel subpackage is needed. 
We can ask about this on -devel-list if you want.

>   At first, and because only sagemath uses it, I would prefer to avoid
> conflicts using a version not matching the one required by the sagemath
> package.

Sure, that's fine.

>   I did not find any match for ' \t' or '\t '. But there are lines starting
> with less than 8 spaces. That may depend on having tabs set to 4 or 8
> spaces...

I'm looking at the spec file in Emacs.  Typing 'C-s C-q TAB' shows that there
are tabs on almost all of the header lines, but "BuildRequires: python2-devel",
"BuildRequires: python3-devel", and "BuildRequires: python-sphinx" all have
spaces instead, as well as the "Summary" line for the -doc subpackage.

One other question: do the Popen() invocation changes made in the %check script
need to be made in the actual installed files, too?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #4 from Paulo Andrade  ---
Spec URL: https://pcpa.fedorapeople.org/python-cysignals.spec
SRPM URL: https://pcpa.fedorapeople.org/python-cysignals-1.3.2-2.fc27.src.rpm

  I might have made some change to the spec, but now I am
sure it matches the one in the srpm.
  Your suggested patch was added verbatim, and also a few
extra changes to make it "almost" pass all %check tests with
python3; apparently is is not yet fully functional with python3,
or this version has issues. Major issue was a Popen('python') that
would invoke python2.

> - Header files in -devel subpackage, if present.
>   Note: python2-cysignals : /usr/lib64/python2.7/site-
>   packages/cysignals/debug.h python2-cysignals : /usr/lib64/python2.7/site-
[...]
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages.
>   Also, is it really necessary to install the .pxd and .pxi files?
  I did not create a -devel at first subpackage because it is not the
only python package installing private headers:
$ rpm -qf $(find /usr/lib64/python2.7/site-packages/ | grep '\.h$') | grep -v
cysignals | grep -v sagemath | uniq 
python2-zmq-16.0.2-3.fc26.x86_64
python2-astropy-1.3.2-1.fc27.x86_64
python2-scipy-0.18.0-3.fc26.x86_64
python2-cffi-1.10.0-1.fc27.x86_64
python2-lxml-3.7.2-2.fc26.x86_64
python2-numpy-1.12.1-1.fc27.x86_64
python2-numpy-f2py-1.12.1-1.fc27.x86_64
python2-Cython-0.25.2-4.fc26.x86_64
  The .pxi and .pxd are used during sagemath build.

> - %{?python_provide:%python_provide python3-%{modname}} is missing from the
>   python3 package
  Fixed.

> - The cysignals-CSI script has a shebang that invokes /usr/bin/env.  It should
>   invoke the correct python interpreter directly instead.
  Now it installs cysignals-CSI-2 and cysignals-CSI-3 files, and the C
source was patched to invoke the correct one.

> - Shouldn't the license be LGPLv3+?
  Corrected.

> - The license file is not installed if only the -doc subpackage is installed.
  Added a requires to python-cysignals

> - The -doc subpackage doesn't own /usr/share/doc/python-cysignals, and neither
>   does any other subpackage.
  Corrected.

> - I assume the intent is to unbundle this package from sagemath.  Is that
>   right?  If so, the fact that sagemath also owns
>   /usr/lib64/python2.7/site-packages/cysignals can be ignored.
  Yes. Only sagemath uses it, thus also not the latest version.

> - The changelog is missing.
  Fixed.

> - The URL field is missing.  It should probably point to either
>   http://cysignals.readthedocs.io/en/latest/ or
>   https://github.com/sagemath/cysignals.
  Corrected.

> - The latest version is 1.6.4.
  At first, and because only sagemath uses it, I would prefer to avoid
conflicts using a version not matching the one required by the sagemath
package.

> - The package checks for the emms assembly instruction.  That's okay on
>   x86_64, where it is universally available, and also okay on non-x86
>   architectures, where it is universally unavailable.  However, on i386, that
>   instruction may be detected on the builders and compiled in, but we can't
>   guarantee that all i386 users have that instruction available.  Somehow, use
>   of that instruction has to be disabled for i386 builds.
  I just #if 0'ed the C source. It apparently is only required for solaris.

> - The spec file uses both tabs and spaces.
  I did not find any match for ' \t' or '\t '. But there are lines starting
with less than 8 spaces. That may depend on having tabs set to 4 or 8 spaces...

> - /usr/share/doc/python-cysignals/html/.buildinfo can be excluded from the
>   -doc subpackage.
  Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #3 from Jerry James  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
===
- Header files in -devel subpackage, if present.
  Note: python2-cysignals : /usr/lib64/python2.7/site-
  packages/cysignals/debug.h python2-cysignals : /usr/lib64/python2.7/site-
  packages/cysignals/macros.h python2-cysignals : /usr/lib64/python2.7
  /site-packages/cysignals/pxi.h python2-cysignals : /usr/lib64/python2.7
  /site-packages/cysignals/signals.h python2-cysignals :
  /usr/lib64/python2.7/site-packages/cysignals/signals_api.h
  python2-cysignals : /usr/lib64/python2.7/site-
  packages/cysignals/struct_signals.h python3-cysignals :
  /usr/lib64/python3.6/site-packages/cysignals/debug.h python3-cysignals :
  /usr/lib64/python3.6/site-packages/cysignals/macros.h python3-cysignals :
  /usr/lib64/python3.6/site-packages/cysignals/pxi.h python3-cysignals :
  /usr/lib64/python3.6/site-packages/cysignals/signals.h python3-cysignals
  : /usr/lib64/python3.6/site-packages/cysignals/signals_api.h
  python3-cysignals : /usr/lib64/python3.6/site-
  packages/cysignals/struct_signals.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages.
  Also, is it really necessary to install the .pxd and .pxi files?

- %{?python_provide:%python_provide python3-%{modname}} is missing from the
  python3 package

- The cysignals-CSI script has a shebang that invokes /usr/bin/env.  It should
  invoke the correct python interpreter directly instead.

- Shouldn't the license be LGPLv3+?

- The license file is not installed if only the -doc subpackage is installed.

- The -doc subpackage doesn't own /usr/share/doc/python-cysignals, and neither
  does any other subpackage.

- I assume the intent is to unbundle this package from sagemath.  Is that
  right?  If so, the fact that sagemath also owns
  /usr/lib64/python2.7/site-packages/cysignals can be ignored.

- The changelog is missing.

- The URL field is missing.  It should probably point to either
  http://cysignals.readthedocs.io/en/latest/ or
  https://github.com/sagemath/cysignals.

- The latest version is 1.6.4.

- The package checks for the emms assembly instruction.  That's okay on
  x86_64, where it is universally available, and also okay on non-x86
  architectures, where it is universally unavailable.  However, on i386, that
  instruction may be detected on the builders and compiled in, but we can't
  guarantee that all i386 users have that instruction available.  Somehow, use
  of that instruction has to be disabled for i386 builds.

- The spec file uses both tabs and spaces.

- /usr/share/doc/python-cysignals/html/.buildinfo can be excluded from the
  -doc subpackage.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* LGPL (v3 or later)", "LGPL (v3 or later)", "GPL
 (v3)", "Unknown or generated". 20 files have unknown license.
[!]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/python-cysignals
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/python-
 cysignals
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/python2.7/site-
 packages/cysignals(sagemath-core)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411



--- Comment #2 from Jerry James  ---
Created attachment 1274064
  --> https://bugzilla.redhat.com/attachment.cgi?id=1274064=edit
Patch to remove python preloading

Two quick notes: fedora-review says the spec file at the URL given above does
not match the spec file inside the SRPM.  Also, the cysignals-CSI script
attempts to "preload the right Python library."  However, Fedora's gdb is
already linked with the python 3 library.  The preload attempt is both
unnecessary and wrong, as it causes gdb to crash on startup.  I think that the
rest of %prep after %setup should be removed, and the attached patch applied
instead.  I haven't tried yet, but I expect that will fix the problem with
%check as well.

The first hunk of the patch tells gdb that it can load an init file from
anywhere.  I'm not sure that is necessary.  You might want to remove that part.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411

Jerry James  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||loganje...@gmail.com
   Assignee|nob...@fedoraproject.org|loganje...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jerry James  ---
I will take this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445411] Review Request: python-cysignals - Interrupt and signal handling for Cython

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445411

Paulo Andrade  changed:

   What|Removed |Added

 Blocks||1445412




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1445412
[Bug 1445412] Review Request: python-fpylll - A Python wrapper for fplll
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org