[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-06-19 03:35:14 |2017-06-25 17:22:20



--- Comment #14 from Fedora Update System  ---
python-testfixtures-4.14.3-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|CURRENTRELEASE  |---



--- Comment #13 from Fedora Update System  ---
python-testfixtures-4.14.3-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-298c99b698

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #12 from Fedora Update System  ---
python-testfixtures-4.14.3-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-298c99b698

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed|2017-06-18 17:56:34 |2017-06-19 03:35:14



--- Comment #11 from Björn "besser82" Esser  ---
(In reply to David Hannequin from comment #10)
> This package don't work on Fedora 25.

That's because of missing BuildRequires in Fedora <= 25.


> And you stole my work... 

You didn't read the Fedora CLA, huh?  Read it carefully and then I expect you
to be sorry…


> Be serious and made this package work.

Is there any guideline around enforcing me to do so?  It seems your parents
didn't teach you about politeness…

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

David Hannequin  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|CURRENTRELEASE  |---



--- Comment #10 from David Hannequin  ---
This package don't work on Fedora 25. And you stole my work... 

Be serious and made this package work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed|2017-05-01 14:16:40 |2017-06-18 17:56:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #9 from Björn "besser82" Esser  ---
*** Bug 1389346 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

David Hannequin  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 CC||david.hanneq...@gmail.com
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #8 from David Hannequin  ---
Why 2 bug (Bug 1389346) for 1 package ???

What do you do ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824
Bug 1445824 depends on bug 1445822, which changed state.

Bug 1445822 Summary: Review Request: python-nose_fixes - Plugin to make nose 
behave better
https://bugzilla.redhat.com/show_bug.cgi?id=1445822

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-01 14:16:40



--- Comment #7 from Fedora Update System  ---
python-testfixtures-4.13.5-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-testfixtures-4.13.5-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e52596821

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #5 from Fedora Update System  ---
python-testfixtures-4.13.5-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-3e52596821

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-testfixtures

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Christian Dersch  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Christian Dersch  ---
Approved, issue fixed :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #2 from Björn "besser82" Esser  ---
Updated package
---


Changelog:

  * Wed Apr 26 2017 Björn Esser  - 4.13.5-0.2
  - Fix E: python-bytecode-wrong-magic-value

  * Wed Apr 26 2017 Björn Esser  - 4.13.5-0.1
  - Initial rpm-release (rhbz#1445824)


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/python-testfixtures.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/python-testfixtures-4.13.5-0.2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824



--- Comment #1 from Christian Dersch  ---
Not approved, rpmlint reports an issue that should be fixed.


Package Review  
==  

Legend: 
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated   
[ ] = Manual review needed  


Issues: 
=== 
- check rpmlint messages, there are reports of type:
python3-testfixtures.noarch: E: python-bytecode-wrong-magic-value
/usr/lib/python3.6/site-packages/testfixtures/comparison.pyc expected 3379
(3.6), found 62211 (2.7)


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 78 files have
 unknown license. Detailed output of licensecheck in
 /home/review/1445824-python-testfixtures/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
==> is noarch

[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1445824] Review Request: python-testfixtures - Collection of helpers and mock objects for unit tests and doc tests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1445824

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1124239
 Depends On||1445822




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1124239
[Bug 1124239] python-gensim-2.0.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1445822
[Bug 1445822] Review Request: python-nose_fixes - Plugin to make nose
behave better
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org