[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568

Parag Nemade  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG
Last Closed||2017-05-03 04:56:43



--- Comment #6 from Parag Nemade  ---
I really don't know why fedora-review failed to catch this package already
exists in fedora.

When I now tried to submit pkgdb request, I come to know this is already in
Fedora :-(


Sorry Tom I missed this and depended on fedora-review output.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Tom Hughes  ---
Great. Package approved then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568



--- Comment #4 from Parag Nemade  ---
I have removed the shebang line 

Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-opener.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-opener-1.4.3-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568



--- Comment #3 from Tom Hughes  ---
A few rpmlint warnings:

nodejs-opener.noarch: W: spelling-error Summary(en_US) webpages -> web pages,
web-pages, passages

and:

nodejs-opener.noarch: E: wrong-script-interpreter
/usr/lib/node_modules/opener/opener.js /usr/bin/env node
nodejs-opener.noarch: E: non-executable-script
/usr/lib/node_modules/opener/opener.js 644 /usr/bin/env node

Those two relate to the fact that it is designed to be usable as a command line
program, so maybe it should be linked to bin? Though it would need to be made
executable and ideally the use of /usr/bin/env patched out.

Otherwise the #! should likely be removed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568

Tom Hughes  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||t...@compton.nu
   Assignee|nob...@fedoraproject.org|t...@compton.nu
  Flags||fedora-review?



--- Comment #2 from Tom Hughes  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/package/nodejs-opener
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like) do What The Fuck you want to Public License
 (v2)", "Unknown or generated". 4 files have unknown license. Detailed
 output of licensecheck in /home/tom/1446568-nodejs-
 opener/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 

[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568

Parag Nemade  changed:

   What|Removed |Added

 Blocks||1447201




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1447201
[Bug 1447201] Review Request: nodejs-http-server - Simple,
zero-configuration command-line http server
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568

Parag Nemade  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1446568] Review Request: nodejs-opener - Opens stuff, like webpages and files and executables, cross-platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1446568



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19268951

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org