[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230
Bug 1447230 depends on bug 1447229, which changed state.

Bug 1447229 Summary: Review Request: nodejs-url-join - Join all arguments 
together and normalize the resulting url
https://bugzilla.redhat.com/show_bug.cgi?id=1447229

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230
Bug 1447230 depends on bug 1447224, which changed state.

Bug 1447224 Summary: Review Request: nodejs-he - A robust HTML entity 
encoder/decoder written in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1447224

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230

Parag Nemade  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-05-04 23:45:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230

Parag Nemade  changed:

   What|Removed |Added

 Depends On||1447224, 1447229




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1447224
[Bug 1447224] Review Request: nodejs-he - A robust HTML entity
encoder/decoder written in JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1447229
[Bug 1447229] Review Request: nodejs-url-join - Join all arguments together
and normalize the resulting url
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230

Parag Nemade  changed:

   What|Removed |Added

 Blocks||1447201




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1447201
[Bug 1447201] Review Request: nodejs-http-server - Simple,
zero-configuration command-line http server
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-ecstatic

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsmith.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review+



--- Comment #2 from Jared Smith  ---
Package is APPROVED.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 80 files have
 unknown license. Detailed output of licensecheck in
 /home/jsmith/Documents/Personal/Reviews/1447230-nodejs-
 ecstatic/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in 

[Bug 1447230] Review Request: nodejs-ecstatic - A static file server middleware that works with core http , express or on the CLI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447230



--- Comment #1 from Parag Nemade  ---
This package built on koji: 
https://koji.fedoraproject.org/koji/taskinfo?taskID=19364014

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org