[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-09 17:23:56



--- Comment #7 from Fedora Update System  ---
libarcus-2.5.0-1.fc26, libsavitar-0-0.1.20170501git1ad7ddb.fc26,
python-uranium-2.5.0-2.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
libarcus-2.5.0-1.fc26, libsavitar-0-0.1.20170501git1ad7ddb.fc26,
python-uranium-2.5.0-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e78f6e9169

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732



--- Comment #5 from Fedora Update System  ---
libarcus-2.5.0-1.fc26 libsavitar-0-0.1.20170501git1ad7ddb.fc26
python-uranium-2.5.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-e78f6e9169

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732



--- Comment #4 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libsavitar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732

Jaroslav Škarvada  changed:

   What|Removed |Added

  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732



--- Comment #3 from Miro Hrončok  ---
Spec URL: https://churchyard.fedorapeople.org/SRPMS/libsavitar.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/libsavitar-0-0.1.20170501git1ad7ddb.fc25.src.rpm

Fixed the first two things.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732



--- Comment #2 from Miro Hrončok  ---
Thanks for feedback.

(In reply to Jaroslav Škarvada from comment #1)
> - I think Version: should be 0 (not 0.0, no upstream release yet) and
> Release: 0.1.* (pre-release, safety approach in case upstream would
> officially release version 0), but this is minor.

You are right.

> - libsavitar.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libSavitar.so.0.1.0 /lib64/libm.so.6
> Could you try, e.g.:
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-
> dependency

Will look at that.

> - Does it work with python2? I wasn't able to find anything related. If yes,
> python2 package will be needed.

I don't know (but I don't think so) and I don't care about Python 2. If
somebody will need this on Python 2 as well, they can join in and add a
subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732



--- Comment #1 from Jaroslav Škarvada  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* BSD (3 clause)", "AGPL (v3)", "GPL (v3 or
 later)", "Unknown or generated", "AGPL (v3 or later)". 16 files have
 unknown license. Detailed output of licensecheck in /home/yarda/git-
 fedora/libsavitar/1447732-libsavitar/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib64/cmake(cmake,
 pulseaudio-libs-devel, plasma-breeze, qt5-qtlocation, gtk-doc,
 qt5-qtbase)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python3-savitar , libsavitar-debuginfo
[-]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jskar...@redhat.com
   Assignee|nob...@fedoraproject.org|jskar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1447732] Review Request: libsavitar - C++ implementation of 3mf loading with SIP Python bindings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1447732

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1393176




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393176
[Bug 1393176] Upstream has changed and there is a newer version available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org