[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #11 from Fedora Update System  ---
python-minidb-2.0.2-1.fc26 has been pushed to the Fedora 26 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #10 from Fedora Update System  ---
python-minidb-2.0.2-1.fc25 has been pushed to the Fedora 25 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-26 22:51:49



--- Comment #9 from Fedora Update System  ---
python-minidb-2.0.2-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #8 from Fedora Update System  ---
python-minidb-2.0.2-1.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ea428d7f3f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #7 from Fedora Update System  ---
python-minidb-2.0.2-1.fc25 has been pushed to the Fedora 25 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f51d554657

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
python-minidb-2.0.2-1.fc24 has been pushed to the Fedora 24 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0aa98a275c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #5 from Fedora Update System  ---
python-minidb-2.0.2-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-0aa98a275c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #4 from Fedora Update System  ---
python-minidb-2.0.2-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f51d554657

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #3 from Fedora Update System  ---
python-minidb-2.0.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-ea428d7f3f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149



--- Comment #2 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-minidb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149

Göran Uddeborg  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Göran Uddeborg  ---
The fedora-review and rpmlint commands seem to fail on the %python_provide
macro.  At least I couldn't get it to work.  So this is a more manual review,
apologies if the formatting got sub-standard because of that.

Package Review
==

Legend:
[+] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

[+] rpmlint must be run on the source rpm and all binary rpms the build
produces.

As mentioned, rpmlint fails on python_provide for me.  Obviously not a problem
with the package.

python-minidb.src:37: W: macro-in-comment %check
python-minidb.src: E: specfile-error error: line 22: Unknown tag:
%python_provide: ERROR: python3-minidb not recognized.
python-minidb.src: E: specfile-error error: query of specfile
/tmp/rpmlint.python-minidb-2.0.2-1.fc26.src.rpm._edaamvy/python-minidb.spec
failed, can't parse
2 packages and 0 specfiles checked; 2 errors, 1 warnings.

[+] The package must be named according to the Package Naming Guidelines.
[+] The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] The package must meet the Packaging Guidelines.
[+] The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
[+] The License field in the package spec file must match the actual license. 
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %license.
[+] The spec file must be written in American English. 
[+] The spec file for the package MUST be legible. 
[+] The sources used to build the package must match the upstream source, as
provided in the spec URL.
[+] The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
[-] If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
[-] The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[-] Every binary RPM package (or subpackage) which stores shared library files
(not just symlinks) in any of the dynamic linker's default paths, must call
ldconfig in %post and %postun. 
[+] Packages must NOT bundle copies of system libraries.
[-] If the package is designed to be relocatable, the packager must state this
fact in the request for review, along with the rationalization for relocation
of that specific package.
[+] A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
[+] A Fedora package must not list a file more than once in the spec file's
%files listings.
[+] Permissions on files must be set properly.
[+] Each package must consistently use macros. 
[+] The package must contain code, or permissible content. 
[-] Large documentation files must go in a -doc subpackage.
[+] If a package includes something as %doc, it must not affect the runtime of
the application.
[-] Static libraries must be in a -static package. 
[-] Development files must be in a -devel package. 
[-] In the vast majority of cases, devel packages must require the base package
using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release} 
[-] Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
[-] Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section.
[+] Packages must not own files or directories already owned by other packages.
[+] All filenames in rpm packages must be valid UTF-8.


- Python specific MUST items -

[-] If you build for more than one python runtime you must use the
%python_provide macro.
[+] If you build for a single python runtime you must add %python_provide
python-$module so that the current default python is provided from the
unversioned python package.
[+] Python modules must be built from source.
[+] Python modules must not download any dependencies during the build process.
[-] When building a compat package, it must install using easy_install -m so it
won't conflict 

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149

Göran Uddeborg  changed:

   What|Removed |Added

 CC||goe...@uddeborg.se
   Assignee|nob...@fedoraproject.org|goe...@uddeborg.se
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450149] Review Request: python-minidb - Simple python object store

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450149

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||1445286
  Alias||python-minidb




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1445286
[Bug 1445286] Urlwatch requires python3-minidb, but nothing provides it
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org