[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Benjamin Tissoires  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
  Flags|needinfo?(btissoir@redhat.c |
   |om) |
Last Closed||2017-07-18 02:50:39



--- Comment #5 from Benjamin Tissoires  ---
ratbagd has been merged into libratbag, so there is no point having a separate
package for it anymore. I'll update the requested changes in the libratbag RPM
once upstream settle on something.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Peter Hutterer  changed:

   What|Removed |Added

  Flags||needinfo?(btissoir@redhat.c
   ||om)



--- Comment #4 from Peter Hutterer  ---
merci, looks like there's still a few things left to do tough

* libratbag dependency upstream is >= 0.6, spec file is still at 0.4

* rpmlint complains: "ratbagd.src: W: spelling-error %description -l en_US
nonprivileged -> non privileged, non-privileged, underprivileged
ratbagd.src:23: W: unversioned-explicit-provides python3-ratbagd"
→ please hyphenate non-privileged

* ratbagd-python.noarch: E: wrong-script-interpreter /usr/bin/ratbagctl
/usr/bin/env python
→ that's an upstream bug, should be '/usr/bin/env python3', see
https://github.com/libratbag/ratbagd/pull/26

* the man page for ratbagctl should be in the -python subpackage

* From  https://fedoraproject.org/wiki/Packaging:Python:
"Must: If you build for a single python runtime you must add %python_provide
python-$module so that the current default python is provided from the
unversioned python package."
afaict all other conditions are met here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Benjamin Tissoires  changed:

   What|Removed |Added

  Flags|needinfo?(btissoir@redhat.c |
   |om) |



--- Comment #3 from Benjamin Tissoires  ---
Spec URL: https://people.freedesktop.org/~tissoire/ratbagd-rpm-v2/ratbagd.spec
SRPM URL:
https://people.freedesktop.org/~tissoire/ratbagd-rpm-v2/ratbagd-0.4-1.fc27.src.rpm

scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19884525

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Peter Hutterer  changed:

   What|Removed |Added

 CC||btiss...@redhat.com
  Flags||needinfo?(btissoir@redhat.c
   ||om)



--- Comment #2 from Peter Hutterer  ---
for the archives: there was a minor license issue found which is being fixed
upstream. Please submit an updated spec/srpm once we have a ratbagd with that
bit fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Peter Hutterer  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|peter.hutte...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Benjamin Tissoires  changed:

   What|Removed |Added

 CC||peter.hutte...@redhat.com



--- Comment #1 from Benjamin Tissoires  ---
scratch-build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19510807

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org