[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #30 from Fedora Update System  ---
keepassxc-2.1.4-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #29 from Mukundan Ragavan  ---
Having said that, I will fix this in git.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #28 from Mukundan Ragavan  ---
(In reply to Michael Schwendt from comment #27)
> > %posttrans
> > gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> > desktop-file-validate %{_datadir}/applications/keepassxc.desktop &> 
> > /dev/null || :
> 
> That desktop-file-validate call isn't acceptable like that. You are supposed
> to validate .desktop files once when building the binary package. Not in
> %posttrans and then ignoring output and any errors.

Well, the spec file uses desktop-file-install in %install.
Desktop-file-validate is not necessary here at all since -file-install is
already used.

If desktop-file-validate is the only one used, then, of course, it should be in
%install.

From the guidelines,

... one MUST run desktop-file-install (in %install) OR desktop-file-validate
(in %check or %install) ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #27 from Michael Schwendt  ---
> %posttrans
> gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> desktop-file-validate %{_datadir}/applications/keepassxc.desktop &> /dev/null 
> || :

That desktop-file-validate call isn't acceptable like that. You are supposed to
validate .desktop files once when building the binary package. Not in
%posttrans and then ignoring output and any errors.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-05-24 01:01:46



--- Comment #26 from Fedora Update System  ---
keepassxc-2.1.4-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #25 from Fedora Update System  ---
keepassxc-2.1.4-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-08aacd9ce3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #24 from Fedora Update System  ---
keepassxc-2.1.4-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-13541d4d31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #22 from Fedora Update System  ---
keepassxc-2.1.4-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-08aacd9ce3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #23 from Fedora Update System  ---
keepassxc-2.1.4-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-13541d4d31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #21 from Germano Massullo  ---
Thank you Mukundan, very good review, I will keep it as model for future review
requests

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #20 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/keepassxc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #19 from Mukundan Ragavan  ---
koji build (rawhide) -
https://koji.fedoraproject.org/koji/taskinfo?taskID=19612278


All good with the package. APPROVED.



I would like to co-maintain the package. My FAS is nonamedotc. Please add me as
a co-maintainer (if you do not mind) when you request on pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #18 from Mukundan Ragavan  ---
koji build (f26) - https://koji.fedoraproject.org/koji/taskinfo?taskID=19590473

(In reply to Germano Massullo from comment #16)
> https://germano.fedorapeople.org/package_reviews/keepassxc/keepassxc_v2.spec
> https://germano.fedorapeople.org/package_reviews/keepassxc/keepassxc-2.1.4-1.
> fc25.src.rpm
> 
> 1) Ok so I haven't touched anything (if I have understood correctly your
> explanation)
> 
> 2) I haven't changed anything
> 
> 3) I replaced
> %{_datadir}/mimelnk/application/*.desktop
> with
> %{_datadir}/mimelnk
> 
> Is that correct?

Yes. All good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #17 from Mukundan Ragavan  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

---> This is fine. I can install this on my VM.  

[root@f26-guest Downloads]$ rpmlint keepassxc
keepassxc.x86_64: W: spelling-error %description -l en_US urls -> curls, purls,
hurls
keepassxc.x86_64: W: spelling-error %description -l en_US attachemts ->
attachments, attache, schemata

---> This is not fixed in the spec file. Please fix the spelling before import.
Not a blocker.

keepassxc.x86_64: W: spelling-error %description -l en_US customizable ->
customization
keepassxc.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/keepassxc-dark.svgz
keepassxc.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/keepassxc-locked.svgz
keepassxc.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/apps/keepassxc.svgz
keepassxc.x86_64: W: gzipped-svg-icon
/usr/share/icons/hicolor/scalable/mimetypes/application-x-keepassxc.svgz
keepassxc.x86_64: W: no-manual-page-for-binary keepassxc
1 packages and 0 specfiles checked; 0 errors, 8 warnings.


[root@f26-guest Downloads]$ rpm -qa keepassxc
keepassxc-2.1.4-1.fc26.x86_64



- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: keepassxc_v2.spec should be keepassxc.spec
  See:
  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name

---> You are clearly only using the _v2 format for package review. Make sure
you have the correct filename for spec when you import into SCM.


= MUST items =

C/C++:
[x]: Provides: bundled(gnulib) in place as required.
 Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: There is no build directory. Running licensecheck on vanilla
 upstream sources. No licenses found. Please check the source files for
 licenses manually.

[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.

---> This is well done. From the spec file.

License:Boost and BSD and CC0 and GPLv3 and LGPLv2 and LGPLv2+ and
LGPLv3+ and Public Domain

[x]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/16x16/mimetypes,
 /usr/share/icons/hicolor/scalable/mimetypes,
 /usr/share/icons/hicolor/32x32/apps, /usr/share/mime,
 /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/24x24,
 /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128/mimetypes,
 /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/256x256/apps,
 /usr/share/icons/hicolor/64x64/mimetypes,
 /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/48x48/apps,
 /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
 /usr/share/mime/packages, /usr/share/icons/hicolor/128x128,
 /usr/share/icons/hicolor/22x22/mimetypes,
 /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/256x256,
 /usr/share/icons/hicolor/16x16/apps,
 /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22,
 /usr/share/icons/hicolor/48x48,
 /usr/share/icons/hicolor/32x32/mimetypes,
 /usr/share/icons/hicolor/scalable

---> These directories are all owned by either hicolor-icon-theme or
shared-mime-info. Both the packages are needed by pretty much any GUI.

[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/mimelnk/application(obconf, kde-filesystem, sim),
 /usr/share/mimelnk(obconf, kde-filesystem, sim)


---> Keepassxc owning this directory is correct. 

[x]: %build honors applicable compiler flags or justifies otherwise.


---> This version of the spec uses the correct cmake macro. Build flags are
good.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or 

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #16 from Germano Massullo  ---
https://germano.fedorapeople.org/package_reviews/keepassxc/keepassxc_v2.spec
https://germano.fedorapeople.org/package_reviews/keepassxc/keepassxc-2.1.4-1.fc25.src.rpm

1) Ok so I haven't touched anything (if I have understood correctly your
explanation)

2) I haven't changed anything

3) I replaced
%{_datadir}/mimelnk/application/*.desktop
with
%{_datadir}/mimelnk

Is that correct?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #15 from Mukundan Ragavan  ---
Several of these are all already owned.


1/ For example,

$ rpm -q --whatprovides /usr/share/icons/hicolor/16x16/mimetypes
hicolor-icon-theme-0.15-4.fc26.noarch
keepassx-2.0.3-3.fc26.x86_64

In this case, we are at this section of the packaging guidelines - 

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership

Specifically, here-  

https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package

We do not need hicolor-icon-theme, but hicolor-icon-theme is required by pretty
much every graphical environment.

So, it is proper for hicolor to own these directories.

2/ We need shared-mime-info for a graphical package to function

$ rpm -q --whatprovides /usr/share/mime/packages
shared-mime-info-1.8-2.fc26.x86_64

So, this is safe to ignore as well.

3/ /usr/share/mimelnk

This is not owned by any other package and so, keepassxc should own it.

$ dnf repoquery --whatprovides /usr/share/mimelnk/
determining the fastest mirror (6 hosts).. done.
Fedora 26 - x86_64 - Test Updates  
 
3.6 MB/s |  20 MB 00:05
determining the fastest mirror (6 hosts).. done.
Last metadata expiration check: 0:00:00 ago on Thu May 18 10:40:01 2017 EDT.


Does this clear up?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #14 from Germano Massullo  ---
https://germano.fedorapeople.org/package_reviews/keepassxc/keepassxc.spec
https://germano.fedorapeople.org/package_reviews/keepassxc/keepassxc-2.1.4-1.fc25.src.rpm


Concerning
==
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/16x16/mimetypes,
 /usr/share/icons/hicolor/scalable/mimetypes,
 /usr/share/icons/hicolor/32x32/apps, /usr/share/mime,
 /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/24x24,
 /usr/share/icons/hicolor/128x128/apps,
 /usr/share/icons/hicolor/128x128/mimetypes,
 /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/256x256/apps,
 /usr/share/icons/hicolor/64x64/mimetypes,
 /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/48x48/apps,
 /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor,
 /usr/share/mimelnk/application, /usr/share/mimelnk,
 /usr/share/mime/packages, /usr/share/icons/hicolor/128x128,
 /usr/share/icons/hicolor/22x22/mimetypes,
 /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/256x256,
 /usr/share/icons/hicolor/16x16/apps,
 /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22,
 /usr/share/icons/hicolor/48x48,
 /usr/share/icons/hicolor/32x32/mimetypes,
 /usr/share/icons/hicolor/scalable
==

I would like to ask on devel mailing list, since the fix did not work

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #13 from Mukundan Ragavan  ---
(In reply to Toni Spets from comment #11)
> (In reply to Mukundan Ragavan from comment #10)
> > 
> > Even if we build the package with the protocol on, it can be disabled in the
> > settings screen(see screenshot attached).
> > 
> 
> To be more precise, even when enabled at compile time it is *disabled* by
> default at runtime and you need to explicitly enable it for use.

Yes indeed. That's what I intended to say .. 


(In reply to Germano Massullo from comment #8)
> (In reply to Mukundan Ragavan from comment #5)
> > ---> Some of these bogus warnings. For example,
> > 
> > /usr/share/mime, /usr/share/mime/packages are owned by shared-mime-info
> > /usr/share/icons/hicolor - hicolor-icon-theme
> > 
> > others are provided by several other packages (kde-filesystem, for 
> > example)
> > 
> > /usr/lib64/keepassxc fix is above.
> 
> Could you rephrase such piece of the review? I think I have not got it
> 
My apologies. I meant to say nothing needs to be addressed here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #12 from Germano Massullo  ---
Ok I will re-enable it again on next spec file release

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #11 from Toni Spets  ---
(In reply to Mukundan Ragavan from comment #10)
> 
> Even if we build the package with the protocol on, it can be disabled in the
> settings screen(see screenshot attached).
> 

To be more precise, even when enabled at compile time it is *disabled* by
default at runtime and you need to explicitly enable it for use.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #10 from Mukundan Ragavan  ---
Created attachment 1279646
  --> https://bugzilla.redhat.com/attachment.cgi?id=1279646=edit
keepass http screen

Germano, I wonder if it would be alright to leave keepassHTTP on in the builds
and let the users decide if they want to use it. Even if we build the package
with the protocol on, it can be disabled in the settings screen(see screenshot
attached).

Also, From here - https://github.com/keepassxreboot/keepassxc

KeePassXC therefore strictly limits communication between itself and the
browser plugin to your local computer.



What do you think?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #9 from Toni Spets  ---
(In reply to Germano Massullo from comment #8)
> What kind of feature is favicon download?

When you create an entry with URL set up, you can use the favicon download
feature in the icon selection dialog to automatically download the icon that
would be shown in the browser tab.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #8 from Germano Massullo  ---
(In reply to Mukundan Ragavan from comment #5)
> ---> Some of these bogus warnings. For example,
> 
>   /usr/share/mime, /usr/share/mime/packages are owned by shared-mime-info
>   /usr/share/icons/hicolor - hicolor-icon-theme
>   
>   others are provided by several other packages (kde-filesystem, for 
> example)
>   
>   /usr/lib64/keepassxc fix is above.

Could you rephrase such piece of the review? I think I have not got it

(In reply to Toni Spets from comment #7)
> Disabling WITH_XC_HTTP also unintentionally disables favicon downloading
> which is  very useful feature of KeePassXC.

What kind of feature is favicon download?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Toni Spets  changed:

   What|Removed |Added

 CC||toni.sp...@iki.fi



--- Comment #7 from Toni Spets  ---
(In reply to Germano Massullo from comment #4)
> (In reply to Germano Massullo from comment #3)
> > We should also think about disabling KeePassHTTP feature. More infos at
> > https://keepassxc.org/project
> 
> Done by setting -DWITH_XC_HTTP=OFF
> srpm and spec files of Comment 1 have been updated

As discussed on #keepassrc channel (I'm hifi), I think this disables "expected"
functionality of KeePassXC and would cripple the package even when it's not
enabled by default in CMakeLists. The official AppImage and other unofficial
packages all default to having this setting on.

Disabling WITH_XC_HTTP also unintentionally disables favicon downloading which
is  very useful feature of KeePassXC.

Worth noting is that I'm not an official representative of the project but
someone who was involved with the unofficial Copr package by bugzy and a
regular user of that package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #6 from Mukundan Ragavan  ---
Created attachment 1279519
  --> https://bugzilla.redhat.com/attachment.cgi?id=1279519=edit
COPYING file for discussion

COPYING file indicates all the license breakdown.

I think upstream has done a commendable job in keeping track of all these
files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #5 from Mukundan Ragavan  ---
Created attachment 1279518
  --> https://bugzilla.redhat.com/attachment.cgi?id=1279518=edit
specfile patch



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

---> This is alright. This is not in the ld path

[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.

[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "*No copyright* CC0 (v1.0)", "GPL (v2)", "Unknown or
 generated", "BSD (3 clause) GPL", "MIT/X11 (BSD like)", "BSL (v1.0)",
 "*No copyright* BSD (3 clause)", "*No copyright* BSL", "BSD (3
 clause)", "GPL (v2.1) LGPL (v2.1)", "GPL (v3)", "LGPL (v2.1 or v3)",
 "*No copyright* GPL (v2)". 316 files have unknown license. Detailed
 output of licensecheck in

/home/mukundan/nextcloud/misc_pkgs/pkg_reviews/1450633-keepassxc/licensecheck.txt

---> Well, I don't think this should be GPLv2 only. If you look at the COPYING
file in the tarball, there is a big mix of several licenses.

Icon files have the following licenses - LGPL-2, LGPL-2.1, LGPL-3+, CCO, public
domain.

In addition, there is some code that has licenses Boost-1.0 and BSD 3-clause.


All of this has to go into the license field. Please cross-check using the
COPYING file (also attached).


[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/keepassxc

---> This is easily fixed. In %files,

%{_libdir}/%{name} instead of %{_libdir}/keepassxc/*.so

[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/mimelnk/application, /usr/share/mimelnk,
 /usr/share/mime/packages, /usr/share/mime, /usr/lib64/keepassxc,
 /usr/share/icons/hicolor

---> Some of these bogus warnings. For example,

/usr/share/mime, /usr/share/mime/packages are owned by shared-mime-info
/usr/share/icons/hicolor - hicolor-icon-theme

others are provided by several other packages (kde-filesystem, for example)

/usr/lib64/keepassxc fix is above.

[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/icons/hicolor/16x16/mimetypes(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/scalable/mimetypes(hicolor-icon-
 theme), /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme,
 fedora-logos, keepassx), /usr/share/icons/hicolor/24x24/apps(hicolor-
 icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/24x24
 (hicolor-icon-theme, fedora-logos, keepassx),
 /usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme, keepassx),
 /usr/share/icons/hicolor/128x128/mimetypes(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/64x64(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme,
 fedora-logos, keepassx), /usr/share/icons/hicolor/64x64/mimetypes
 (hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/16x16
 (hicolor-icon-theme, fedora-logos, keepassx),
 /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos,
 keepassx), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme,
 fedora-logos, keepassx), /usr/share/icons/hicolor/128x128(hicolor-
 icon-theme, keepassx), /usr/share/icons/hicolor/22x22/mimetypes
 (hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/32x32
 (hicolor-icon-theme, fedora-logos, keepassx),
 /usr/share/icons/hicolor/256x256(hicolor-icon-theme, fedora-logos,
 keepassx), /usr/share/icons/hicolor/16x16/apps(hicolor-icon-theme,
 fedora-logos, keepassx), /usr/share/icons/hicolor/64x64/apps(hicolor-
 icon-theme, keepassx), /usr/share/icons/hicolor/22x22(hicolor-icon-
 theme, fedora-logos, keepassx), /usr/share/icons/hicolor/48x48
 (hicolor-icon-theme, fedora-logos, keepassx),
 /usr/share/icons/hicolor/32x32/mimetypes(hicolor-icon-theme,
 keepassx), 

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #4 from Germano Massullo  ---
(In reply to Germano Massullo from comment #3)
> We should also think about disabling KeePassHTTP feature. More infos at
> https://keepassxc.org/project

Done by setting -DWITH_XC_HTTP=OFF
srpm and spec files of Comment 1 have been updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633



--- Comment #3 from Germano Massullo  ---
We should also think about disabling KeePassHTTP feature. More infos at
https://keepassxc.org/project

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Germano Massullo  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Mukundan Ragavan  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||nonamed...@gmail.com
   Assignee|nob...@fedoraproject.org|nonamed...@gmail.com



--- Comment #2 from Mukundan Ragavan  ---
I am taking this package for review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450633] Review request: keepassxc - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450633

Germano Massullo  changed:

   What|Removed |Added

Summary|keepassxc - Cross-platform  |Review request: keepassxc -
   |password manager|Cross-platform password
   ||manager



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org