[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-06-09 15:07:09



--- Comment #17 from Fedora Update System  ---
laby-0.6.4-4.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
laby-0.6.4-4.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-674816c1d1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #15 from Fedora Update System  ---
laby-0.6.4-4.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-674816c1d1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #14 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/laby

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #13 from Sandro Bonazzola  ---
(In reply to Richard W.M. Jones from comment #12)
> Thanks - the new spec file addresses all the problems, except
> for the wav files which is tracked upstream.
> 
> Therefore this package is APPROVED.
> 
> You will need to follow on with the package review process,
> starting by making an SCM admin request.
> https://fedoraproject.org/wiki/Package_Review_Process

Thanks for the review and the help with the package.
SCM admin request opened.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Richard W.M. Jones  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #12 from Richard W.M. Jones  ---
Thanks - the new spec file addresses all the problems, except
for the wav files which is tracked upstream.

Therefore this package is APPROVED.

You will need to follow on with the package review process,
starting by making an SCM admin request.
https://fedoraproject.org/wiki/Package_Review_Process

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #11 from Sandro Bonazzola  ---
(In reply to Richard W.M. Jones from comment #10)
> [x]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "GPL", "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or
>  generated". 97 files have unknown license. Detailed output of
>  licensecheck in /home/rjones/1450679-laby/licensecheck.txt
> 
> I checked the licenses and is does appear that the author intends
> GPLv3+.
> 
> I guess you could ask upstream to use proper per-file GPL headers
> instead of ones they appear to have made up, but it's not urgent.

Reported upstream: https://github.com/sgimenez/laby/issues/46

> [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>  beginning of %install.
>  Note: rm -rf %{buildroot} present but not required
> 
> Please remove rm -rf %{buildroot} at the beginning of the %install section.

Done

> [!]: Requires correct, justified where necessary.
> 
> The Requires lines should be removed.  The final binary will
> contain statically-linked copies of ocaml-lablgtk and gtksourceview2.
> It dynamically links to the C libs gtk etc.  There is no need to pull in
> those packages at runtime at all.

Done


> Generic:
> [!]: Uses parallel make %{?_smp_mflags} macro.
> 
> Did you try enabling this?  If it works it should be used.  If the
> build system is broken for parallel builds (not uncommon, unfortunately)
> it may be worth adding a comment in the spec file.

Added, seems to work fine.

> [!]: Final provides and requires are sane (see attachments).
> 
> See above about Requires.  The other (generated) requires / provides
> of the package are correct.

Done

> [?]: Fully versioned dependency in subpackages if applicable.
>  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in laby-
>  debuginfo
> 
> I don't know what fedora-review means by this, but as far as I know
> this is not necessary.

Agreed

> [?]: Package functions as described.

Verified working


> [?]: Package should compile and build into binary rpms on all supported
>  architectures.
> 
> We will find out when you build this in Rawhide.

ok

> The following seem to be real problems.  The files in the RPMs
> are really zero length, which seems like it is wrong:
> 
> laby.x86_64: E: zero-length /usr/share/laby/sound/carry-exit.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/drop-no-space.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/drop-nothing.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/exit-in.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/no-exit.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/rock-in.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/rock-take.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/start.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/take-no-space.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/take-nothing.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/wall-in.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/web-in.wav
> laby.x86_64: E: zero-length /usr/share/laby/sound/web-out.wav

They are zero-length in the upstream source tree. I opened
https://github.com/sgimenez/laby/issues/47 to track it. Looking at the code
looks like they are installed to avoid file not found errors while playing
sounds in src/sounds.ml.

I think best solution for this is getting upstream to add real sound files or
add error handling, instead of just adding placeholders for avoiding file not
found errors. In the meanwhile, in order to keep the game working, they're
needed even if empty.

Spec URL:
https://raw.githubusercontent.com/sandrobonazzola/laby/17eb8daef0d416b8122f22f4e69de03ba709d36f/packaging/laby.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/Laby/fedora-rawhide-x86_64/00554778-laby/laby-0.6.4-4.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #10 from Richard W.M. Jones  ---
A few problems still.  See my comments inline below.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: laby : /usr/share/laby/mods/c/lib/robot.h laby :
  /usr/share/laby/mods/cpp/lib/robot.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

This is explained in the spec file and is not a problem.

- Package contains BR: python2-devel or python3-devel

I think this is bogus and can be ignored.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 97 files have unknown license. Detailed output of
 licensecheck in /home/rjones/1450679-laby/licensecheck.txt

I checked the licenses and is does appear that the author intends
GPLv3+.

I guess you could ask upstream to use proper per-file GPL headers
instead of ones they appear to have made up, but it's not urgent.

There does not appear to be any problematic content.

[x]: License file installed when any subpackage combination is installed.

Yes, in /usr/share/licenses/laby/gpl-3.0.txt

[x]: Package does not own files or directories owned by other packages.
[-]: %build honors applicable compiler flags or justifies otherwise.

OCaml package, so not applicable.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required

Please remove rm -rf %{buildroot} at the beginning of the %install section.

[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package

See comment in source about the header file.

[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.

The Requires lines should be removed.  The final binary will
contain statically-linked copies of ocaml-lablgtk and gtksourceview2.
It dynamically links to the C libs gtk etc.  There is no need to pull in
those packages at runtime at all.

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in laby
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: 

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #9 from Richard W.M. Jones  ---
(In reply to Sandro Bonazzola from comment #8)
> Updated addressing your comments to my best. I may need help about the debug
> symbols, looks like the generated debug rpm is missing sources.

It has actually included the sources in the debuginfo file,
and also ‘-g’ is being passed to each invocation of ‘ocamlopt’,
so everything seems fine to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #8 from Sandro Bonazzola  ---
Updated addressing your comments to my best. I may need help about the debug
symbols, looks like the generated debug rpm is missing sources.
Spec URL:
https://raw.githubusercontent.com/sandrobonazzola/laby/33014dae825b35f10e65752821ef42a3518f27f8/packaging/laby.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/Laby/fedora-rawhide-x86_64/00554044-laby/laby-0.6.4-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Sandro Bonazzola  changed:

   What|Removed |Added

  Flags||needinfo?(rjo...@redhat.com
   ||)



--- Comment #6 from Sandro Bonazzola  ---
Thanks for the review, I'll try to address all your comments.

(In reply to Richard W.M. Jones from comment #4)
> Fedora-review finds the following issues:
> 
> - Header files in -devel subpackage, if present.
>   Note: laby : /usr/share/laby/mods/c/lib/robot.h laby :
>   /usr/share/laby/mods/cpp/lib/robot.h
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

This one is intentional. The game teach you also how to program in C and in
order to move the ant, you'll need the robot.h header file. It isn't the use
case addressed by -devel subpackages. Should I add a comment in the spec file
about this?

> - Package contains BR: python2-devel or python3-devel

What's BR?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #5 from Richard W.M. Jones  ---
The build system is pretty crazy.  I couldn't work out if it was
installing the bytecode or native code version of the binary.  I
*think* it's the native code version, which would be correct.
You might consider using ‘make native’ so it only builds the
native code version, since building the bytecode version is a
waste of time on all architectures that recent Fedora supports.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #4 from Richard W.M. Jones  ---
Fedora-review finds the following issues:

- Header files in -devel subpackage, if present.
  Note: laby : /usr/share/laby/mods/c/lib/robot.h laby :
  /usr/share/laby/mods/cpp/lib/robot.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Package contains BR: python2-devel or python3-devel
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in laby
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #3 from Richard W.M. Jones  ---
You shouldn't use any of the following:

%global opt %(test -x %{_bindir}/ocamlopt && echo 1 || echo 0)

- This has been replaced by either %ocaml_native_compiler or
  %ocaml_natdynlink.  Please see /usr/lib/rpm/macros.d/macros.ocaml-srpm

%global debug_package %{nil}

- Debuginfo should work these days.  You may need to modify the build
  so it passes -g option to ocamlopt.

%global _use_internal_dependency_generator 0
%global __find_requires /usr/lib/rpm/ocaml-find-requires.sh
%global __find_provides /usr/lib/rpm/ocaml-find-provides.sh

- This is plain wrong nowadays.  The RPM dependency generator
  just does the right thing.

And yes I'm aware that the OCaml packaging guidelines aren't up to date
on some of these issues.  Also that OCaml packages don't consistently
do this -- I've been fixing those over time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #2 from Richard W.M. Jones  ---
FWIW I'm testing this with OCaml 4.04.1 in Rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679

Richard W.M. Jones  changed:

   What|Removed |Added

 CC||rjo...@redhat.com
   Assignee|nob...@fedoraproject.org|rjo...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1450679] Review Request: laby - learn programming, playing with ants and spider webs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1450679



--- Comment #1 from Sandro Bonazzola  ---
Updated spec file for Fedora >= 26 support
https://github.com/sgimenez/laby/pull/44/files

Spec URL:
https://raw.githubusercontent.com/sandrobonazzola/laby/57d06a9fd6ebb0bbb947627f0123bfa95b8a93ab/packaging/laby.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/sbonazzo/Laby/fedora-rawhide-x86_64/00552574-laby/laby-0.6.4-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org