[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066
Bug 1451066 depends on bug 1372892, which changed state.

Bug 1372892 Summary: Review Request: python-backports-csv - Backport of Python 
3's csv module for Python 2
https://bugzilla.redhat.com/show_bug.cgi?id=1372892

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #21 from Fedora Update System  ---
python-cli-helpers-0.2.3-1.fc25 has been pushed to the Fedora 25 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-31 18:51:32



--- Comment #20 from Fedora Update System  ---
python-cli-helpers-0.2.3-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #19 from Fedora Update System  ---
python-cli-helpers-0.2.3-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f872b854bf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
python-cli-helpers-0.2.3-1.fc25 has been pushed to the Fedora 25 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-1fb2e16907

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #17 from Fedora Update System  ---
python-cli-helpers-0.2.3-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f872b854bf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #16 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-cli-helpers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

mpr...@redhat.com  changed:

   What|Removed |Added

 CC||mpr...@redhat.com



--- Comment #15 from mpr...@redhat.com  ---
Please disregard my comment above. This was a test in staging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #14 from mpr...@redhat.com  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.stg.fedoraproject.org/rpms/python-cli-helpers. You may create the
branch "f26" using git in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Julien Enselme  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #13 from Julien Enselme  ---
Looks good to me. Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #12 from Terje Røsten  ---
Thanks!

Update package:

changelog: 
- 0.2.3
- Rename
- Use summary and desc macros
- Drop Python 2 sub package for now, backports.csv not available
- Add patch to remove Python 2 specific reqs into Python 3 package

spec:
https://terjeros.fedorapeople.org/python-cli-helpers/python-cli-helpers.spec
srpm:
https://terjeros.fedorapeople.org/python-cli-helpers/python-cli-helpers-0.2.3-1.fc26.src.rpm
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=21266292

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Terje Røsten  changed:

   What|Removed |Added

 Depends On||1372892
   ||(python-backports-csv)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1372892
[Bug 1372892] Review Request: python-backports-csv - Backport of Python 3's
csv module for Python 2
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Terje Røsten  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-cli_helpers - Python |python-cli-helpers - Python
   |helpers for common CLI  |helpers for common CLI
   |tasks   |tasks



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Fabio Valentini  changed:

   What|Removed |Added

 CC||decatho...@gmail.com



--- Comment #6 from Fabio Valentini  ---
Side note from a reader of the package-reviews mailing list:

If in doubt, use the name that matches the upstream name as closely as possible
(in this case, with an underscore).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #5 from Dick Marinus  ---
Hmm not that I really mind but when I run: dnf list 'python*_*' I get 102
python packages with an underscore. As far as I know a Python RPM is named
like:

python3-cli-helpers-1.8.1-4.fc25.noarch.rpm

python---..rpm

Now I think an underscore might be a better separator because rpm filenames are
split by a minus (-) and dot (.).

If I remember correctly subpackages are also separated by a minus sign as
default. So an user might expect python3-cli-helpers is a subpackage of
python3-cli (which doesn't exist).

But, again, I don't really mind, if you think python3-cli-helpers is better, no
problem.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #4 from Terje Røsten  ---
aesthetics? Rpms use separator between words and fields, in rpm context using -
over _ make sense to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Dick Marinus  changed:

   What|Removed |Added

 CC||d...@mrns.nl



--- Comment #3 from Dick Marinus  ---
Thank you Terje! Why did you rename the package from "python-cli_helpers" to
"python-cli-helpers" ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066



--- Comment #2 from nicolas.vievi...@univ-valenciennes.fr ---
Hello,

I've to complete the informal review I've made above with these Items I made
"Not applicable" instead of "Pass".

= SHOULD items =

Generic:
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.

Sorry for the mistake. 

Cordially,


-- 
NVieville

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

nicolas.vievi...@univ-valenciennes.fr changed:

   What|Removed |Added

 CC||nicolas.vieville@univ-valen
   ||ciennes.fr



--- Comment #1 from nicolas.vievi...@univ-valenciennes.fr ---
Hello,

As a new coming packager, I'll do an informal review of your package review
request. Please feel free to make any comment about this.

Summary of review potential problems.

MUST 
   - License field in the package spec file matches the actual license. 
 40 files have unknown license.
 Global BSD licence is OK, so I think that 40 files are OK (not necessary 
 to add licence field in each one)?

SHOULD
   - Patches link to upstream bugs/comments/lists or are otherwise
 justified. 
 Maybe it should be necessary to explain the goal of this patch in a 
 comment in the spec file. It should also be necessary to name it with 
 an explicit name and probably beginning with the package name
 (python-cli-helpers-001_don_t_install_tests.tabular_output.patch for
 example).


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (dependencies not found: python-terminaltables)
  - not blocking as request review for it is present #1451054


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 40 files have unknown
 license. 
[-]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.6/site-
 packages, /usr/lib/python3.6
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which 

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Terje Røsten  changed:

   What|Removed |Added

 Blocks||1450637




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1450637
[Bug 1450637] new  mycli needs  python-cli-helpers
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1451066] Review Request: python-cli-helpers - Python helpers for common CLI tasks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1451066

Terje Røsten  changed:

   What|Removed |Added

 Depends On||1451054




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1451054
[Bug 1451054] Review Request: python-terminaltables - Generate tables in
terminals from list of strings
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org