[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725

Rex Dieter  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
Last Closed||2017-10-17 10:14:24



--- Comment #7 from Rex Dieter  ---
imported long ago

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725



--- Comment #6 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/xdg-desktop-portal-kde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725

Jan Grulich  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jan Grulich  ---
Just minor things that can be done during import. The initial release version
should be 1 and not 0. Also you can remove %post section in this case. Other
than that it looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725



--- Comment #4 from Martin Kyral  ---
Thanks for the feedback. I incorporated the proposed changes in the spec file,
available in copr dist-git.

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/mkyral/plasma-unstable/xdg-desktop-portal-kde.git/tree/xdg-desktop-portal-kde.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/mkyral/plasma-unstable/fedora-25-x86_64/00567865-xdg-desktop-portal-kde/xdg-desktop-portal-kde-5.10.2-0.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725



--- Comment #3 from Jan Grulich  ---
1) Why don't you use %find_lang? Also listing all localization as you did in
%files is not how usually this is done. 

2) I think this can be removed
# filter plugin provides
%global __provides_exclude_from ^(%{_kf5_plugindir}/.*\\.so)$


Other than that it looks fine, fix please mentioned issues.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725

Jan Grulich  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
  Flags||fedora-review?



--- Comment #2 from Jan Grulich  ---
Spec URL: https://jgrulich.fedorapeople.org/xdg-desktop-portal-kde.spec
SRPM URL:
https://jgrulich.fedorapeople.org/xdg-desktop-portal-kde-5.10.0-0.fc27.src.rpm

Uploaded to be able to use fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725



--- Comment #1 from Martin Kyral  ---
Created attachment 1285795
  --> https://bugzilla.redhat.com/attachment.cgi?id=1285795=edit
spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1457725] Review Request: xdg-desktop-portal-kde - Qt/ KF5 backend for xdg-desktop-portal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1457725

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com
 Blocks||656997 (kde-reviews)
  Alias||xdg-desktop-portal-kde




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org