[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-06-14 23:01:55



--- Comment #7 from Fedora Update System  ---
python3-poppler-qt5-0.24.2-2.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #6 from Miro Hrončok  ---
Little late here, but could you please add the python_provide macro?

https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
python3-poppler-qt5-0.24.2-2.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cea8c5ab4b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914



--- Comment #4 from Fedora Update System  ---
python3-poppler-qt5-0.24.2-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-cea8c5ab4b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-poppler-qt5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914

Gwyn Ciesla  changed:

   What|Removed |Added

Summary|Review Request -|Review Request:
   |python3-poppler-qt5 |python3-poppler-qt5



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request - python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914

Gwyn Ciesla  changed:

   What|Removed |Added

Summary|Review Request: |Review Request -
   |python3-poppler-qt5 |python3-poppler-qt5



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914



--- Comment #2 from Gwyn Ciesla  ---
Thank you!

BEERS_I_OWE_YOU++

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1459914] Review Request: python3-poppler-qt5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1459914

Tom "spot" Callaway  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tcall...@redhat.com
   Assignee|nob...@fedoraproject.org|tcall...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Tom "spot" Callaway  ---
You're missing some rather important BuildRequires, for /usr/bin/sip and
poppler-qt5. You can fix that by adding these lines:

BuildRequires: pkgconfig(poppler-qt5)
BuildRequires: sip-devel

A koji scratch build would have caught that immediately. Next time, consider
test building your SRPM there first (e.g. koji build --scratch f26-build
nameof.src.rpm).

With those two lines added, I finished the review. Please be sure that you add
those lines before you commit. :)

== REVIEW ==

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets general and python packaging guidelines
- license (LGPLv2+) OK, matches source (though, you really should ask upstream
to include a copy of the LGPLv2 COPYING text, it is missing from their source
tree)
- spec file legible, in am. english
- source matches upstream
- package compiles on f26 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org