[Bug 1460174] Review Request: libopusenc - A library that provides an easy way to encode Ogg Opus files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460174

Peter Robinson  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2017-06-09 17:33:45



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460174] Review Request: libopusenc - A library that provides an easy way to encode Ogg Opus files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460174



--- Comment #3 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libopusenc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460174] Review Request: libopusenc - A library that provides an easy way to encode Ogg Opus files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460174



--- Comment #2 from Peter Robinson  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> URL is messed up. Also, no https?
> 
> Suggestion: make %{?_smp_mflags} V=1 → %make_build
> Suggestion: make install DESTDIR=%{buildroot} → %make_install

All fixed locally, will be fixed on initial checkin. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1460174] Review Request: libopusenc - A library that provides an easy way to encode Ogg Opus files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1460174

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
URL is messed up. Also, no https?

Suggestion: make %{?_smp_mflags} V=1 → %make_build
Suggestion: make install DESTDIR=%{buildroot} → %make_install

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ builds and install OK
+ fedora-review finds no issues
+ scriptlets are correct
+ R/BR/P look correct
+ %check is present and passes

Package is APPROVED. Please note the comments at the top.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org