[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #18 from Fedora Update System  ---
tworld-1.3.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #17 from Fedora Update System  ---
tworld-1.3.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #16 from Fedora Update System  ---
tworld-1.3.2-3.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #15 from Fedora Update System  ---
tworld-1.3.2-3.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-05 22:22:36



--- Comment #14 from Fedora Update System  ---
tworld-1.3.2-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
tworld-1.3.2-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-79cd34e5e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #12 from Iwicki Artur  ---
The build initially failed for EPEL6 due to libappstream-glib not being
available. Since that is used only for validating the appdata.xml file, I
edited the EPEL6 spec file to omit that step.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #11 from Fedora Update System  ---
tworld-1.3.2-3.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-79cd34e5e0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #10 from Fedora Update System  ---
tworld-1.3.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5cc41b463f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #9 from Fedora Update System  ---
tworld-1.3.2-3.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b66f4ca0b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #8 from Fedora Update System  ---
tworld-1.3.2-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4056ef5f5b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
tworld-1.3.2-3.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-10cc766f66

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #6 from Fedora Update System  ---
tworld-1.3.2-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b66f4ca0b3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #5 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/tworld

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #4 from Tom "spot" Callaway  ---
Yeah. Not ideal, but permitted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412



--- Comment #3 from Iwicki Artur  ---
We wanted to make sure the "redistribution only, no modification" licence for
the  level packs was okay - it seems to match Packaging:Licensing:Shareware,
but we wanted to double-check with Legal.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Shareware

I'll go ahead and file a package request, then.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks|182235 (FE-Legal)   |



--- Comment #2 from Tom "spot" Callaway  ---
Not sure why this was blocking FE-Legal. Lifting.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
rpmlint:

tworld-data.noarch: E: incorrect-fsf-address
/usr/share/licenses/tworld-data/COPYING
Who cares? ;)

tworld.x86_64: W: manual-page-warning /usr/share/man/man6/tworld.6.gz 2:
warning: macro `LO' not defined
The page seems to display OK, so this can be ignored.

4 packages and 0 specfiles checked; 2 errors, 8 warnings.

make %{?_smp_mflags} → %make_build, optionally.

$ appstream-util validate  /usr/share/appdata/tworld.appdata.xml
/usr/share/appdata/tworld.appdata.xml: FAILED:
• tag-invalid   :  is not valid [CC-BY-SA-3.04.0]
• tag-invalid   :  is not valid [GPLv2+]SPDX ID
'GPLv2+' unknown
• tag-missing   :  not specified
• tag-missing   :  is not present
• attribute-invalid :  width too small
[http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg]
• attribute-invalid :  height too small
[http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg]

metadata_license should be " CC-BY-SA-3.0", project_license "GPL-2.0+",
according to https://spdx.org/licenses/. Displays OK in gnome-software apart
from the license.

The game data satisfies the requirements for "firmware"
[https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#Binary_Firmware],
and can be packaged. The license text is in CCLP?.html.

+ license is acceptable for Fedora (GPLv2+, "no mods" for the game data)
+ license is specified correctly
+ package name is OK
+ builds, install, runs OK
+ scriptlets are correct according to guidelines
+ P/R/BR look correct

Just some nitpicks. Your packaging foo is very strong ;)
Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462412] Review Request: tworld - a puzzle game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462412

Iwicki Artur  changed:

   What|Removed |Added

 Blocks||1364745 (FE-GAMESIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] Games SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org