[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-07-07 18:57:42 |2017-08-31 11:19:08



--- Comment #18 from Fedora Update System  ---
libaec-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #17 from Fedora Update System  ---
libaec-1.0.1-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fb600d5f60

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #16 from Fedora Update System  ---
libaec-1.0.1-4.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fb600d5f60

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #15 from Christoph Junghans  ---
(In reply to Christoph Junghans from comment #14)
> > Patch was send to hdf5-ow...@fedoraproject.org.
> https://src.fedoraproject.org/rpms/hdf5/pull-request/1
And merged.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #14 from Christoph Junghans  ---
(In reply to Christoph Junghans from comment #12)
> Created attachment 1292418 [details]
> hdf5: enable szip support through libaec
> 
> With this patch we can now enable szip support in hdf5:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=20122306
> 
> Patch was send to hdf5-ow...@fedoraproject.org.
https://src.fedoraproject.org/rpms/hdf5/pull-request/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-07-07 18:57:42



--- Comment #13 from Fedora Update System  ---
libaec-1.0.0-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #12 from Christoph Junghans  ---
Created attachment 1292418
  --> https://bugzilla.redhat.com/attachment.cgi?id=1292418=edit
hdf5: enable szip support through libaec

With this patch we can now enable szip support in hdf5:
https://koji.fedoraproject.org/koji/taskinfo?taskID=20122306

Patch was send to hdf5-ow...@fedoraproject.org.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #11 from Christoph Junghans  ---
I updated the wiki on szip slightly:
https://fedoraproject.org/w/index.php?title=Forbidden_items=495449=492921

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
libaec-1.0.0-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-56ec5fb7e4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #9 from Fedora Update System  ---
libaec-1.0.0-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-56ec5fb7e4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #8 from Gwyn Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/libaec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags||fedora-review+



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
  (there are some GPL and MIT/X11 files, but those are build scripts)
+ package name is OK
+ builds and install fine
+ R/P/BR look correct
+ scriptlets are sane
+ %check is present and passes

So the only non-trivial thing is the patent situation.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Patented_Software
says that a written license grant is necessary.
https://gitlab.dkrz.de/k202009/libaec/blob/master/doc/patent.txt#L44 is such a
license grant, so it seems OK to include this in Fedora.

> NASA cannot warrant [...] that your use will not infringe on another's 
> intellectual property rights.

Right. But that's always true, for any software, and seems to be a standard
disclaimer that doesn't mean anything except that NASA allows use of the
algorithm, without making any promises on behalf of other parties.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #6 from Christoph Junghans  ---
(In reply to Christoph Junghans from comment #5)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> > The description mentions a static library, but there's no static library in
> > -devel (nor should there be). Please fix the description.
> Fixed!
> 
> Spec URL: http://junghans.github.io/fedora-review/libaec/libaec.spec
> SRPM URL:
> http://junghans.github.io/fedora-review/libaec/libaec-1.0.0-2.fc25.src.rpm
> Review.txt: http://junghans.github.io/fedora-review/libaec/review.txt
> Build log: https://travis-ci.org/junghans/fedora-review/builds/245548276
> Raw Build log:
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/245548277/log.txt
The build log also has an output of licensecheck.txt:
https://travis-ci.org/junghans/fedora-review/builds/245548276#L2720

> 
> > 
> > Looks good, but I need at the licensing more carefully, hence no final
> > review yet.
> The interesting part about algorithm patent is here:
> 
> "any use of the subject matter is at your own risk and NASA cannot warrant
> that its use will satisfy your particular needs or that your use will not
> infringe on another's intellectual property rights."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #5 from Christoph Junghans  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> The description mentions a static library, but there's no static library in
> -devel (nor should there be). Please fix the description.
Fixed!

Spec URL: http://junghans.github.io/fedora-review/libaec/libaec.spec
SRPM URL:
http://junghans.github.io/fedora-review/libaec/libaec-1.0.0-2.fc25.src.rpm
Review.txt: http://junghans.github.io/fedora-review/libaec/review.txt
Build log: https://travis-ci.org/junghans/fedora-review/builds/245548276
Raw Build log:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/245548277/log.txt

> 
> Looks good, but I need at the licensing more carefully, hence no final
> review yet.
The interesting part about algorithm patent is here:

"any use of the subject matter is at your own risk and NASA cannot warrant that
its use will satisfy your particular needs or that your use will not infringe
on another's intellectual property rights."

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library and BSD drop-in replacement for szlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
The description mentions a static library, but there's no static library in
-devel (nor should there be). Please fix the description.

Looks good, but I need at the licensing more carefully, hence no final review
yet.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

Summary|Review Request: libaec -|Review Request: libaec -
   |Adaptive Entropy Coding |Adaptive Entropy Coding
   |library and BSD drop-in |library
   |replacement for szlib   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library and BSD drop-in replacement for szlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #3 from Christoph Junghans  ---
(In reply to Igor Gnatenko from comment #2)
> Hmm, why am I on this review request?

Mainly because you are the hdf5 maintainer and I wanted to make you aware as
SZIP is an hdf thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library and BSD drop-in replacement for szlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #2 from Igor Gnatenko  ---
Hmm, why am I on this review request?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library and BSD drop-in replacement for szlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443



--- Comment #1 from Christoph Junghans  ---
TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=20057748

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462443] Review Request: libaec - Adaptive Entropy Coding library and BSD drop-in replacement for szlib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462443

Christoph Junghans  changed:

   What|Removed |Added

URL||https://fedoraproject.org/w
   ||iki/ForbiddenItems#szip



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org