[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Raphael Groner  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-07-22 06:17:03



--- Comment #18 from Raphael Groner  ---
Builds available in F28 and rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/XRZDSRFD2RBBTRC2RI7USEWIHDWATRG3/

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #17 from Raphael Groner  ---
Lost due to negative karma.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/F3WJWL2ZQSJ5PQLPNFDMFFVTYTGYYUFX/

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #16 from Fedora Update System  ---
speedometer-2.8-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6750a53e97

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #15 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/speedometer

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #14 from Raphael Groner  ---
https://pagure.io/releng/fedora-scm-requests/issue/2363
https://pagure.io/releng/fedora-scm-requests/issue/2364

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Jaroslav Škarvada  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #13 from Jaroslav Škarvada  ---
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #12 from Raphael Groner  ---
Spec URL: https://raphgro.fedorapeople.org/review/util/speedometer.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/util/speedometer-2.8-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #11 from Jaroslav Škarvada  ---
(In reply to Raphael Groner from comment #9)
> Spec URL: http://raphgro.fedorapeople.org//speedometer.spec
> SRPM URL: http://raphgro.fedorapeople.org//speedometer-2.8-2.fc26.src.rpm
> 
> %changelog
> * Tue Sep 19 2017 Raphael Groner <> - 2.8-2
> - move binary into versionized subpackage
> - add dependency python-urwid
> - prepare build conditional for epel7
> - prepare subpackage for python3, upstream is not ready yet
> 
> Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=2197567

Sorry for the delay. I didn't receive notification from bugzilla and I was on
holidays :)

Could you please re-upload the srpm and spec? I am getting 404 error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #10 from Raphael Groner  ---
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=21975674

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #9 from Raphael Groner  ---
Spec URL: http://raphgro.fedorapeople.org//speedometer.spec
SRPM URL: http://raphgro.fedorapeople.org//speedometer-2.8-2.fc26.src.rpm

%changelog
* Tue Sep 19 2017 Raphael Groner <> - 2.8-2
- move binary into versionized subpackage
- add dependency python-urwid
- prepare build conditional for epel7
- prepare subpackage for python3, upstream is not ready yet

Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=2197567

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #8 from Raphael Groner  ---
(In reply to Jaroslav Škarvada from comment #7)
> (In reply to Petr Viktorin from comment #6)
> > (In reply to Jaroslav Škarvada from comment #5)
> > 
> > > What about the *.pyc/*.pyo? Is it OK to ship the Python2 version of
> > > speedometer.py in /usr/bin without the precompiled byte code?
> > 
> > Yes. Python only automatically caches compiled bytecode for imported
> > modules, not for ones that are run directly.
> > This does mean that start-up time will be slower than it would be if the
> > code was in a library, but that doesn't seem to be a problem here.
> 
> OK, thanks for info, so this is not issue here.
> 
> For the review the rest of the comments applies.

Yeah. I've never seen such a thing in any package of the known repositories.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #7 from Jaroslav Škarvada  ---
(In reply to Petr Viktorin from comment #6)
> (In reply to Jaroslav Škarvada from comment #5)
> 
> > What about the *.pyc/*.pyo? Is it OK to ship the Python2 version of
> > speedometer.py in /usr/bin without the precompiled byte code?
> 
> Yes. Python only automatically caches compiled bytecode for imported
> modules, not for ones that are run directly.
> This does mean that start-up time will be slower than it would be if the
> code was in a library, but that doesn't seem to be a problem here.

OK, thanks for info, so this is not issue here.

For the review the rest of the comments applies.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #6 from Petr Viktorin  ---
(In reply to Jaroslav Škarvada from comment #5)

> What about the *.pyc/*.pyo? Is it OK to ship the Python2 version of
> speedometer.py in /usr/bin without the precompiled byte code?

Yes. Python only automatically caches compiled bytecode for imported modules,
not for ones that are run directly.
This does mean that start-up time will be slower than it would be if the code
was in a library, but that doesn't seem to be a problem here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #5 from Jaroslav Škarvada  ---
(In reply to Petr Viktorin from comment #4)
> This is an application that happens to be written in Python. The
> implementation language doesn't matter, since:
> - other software isn't expected to import the Python module
> - users aren't expected to write Python extensions
> 
> Given this, it doesn't make sense to package this as a Python module; see
> [Libraries and Applications] in Fedora guidelines. The naming guidelines for
> Python modules don't apply.
> 
> Since this is an application, please only package the Python2 version. Then,
> as soon as upstream adds support for py3, switch to it and drop py2.
> 
> 
> [Libraries and Applications]:
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Libraries_and_Applications

Petr thanks for info.

What about the *.pyc/*.pyo? Is it OK to ship the Python2 version of
speedometer.py in /usr/bin without the precompiled byte code?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Petr Viktorin  changed:

   What|Removed |Added

 CC||pvikt...@redhat.com



--- Comment #4 from Petr Viktorin  ---
This is an application that happens to be written in Python. The implementation
language doesn't matter, since:
- other software isn't expected to import the Python module
- users aren't expected to write Python extensions

Given this, it doesn't make sense to package this as a Python module; see
[Libraries and Applications] in Fedora guidelines. The naming guidelines for
Python modules don't apply.

Since this is an application, please only package the Python2 version. Then, as
soon as upstream adds support for py3, switch to it and drop py2.


[Libraries and Applications]:
https://fedoraproject.org/wiki/Packaging:Guidelines#Libraries_and_Applications

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Jaroslav Škarvada  changed:

   What|Removed |Added

   Assignee|ajschorr@alumni.princeton.e |jskar...@redhat.com
   |du  |



--- Comment #3 from Jaroslav Škarvada  ---
Well, I finally did the review myself, sorry for the delay and noise :)

I think that the spec (and dist-git repo/project) should be named
python-speedometer. I.e. that's exactly the same what I am trying to achieve in
the bug 1481645 with the pyobd package. The fedora naming guideline [1] is not
explicit about it, but I think that the section for Python modules apply.

Also I think that the %files section should be empty and that the executable
should be shipped in the python2- package. The Python packaging guidelines [2]
aren't explicit about it, but it makes sense to me: e.g. later, when the
upstream will add support for python 3 you will just add version suffix to the
main executables and both will be shipped, each in corresponding package (this
is in the guideline), also you will not need to ship CHANGELOG twice.

I would prefer making module from the main code, i.e. shipping the code in the
sitelib and only the main loader in the /usr/bin (i.e. no *.py in the
/usr/bin). That's exactly what I did in pyobd. Currently the
python2-speedometer package is empty (contains only the EGG and changelog) and
the python2 code is shipped in the speedometer package, which renders the
concept of python2/python3 subpackages useless. Moreover, the rpmbuild cannot
create precompiled *.pyc in the /usr/bin. I am afraid if the package will be
run by root user stalled (owned by none package) .pyc will be created under
/usr/bin, which seems really bad.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.

Upstream should be convinced to add the license file.

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "Unknown or generated". 1 files have
 unknown license. Detailed output of licensecheck in /home/yarda/git-
 fedora/speedometer/1462464-speedometer/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[!]: Package is named according to the Package Naming Guidelines.

See comments in the beginning.

[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.

At least python-urwid runtime dependency is missing, I got the following when
trying to run the package:

Traceback (most recent call last):
  File "/usr/bin/speedometer", line 6, in 
from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2958,
in 
@_call_aside
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2944,
in _call_aside
f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2971,
in _initialize_master_working_set
working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 635,
in _build_master
ws.require(__requires__)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 943,
in require
needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 829,
in resolve
raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'urwid>=0.9.9.1' distribution was not
found and is required by Speedometer

There may be more requires (I didn't check).

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch 

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Jaroslav Škarvada  changed:

   What|Removed |Added

   Assignee|jskar...@redhat.com |ajschorr@alumni.princeton.e
   ||du



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #2 from Jaroslav Škarvada  ---
Sorry for a bit delay, I am handing the review to Andrew J. Schorr, who I am
mentoring at the moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jskar...@redhat.com
   Assignee|nob...@fedoraproject.org|jskar...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Raphael Groner  changed:

   What|Removed |Added

  Alias||speedometer



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464



--- Comment #1 from Raphael Groner  ---
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=20057130

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1462464] Review Request: speedometer - Chart network TX/ RX and file download rates on the console

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1462464

Raphael Groner  changed:

   What|Removed |Added

 Blocks||1462467




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1462467
[Bug 1462467] Review Request: hollywood - Fill your console with Hollywood
melodrama techno-babble
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org