[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Peter Robinson  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 CC||pbrobin...@gmail.com
 Resolution|--- |RAWHIDE
Last Closed||2020-02-29 12:49:41



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #16 from Fedora Update System  ---
libcbor-0.5.0-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c38598bde8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #15 from Fedora Update System  ---
libcbor-0.5.0-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-33b4a3bcef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
libcbor-0.5.0-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc391a2c53

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #13 from Fedora Update System  ---
libcbor-0.5.0-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-dc391a2c53

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #12 from Fedora Update System  ---
libcbor-0.5.0-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-33b4a3bcef

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #11 from Fedora Update System  ---
libcbor-0.5.0-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-c38598bde8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Radovan Sroka  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|rsr...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - C library for parsing and generating CBOR

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Marek Tamaskovic  changed:

   What|Removed |Added

   Assignee|rsr...@redhat.com   |nob...@fedoraproject.org
Summary|Review Request: libcbor -   |Review Request: libcbor - C
   |new cbor library|library for parsing and
   ||generating CBOR



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - new cbor library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Radovan Sroka  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|rsr...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - new cbor library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Marek Tamaskovic  changed:

   What|Removed |Added

 Status|NEW |VERIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - new cbor library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Marek Tamaskovic  changed:

   What|Removed |Added

 Status|VERIFIED|ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor - new cbor library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Marek Tamaskovic  changed:

   What|Removed |Added

Summary|Review Request: libcbor |Review Request: libcbor -
   ||new cbor library



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Radovan Sroka  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Radovan Sroka  ---
Giving fedora_review flag+.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #9 from Marek Tamaskovic  ---
Update.
-make macro

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #8 from Robert-André Mauchin  ---
One last thing, although not mandatory, you should replace "make
%{?_smp_mflags}" with the "%make_build" macro.

Otherwise, it's all good. It just needs to be officially approved.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Apache (v2.0)", "Unknown or generated".
 438 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/libcbor/review-libcbor/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/include/cbor/internal, /usr/include/cbor
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/include/cbor/internal,
 /usr/include/cbor
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libcbor-
 debuginfo
[x]: Package functions as 

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #7 from Marek Tamaskovic  ---
Update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #6 from Robert-André Mauchin  ---
 - "Source1:libcbor-%{version}.tar.gz" is not needed, only SOUrCE0 as I
described.

 - Please remove the quotes "" around -devel description

Otherwise it looks fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #5 from Mark  ---
Updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #4 from Robert-André Mauchin  ---
Hello,

A few notes regarding your SPEC:

- SOURCE0 should point to the URL of the archive. For example in your case,
 SOURCE0:
https://github.com/PJK/libcbor/archive/v%{version}.tar.gz#/${name}-%{version}.tar.gz

 - you can use rpm macros for cp and mkdir -p:
   - cp → %{__cp}
   - mkdir -p → %{__mkdir_p}

 - %setup -q is fine but note that you can also use %autosetup . It patches the
source automatically if you ever need patch.

 - I would put the %cmake macro in %build, not %prep 

 - These BR are not needed: gcc gcc-c++
   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

 - I would repeat you short description in the -devel package too:

"libcbor is a C library for parsing and generating CBOR.

The %{name}-devel contains libraries and header files for %{name}."

 - The "Group:" tag should not be used. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

Thank you

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #3 from Mark  ---
Spec URL: https://pagure.io/libcbor_review/raw/master/f/libcbor.spec
SRPM URL:
https://pagure.io/libcbor_review/raw/master/f/libcbor-0.5.0-1.fc26.src.rpm
Description: Libcbor is a C library for parsing and generating CBOR, the
general-purpose schema-less binary data format.
Fedora Account System Username: mtamasko

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Jiří Vymazal  changed:

   What|Removed |Added

 CC||jvyma...@redhat.com
Version|26  |rawhide



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #2 from Jiří Vymazal  ---
*** Bug 1420336 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694



--- Comment #1 from Radovan Sroka  ---
Link to repo is not sufficient. 

Your comment should contain at least:

...
Spec URL: 
SRPM URL: 
Description: 
Fedora Account System Username: 
...

fedora-review tool needs to parse those fields.
After each update you need to provide new URLs in last comment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Radovan Sroka  changed:

   What|Removed |Added

 CC||rsr...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1474694] Review Request: libcbor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1474694

Mark  changed:

   What|Removed |Added

   Hardware|All |x86_64
Version|rawhide |26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org