[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #12 from Fedora Update System  ---
qdirstat-1.4-3.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-08-28 18:22:03



--- Comment #11 from Fedora Update System  ---
qdirstat-1.4-3.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #10 from Fedora Update System  ---
qdirstat-1.4-3.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8fd9fb646b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
qdirstat-1.4-3.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a546993ca7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #8 from Fedora Update System  ---
qdirstat-1.4-3.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8fd9fb646b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/qdirstat

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #6 from Robert-André Mauchin  ---
Ok will do. Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Antonio Trande  ---
In this way, 

...
%{_docdir}/%{name}/*
...

'%{_docdir}/%{name}' is not owned; please, use just

...
%{_docdir}/%{name}/
...

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #4 from Robert-André Mauchin  ---
Updated with your recommendation.

SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591438-qdirstat/qdirstat.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591438-qdirstat/qdirstat-1.4-3.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #3 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

== Issues ==

- %doc %{_docdir}/%{name}/*

Documentation files are already installed in the %doc directory by Make.
Just use:

%{_docdir}/%{name}/

- 'hicolor-icon-theme' is required

- Add an appdata file.
https://fedoraproject.org/wiki/Packaging:AppData


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* GPL (v2 or later)", "Unknown or generated". 221
 files have unknown license. Detailed output of licensecheck in
 /home/sagitter/1476201-qdirstat/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/qdirstat
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/qdirstat,
 /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/32x32,
 /usr/share/icons/hicolor
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
 contains desktop file(s) with a MimeType: entry.
 Note: desktop file(s) with MimeType entry in qdirstat
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in qdirstat
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 204800 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file 

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #2 from Robert-André Mauchin  ---
I have been sponsored since then.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Antonio Trande  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||anto.tra...@gmail.com
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1476201] Review Request: qdirstat - Qt-based directory statistics

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1476201



--- Comment #1 from Robert-André Mauchin  ---
SPEC URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591266-qdirstat/qdirstat.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/qdirstat/fedora-rawhide-x86_64/00591266-qdirstat/qdirstat-1.4-3.fc27.src.rpm

FAS username: eclipseo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org