[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Dridi Boukelmoune changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |WONTFIX Last Closed||2018-08-16 03:18:29 --- Comment #13 from Dridi Boukelmoune --- Closing in favor of bug 1617920. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ANEKVNTI53E7RFB6LG563FNV6TFSINDM/
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Dridi Boukelmoune changed: What|Removed |Added Alias|kcov| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/IERIRODRHRGEFB7COO6CWXWOQ3YMEXRN/
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Dridi Boukelmoune changed: What|Removed |Added Status|POST|ASSIGNED --- Comment #12 from Dridi Boukelmoune --- Spec URL: https://dridi.fedorapeople.org/review/kcov.spec SRPM URL: https://dridi.fedorapeople.org/review/kcov-34-1.fc29.src.rpm Let it be known that I was wrong and Simon was right, the reason why building with dyninst worked was because one of its nested dependencies brought python in. So I updated the spec one last time after trying to build it on platforms that were initially excluded because of dyninst, wrote a patch for aarch64, and now only the s390 family is left unsupported. Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=25737460 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 --- Comment #11 from Dridi Boukelmoune --- Spec URL: https://dridi.fedorapeople.org/review/kcov.spec SRPM URL: https://dridi.fedorapeople.org/review/kcov-34-1.fc29.src.rpm I'm afraid Simon was wrong because without dyninst the build plainly fails: https://koji.fedoraproject.org/koji/taskinfo?taskID=25697748 Here is a scratch build of this latest submission: https://koji.fedoraproject.org/koji/taskinfo?taskID=25698142 The only change is the Source tag resulting in a much better archive name. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Robert-André Mauchin changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #10 from Robert-André Mauchin --- Perfect, package is approved then. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 --- Comment #9 from Dridi Boukelmoune --- > You forgot that part mentioned by Raphael: No, a comment only until the package is approved according to the guidelines. > Remove cmake(dyninst) as upstream recommended Will do! > Use a more meaningful name for your archive: Thanks for the tip! > kcov.x86_64: E: incorrect-fsf-address /usr/share/licenses/kcov/COPYING > > Notify upstream about this Already done last August, fixed in git and pending a release. https://github.com/SimonKagstrom/kcov/commit/116b7e8ef48c2ade8e345e9403a51ec8cb4aa719 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752
Robert-André Mauchin changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zebo...@gmail.com
Assignee|nob...@fedoraproject.org|zebo...@gmail.com
Flags||fedora-review?
--- Comment #8 from Robert-André Mauchin ---
- You forgot that part mentioned by Raphael:
Create a separate bug for each entry of ExcludeArch and let it block the
individual tracker.
https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures
- Remove cmake(dyninst) as upstream recommended
- Use a more meaningful name for your archive:
Source:
https://github.com/SimonKagstrom/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz
- kcov.x86_64: E: incorrect-fsf-address /usr/share/licenses/kcov/COPYING
Notify upstream about this
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 209 files have
unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/kcov/review-kcov/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license t
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Simon Kågström changed: What|Removed |Added CC||simon.kagst...@gmail.com --- Comment #7 from Simon Kågström --- A small note: kcov doesn't actually depend on dyninst. It did that for a while between v33 and v34, but that dependency is gone again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 --- Comment #6 from Dridi Boukelmoune --- Sorry for the unresponsiveness, it's been quite a while already and today I'm dealing with a bunch of packages I maintain at once, and this one I'm submitting. In the mean time kcov-34 was released: Spec URL: https://dridi.fedorapeople.org/review/kcov.spec SRPM URL: https://dridi.fedorapeople.org/review/kcov-34-1.fc28.src.rpm Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=23630352 (rawhide) https://koji.fedoraproject.org/koji/taskinfo?taskID=23630994 (f27) https://koji.fedoraproject.org/koji/taskinfo?taskID=23631090 (f26) Raphael, even though you removed yourself as the reviewer, I will nevertheless answer your comments for the next reviewer. > You can directly link to pushed commits being parts of pull requests. While the commits would apply to the master branch, some wouldn't directly apply to the kcov-33 release. No longer a problem, they are part of kcov-34. > Please decide if the package is for python2 or python3, maybe both. The package can work with both, and python was only needed by the test suite that is not yet in a shape suitable for the %check step. I was discussing this upstream at the time and will hopefully find time later to revisit this. > Why not unbundle handlebars and jquery? TL;DR: They are used as static assets rather than libraries, full story in the updated spec. > What's the reason for concrete versions as noted? Required by the same guidelines you linked since I chose bundling. > Can you be more precise in %files about the file names? I'd rather lessen the packaging bureaucracy and use globs. As long as I don't own anything the package shouldn't, I believe it is allowed by the guidelines unless I missed an update at some point. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Raphael Groner changed: What|Removed |Added Assignee|projects...@smart.ms|nob...@fedoraproject.org --- Comment #5 from Raphael Groner --- First, some general advices: - You can directly link to pushed commits being parts of pull requests. For instance: Patch0: https://github.com/SimonKagstrom/kcov/commit/49b588443ddc6644f728d04af662a6d13d51ecd2.patch - Create a separate bug for each entry of ExcludeArch and let it block the individual tracker. https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Build_Failures - Please decide if the package is for python2 or python3, maybe both. The executables need to run with the versionized shebang command. BuildRequire: python is not unique about version. https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes https://fedoraproject.org/wiki/Packaging:Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks - Why not unbundle handlebars and jquery? What's the reason for concrete versions as noted? https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries - When above suggestion is applied to add direct links to upstream commits as patches, it's possible to use %autosetup only instead of %setup -q and several %patch lines. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25prep_section:_.25autosetup_command - Can you be more precise in %files about the file names? It would simplify further updates and 'll show new and lost files. https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25files_section -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 --- Comment #4 from Dridi Boukelmoune --- Spec URL: https://dridi.fedorapeople.org/review/kcov.spec SRPM URL: https://dridi.fedorapeople.org/review/kcov-33-1.fc28.src.rpm Now works with (optional dependency) binutils on all branches. Scratch builds (rawhide to f25): https://koji.fedoraproject.org/koji/taskinfo?taskID=21479803 https://koji.fedoraproject.org/koji/taskinfo?taskID=21479807 https://koji.fedoraproject.org/koji/taskinfo?taskID=21479811 https://koji.fedoraproject.org/koji/taskinfo?taskID=21479815 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Raphael Groner changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|projects...@smart.ms --- Comment #3 from Raphael Groner --- (In reply to Dridi Boukelmoune from comment #2) > Sure, I will gladly review your request too. Probably not before next > weekend though but I see it depends on another review request so hopefully > there's no hurry yet. Dridi, thanks for your interest. We're nearly done with the dependencies, so it shouldn't block the review. Though, please don't expect any needed hurry as well. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 --- Comment #2 from Dridi Boukelmoune --- Hi Raphael, Sure, I will gladly review your request too. Probably not before next weekend though but I see it depends on another review request so hopefully there's no hurry yet. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Raphael Groner changed: What|Removed |Added CC||projects...@smart.ms --- Comment #1 from Raphael Groner --- Hi Dridi, are you interested in a review swap, maybe you can look into bug #1462467? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1480752] Review Request: kcov - Code coverage tool without special compilation options
https://bugzilla.redhat.com/show_bug.cgi?id=1480752 Dridi Boukelmoune changed: What|Removed |Added Alias||kcov -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
