[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-28 15:58:47



--- Comment #10 from Fedora Update System  ---
greenwave-0.2-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477



--- Comment #9 from Fedora Update System  ---
greenwave-0.2-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f29c36f11d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
greenwave-0.1.1-2.dae6153.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9d66bdb641

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477



--- Comment #7 from Fedora Update System  ---
greenwave-0.1.1-2.dae6153.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-9d66bdb641

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
greenwave-0.1.1-1.02795e8.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2aed05b3c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477



--- Comment #5 from Fedora Update System  ---
greenwave-0.1.1-1.02795e8.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-2aed05b3c7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
greenwave-0.1-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fbe38da88c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477



--- Comment #3 from Fedora Update System  ---
greenwave-0.1-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-fbe38da88c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477



--- Comment #2 from Dan Callaghan  ---
Btw you can put me down as package co-maintainer.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1481477] Review Request: greenwave - Service for gating on automated tests by querying ResultsDB and WaiverDB

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1481477

Dan Callaghan  changed:

   What|Removed |Added

Summary|Review Request: greenwave - |Review Request: greenwave -
   |Greenwave is a service for  |Service for gating on
   |gating on automated tests   |automated tests by querying
   |by querying ResultsDB and   |ResultsDB and WaiverDB
   |WaiverDB|
  Flags||fedora-review+



--- Comment #1 from Dan Callaghan  ---
Approved BUT please see items under "Issues" that should be fixed on import.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues:
===

fedora-review found an (insignificant) difference between the tarball on PyPI 
vs. the tarball in your SRPM. This probably just means you built the SRPM from 
a hand-rolled tarball. Make sure you use the proper one published on PyPI when 
importing the package.

diff -U2 -r
/home/dcallagh/work/fedora/reviews/1481477-greenwave/upstream-unpacked/Source0/greenwave-0.1/setup.cfg
/home/dcallagh/work/fedora/reviews/1481477-greenwave/srpm-unpacked/greenwave-0.1.tar.gz-extract/greenwave-0.1/setup.cfg
---
/home/dcallagh/work/fedora/reviews/1481477-greenwave/upstream-unpacked/Source0/greenwave-0.1/setup.cfg
 2017-08-14 16:21:42.0 +1000
+++
/home/dcallagh/work/fedora/reviews/1481477-greenwave/srpm-unpacked/greenwave-0.1.tar.gz-extract/greenwave-0.1/setup.cfg
2017-08-15 11:09:53.0 +1000
@@ -2,4 +2,3 @@
 tag_build = 
 tag_date = 0
-tag_svn_revision = 0


There is also a typo in the %changelog, you have 0.1.1 but should be 0.1-1. 
Please correct this before importing.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 583680 bytes in 42 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the