[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1513301




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1513301
[Bug 1513301] Review Request: ghc-aws - Amazon Web Services (AWS) for
Haskell
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1496543




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1496543
[Bug 1496543] Review Request: ghc-http-conduit - HTTP client package with
conduit interface and HTTPS support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1496285




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1496285
[Bug 1496285] Review Request: ghc-http-client-tls - Http-client backend
using the connection package and tls library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1495476




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1495476
[Bug 1495476] Review Request: ghc-connection - Simple and easy network
connections API
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1495018




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1495018
[Bug 1495018] Review Request: ghc-tls - TLS/SSL protocol native
implementation (Server and Client)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1494886




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1494886
[Bug 1494886] Review Request: ghc-x509-validation - X.509 Certificate and
CRL validation
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1494879




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1494879
[Bug 1494879] Review Request: ghc-x509-system - Handle per-operating-system
X.509 accessors and storage
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1494676




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1494676
[Bug 1494676] Review Request: ghc-x509-store - X.509 collection accessing
and storing methods
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1494336




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1494336
[Bug 1494336] Review Request: ghc-x509 - X509 reader and writer
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1493789




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1493789
[Bug 1493789] Review Request: ghc-asn1-parse - Simple monadic parser for
ASN1 stream types
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-09 19:50:49



--- Comment #7 from Fedora Update System  ---
ghc-foundation-0.0.13-3.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1489306




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1489306
[Bug 1489306] Review Request: ghc-asn1-encoding - ASN1 data reader and
writer in RAW, BER and DER forms
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1488611




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1488611
[Bug 1488611] Review Request: ghc-cryptonite - Cryptography Primitives sink
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1488606




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1488606
[Bug 1488606] Review Request: ghc-asn1-types - ASN.1 types
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Blocks||1487900




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1487900
[Bug 1487900] Review Request: ghc-memory - Memory and related abstraction
stuff
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|ON_QA



--- Comment #6 from Fedora Update System  ---
ghc-foundation-0.0.13-3.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-6d6d02c7db

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ghc-foundation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507



--- Comment #4 from Robert-André Mauchin  ---
I forgot to add: The devel-doc subpackage must be noarch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #3 from Robert-André Mauchin  ---
All good, package accepted.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (unspecified)", "BSD (2 clause)", "Unknown or generated",
 "*No copyright* BSD (unspecified)". 106 files have unknown license.
 Detailed output of licensecheck in /home/bob/packaging/review/ghc-
 foundation/review-ghc-foundation/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/doc/ghc/html,
 /usr/share/doc/ghc/html/libraries, /usr/share/doc/ghc
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see 

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507



--- Comment #2 from Elliott Sales de Andrade  ---
Split apart the docs.

Spec URL: https://qulogic.fedorapeople.org/git-annex/ghc-foundation.spec
SRPM URL:
https://qulogic.fedorapeople.org/git-annex/ghc-foundation-0.0.13-2.git.0.3febe85.fc26.src.rpm
Description: A custom prelude with no dependencies apart from base.
Fedora Account System Username: qulogic

koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=21477279 
(still building)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1485507] Review Request: ghc-foundation - Alternative prelude with batteries and no dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1485507

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
Hello,

I've got an issue with the doc, they are to large, around 13MB, and thus they
should be in a separate noarch doc subpackage:

[!]: Large data in /usr/share should live in a noarch subpackage if package
 is arched.
 Note: Arch-ed rpms have a total of 13772800 bytes in /usr/share ghc-
 foundation-devel-0.0.13-1.fc26.x86_64.rpm:13762560
 See:

http://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org