[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-09-30 02:27:30



--- Comment #13 from Fedora Update System  ---
eosrei-emojione-fonts-1.0-5.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
eosrei-emojione-fonts-1.0-5.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-25da69a47f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #11 from Fedora Update System  ---
eosrei-emojione-fonts-1.0-5.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-25da69a47f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #10 from Parag AN(पराग)  ---
(In reply to Bastien Nocera from comment #8)
> (In reply to Bastien Nocera from comment #7)
> > (In reply to Parag AN(पराग) from comment #6)
> > > 2) Good to add appstream metainfo file for this font like we have this
> > > /usr/share/appdata/abattis-cantarell.metainfo.xml
> > 
> > Can you please file a separate bug about this?
> 
> FWIW, I'm not really sure of why we'd need that when both cantarell and
> emojione are pulled in by portion of our default desktop.

Hm, You are right. I am not sure if this can be a new topic of discussion. We
have almost all fonts providing metainfo files and then some fonts are already
present in default desktop installation. Not sure if we want to remove metainfo
files from them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #9 from Parag AN(पराग)  ---
Thanks for confirming output of requires/provides.

For metainfo file here is the new bug ->
https://bugzilla.redhat.com/show_bug.cgi?id=1491265

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #8 from Bastien Nocera  ---
(In reply to Bastien Nocera from comment #7)
> (In reply to Parag AN(पराग) from comment #6)
> > 2) Good to add appstream metainfo file for this font like we have this
> > /usr/share/appdata/abattis-cantarell.metainfo.xml
> 
> Can you please file a separate bug about this?

FWIW, I'm not really sure of why we'd need that when both cantarell and
emojione are pulled in by portion of our default desktop.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #7 from Bastien Nocera  ---
(In reply to Parag AN(पराग) from comment #6)
> 1) I am not sure if something is wrong on my f27 system but following does
> not give any output to me whereas all other fonts are giving some output.
> 
> sudo dnf repoquery --provides eosrei-emojione-fonts
> sudo dnf repoquery --requires eosrei-emojione-fonts

$ rpm -q --provides eosrei-emojione-fonts
eosrei-emojione-fonts = 1.0-4.fc27
font(emojione)

As expected.

> 2) Good to add appstream metainfo file for this font like we have this
> /usr/share/appdata/abattis-cantarell.metainfo.xml

Can you please file a separate bug about this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||fonts-bugs@lists.fedoraproj
   ||ect.org,
   ||i18n-bugs@lists.fedoraproje
   ||ct.org, panem...@gmail.com



--- Comment #6 from Parag AN(पराग)  ---
1) I am not sure if something is wrong on my f27 system but following does not
give any output to me whereas all other fonts are giving some output.

sudo dnf repoquery --provides eosrei-emojione-fonts
sudo dnf repoquery --requires eosrei-emojione-fonts

2) Good to add appstream metainfo file for this font like we have this
/usr/share/appdata/abattis-cantarell.metainfo.xml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
eosrei-emojione-fonts-1.0-4.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f9009714eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #4 from Fedora Update System  ---
eosrei-emojione-fonts-1.0-4.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f9009714eb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123



--- Comment #3 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/eosrei-emojione-fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Bastien Nocera  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|amigad...@amigadave.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

Bastien Nocera  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #2 from Bastien Nocera  ---
-4 version available at:
https://hadess.fedorapeople.org/emoji/

I'm not sure we should add the cairo/fontconfig/pango dependencies, as the font
will still "work" if those aren't around, it'll just trigger bugs in various
places.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487123] Review Request: eosrei-emojione-fonts - A color emoji font

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487123

David King  changed:

   What|Removed |Added

 CC||amigad...@amigadave.com
  Flags||fedora-review+



--- Comment #1 from David King  ---
All the font-specific stuff seems fine to me (I checked the .ttf with "ttname
-a" to verify the licensing). Bastien discussed some concerns on IRC,
including:

* the fontconfig release containing the config file bits is not out yet, so a
dependency on that version may be wise
* a cairo release containing the necessary improvements for colour emoji
support (1.15.8) is not yet in Fedora, similar consideration to the fontconfig
dependency

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor,