[Bug 1487419] Review Request: wsprx - Weak Signal Propagation Reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487419

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |WONTFIX
Last Closed||2017-09-01 17:59:54



--- Comment #5 from Jaroslav Škarvada  ---
Upstream statement regarding WSPR-X and WSJT-X:
"I do not recommend packaging WSPR-X for any platform or distribution.  WSPR-X
is obsolete, and no longer supported. Its functions are limited, and anyway now
much better served by WSJT-X."

WSJT-X review request is in bug 1487776.

So closing this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487419] Review Request: wsprx - Weak Signal Propagation Reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487419



--- Comment #4 from Jaroslav Škarvada  ---
Btw at the moment I am trying to package WSJT-X, which is a bit tricky.
According to upstream WSJT-X superseded WSPR-X, so if I successfully package
it, I will probably drop this request - if not, I will go with WSPR-X instead
(it can still do the job).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487419] Review Request: wsprx - Weak Signal Propagation Reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487419



--- Comment #3 from Jaroslav Škarvada  ---
(In reply to Robert-André Mauchin from comment #2)
>  - Why do you make a -doc subpackage for a single file? Just include it in
> the %doc directive:
> 
> %files
> %doc WSPR-X_Users_Guide.pdf
> 
That's intended, not everybody needs the guide.

>  - Why do you want to convert the docx to a PDF?
Because docx is um, non optimal format. Not everybody has reader for it. And
btw upstream also converts to PDF and ships PDF in binary package.

> And why do you pull
> Libreoffice Writer (which is a huge dependency) to just do that?
>
Not an issue, build time dep.

> If you feel necessary to join the help in PDF, I think it would be better to
> add it as Source1 with a comment on how you converted it. (for that I
It's better to automate and convert it in build time instead of ad-hoc manual
hacks.

> suggest you to also look at pandoc, a command line tool to convert to and
> from multiple format).
Libreoffice do a much better job.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487419] Review Request: wsprx - Weak Signal Propagation Reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487419

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin  ---
Hello,


Additionally:

 - You can replace make %{?_smp_mflags} install DESTDIR=%{buildroot} with
%make_install
 - make %{?_smp_mflags} → %make_build

 - Why do you make a -doc subpackage for a single file? Just include it in the
%doc directive:

%files
%doc WSPR-X_Users_Guide.pdf

 - Why do you want to convert the docx to a PDF? And why do you pull
Libreoffice Writer (which is a huge dependency) to just do that?

If you feel necessary to join the help in PDF, I think it would be better to
add it as Source1 with a comment on how you converted it. (for that I suggest
you to also look at pandoc, a command line tool to convert to and from multiple
format).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1487419] Review Request: wsprx - Weak Signal Propagation Reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1487419

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #1 from Iwicki Artur  ---
>Group: Applications/Engineering
The "Group" tag should not be used. 
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

>%{_datadir}/icons/hicolor/32x32/apps/wsprx.png
This directory has an unknown owner. You should add "Requires:
hicolor-icon-theme".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org