[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #17 from Fedora Update System  ---
brightlight-5-2.fc25 has been pushed to the Fedora 25 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-11-04 17:09:38 |2017-11-15 12:40:59



--- Comment #16 from Fedora Update System  ---
brightlight-5-1.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #15 from Fedora Update System  ---
brightlight-5-2.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bb6b5c4df7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #14 from Fedora Update System  ---
brightlight-5-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-bb6b5c4df7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-11-04 17:09:38



--- Comment #13 from Fedora Update System  ---
brightlight-5-1.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #12 from Fedora Update System  ---
brightlight-5-1.fc25 has been pushed to the Fedora 25 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8071ee299f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
brightlight-5-1.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b221e2951

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #10 from Fedora Update System  ---
brightlight-5-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-8071ee299f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
brightlight-5-1.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3f085b86e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #8 from Fedora Update System  ---
brightlight-5-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f3f085b86e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #7 from Fedora Update System  ---
brightlight-5-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b221e2951

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #6 from Fedora Update System  ---
brightlight-5-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b221e2951

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #5 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/brightlight

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Igor Gnatenko  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+
   |needinfo?(ignatenko@redhat. |
   |com)|



--- Comment #4 from Igor Gnatenko  ---
> Source0:%{url}/archive/v%{version}.tar.gz
Source0:%{url}/archive/v%{version}/%{name}-%{version}.tar.gz

Otherwise looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Justin W. Flory  changed:

   What|Removed |Added

  Flags||needinfo?(ignatenko@redhat.
   ||com)



--- Comment #3 from Justin W. Flory  ---
I have submitted the fixes to the SPEC file in the repo.

https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SPECS/brightlight.spec
https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SRPMS/brightlight-5-1.fc26.src.rpm

Additionally, since the maintainer accepted your patch and cut a new release, I
also updated my SPEC to correspond to v5.

I was able to build this successfully in Koji (F27) and in my COPR.

https://koji.fedoraproject.org/koji/taskinfo?taskID=22588233
https://copr.fedorainfracloud.org/coprs/jflory7/brightlight/build/646671/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Igor Gnatenko  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #2 from Igor Gnatenko  ---
> %global debug_package %{nil}
No, this is rutning off debug while you really need it.

> URL:https://github.com/multiplexd/%{name}
My personal preference is to have links clickable ;)

> Source0:
> https://github.com/multiplexd/%{name}/archive/v%{version}.tar.gz
Give it meaningful name and you can also simplify it:
%{url}/archive/v%{version}/%{name}-%{version}.tar.gz

> BuildRequires:  libbsd
libbsd-devel is enough

> make %{?_smp_mflags}
%make_build

> rm -rf $RPM_BUILD_ROOT
Not needed

> install -p -m 755 %{_builddir}/%{name}-%{version}/%{name} 
> %{buildroot}%{_bindir}
install -p -m 755 %{name} %{buildroot}%{_bindir}/%{name}

---

And the main and big problem is that CFLAGS and LDFLAGS are ignored, you need
to patch Makefile.. Or just stop using makefile ;)

This is what I see from build.log: gcc brightlight.c -o brightlight -O2
-fstack-protector-strong -lbsd

while it should be: gcc brightlight.c -o brightlight -O2 -g -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -Wl,-z,relro
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld -lbsd

I've created patch for upstream which you can use:
https://github.com/multiplexd/brightlight/pull/1

This will fix problem with debuginfo thing you have.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Igor Gnatenko  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026



--- Comment #1 from Igor Gnatenko  ---
Please give RAW links to spec/srpm next time ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Igor Gnatenko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ignate...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1505026] Review Request: brightlight - CLI tool to change screen back light brightness

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1505026

Justin W. Flory  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org