[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 Matthew Barnes changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2017-11-02 07:02:04 |2017-11-15 12:57:29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #12 from Fedora Update System --- gnome-video-arcade-0.8.8-1.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #11 from Fedora Update System --- gnome-video-arcade-0.8.8-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #10 from Fedora Update System --- gnome-video-arcade-0.8.8-1.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1054855589 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 Fedora Update System changed: What|Removed |Added Status|CLOSED |ON_QA Resolution|RAWHIDE |--- Keywords||Reopened --- Comment #9 from Fedora Update System --- gnome-video-arcade-0.8.8-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-89e42e75cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #8 from Fedora Update System --- gnome-video-arcade-0.8.8-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-89e42e75cb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #7 from Fedora Update System --- gnome-video-arcade-0.8.8-1.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1054855589 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 Matthew Barnes changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2017-11-02 07:02:04 --- Comment #6 from Matthew Barnes --- Packages built for rawhide, f26, and f27. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #5 from Gwyn Ciesla --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-video-arcade -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #4 from Matthew Barnes --- Thanks, good catch! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 Robert-André Mauchin changed: What|Removed |Added Status|NEW |POST Assignee|nob...@fedoraproject.org|zebo...@gmail.com Flags||fedora-review+ --- Comment #3 from Robert-André Mauchin --- You've added a typo: BuildRequires: pkgconfig(libsoup2.4) ⇒ BuildRequires: pkgconfig(libsoup-2.4) Package otherwise accepted, just don't forget to fix the typo before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997 --- Comment #2 from Matthew Barnes --- Thanks for looking at this so quickly. Being as I'm the upstream author, I'll defer on the Appdata file for now and add it upstream for the next release, if that's acceptable to you. Uploaded new spec/srpms that I believe addressed everything else. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1507997] Review Request: gnome-video-arcade - simple MAME front-end
https://bugzilla.redhat.com/show_bug.cgi?id=1507997
Robert-André Mauchin changed:
What|Removed |Added
CC||zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin ---
Hello,
- Group: is not used in Fedora. See:
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
- make %{?_smp_mflags} → %make_build
- make install DESTDIR=$RPM_BUILD_ROOT → %make_install
- glib-compile-schemas is not needed in %postun and %posttrans for Fedora >=
24. See:
https://fedoraproject.org/w/index.php?title=Packaging:Scriptlets&oldid=481889#GSettings_Schema
- There should not be any %defattr(-,root,root,-) in %files
- The COPYING file should be included with the %license macro, not %doc:
%doc AUTHORS ChangeLog NEWS README
%license COPYING
- Use pkgconfig for BR when you can:
BuildRequires: desktop-file-utils
BuildRequires: gettext
BuildRequires: pkgconfig(gsettings-desktop-schemas)
BuildRequires: pkgconfig(gtk+-3.0) >= %{gtk3_version}
BuildRequires: intltool
BuildRequires: pkgconfig(x11)
BuildRequires: pkgconfig(libsoup-2.4)
BuildRequires: pkgconfig(libwnck-3.0) >= %{libwnck3_version}
BuildRequires: perl-XML-Parser
BuildRequires: pkgconfig(sqlite3)
BuildRequires: yelp-tools
- Consider adding an Appdata file:
https://fedoraproject.org/wiki/Packaging:AppData
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
