[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002
Bug 1508002 depends on bug 1507986, which changed state.

Bug 1507986 Summary: Review Request: toxcore - Peer to peer instant messenger
https://bugzilla.redhat.com/show_bug.cgi?id=1507986

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002
Bug 1508002 depends on bug 1507985, which changed state.

Bug 1507985 Summary: Review Request: libfilteraudio - Lightweight audio 
filtering library made from webrtc code
https://bugzilla.redhat.com/show_bug.cgi?id=1507985

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-19 14:44:52



--- Comment #9 from Fedora Update System  ---
utox-0.16.1-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
utox-0.16.1-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b79e2e6250

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002



--- Comment #7 from Fedora Update System  ---
utox-0.16.1-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-b79e2e6250

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/utox

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002

Sandro Mani  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Sandro Mani  ---
All good, approved!

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (2 clause)", "Unknown or generated".
 343 files have unknown license. Detailed output of licensecheck in
 /home/sandro/Desktop/review/1508002-utox/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[ -: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in utox
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 81920 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in utox-
 debuginfo , utox-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package 

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002



--- Comment #4 from Robert-André Mauchin  ---
 - License is GPLv3+ or MIT according to the LICENSE file.
 - Removed hicolor/14x14

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/29c2a3b/utox.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00657600-utox/utox-0.16.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002



--- Comment #3 from Sandro Mani  ---
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (2 clause)", "Unknown or generated".
 343 files have unknown license.

=> The license should be MIT according to uTox-0.16.1/LICENSE


[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/icons/hicolor/14x14,
 /usr/share/icons/hicolor/14x14/apps
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/icons/hicolor,
 /usr/share/icons/hicolor/14x14/apps, /usr/share/icons/hicolor/14x14

=> hicolor icon theme does not provide the 14x14 directory, unless it is really
necessary I suppose you can also just delete that particular icon size.

Rest is good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: utox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002

Robert-André Mauchin  changed:

   What|Removed |Added

Summary|Review Request: uTox - The  |Review Request: utox - The
   |lightweight Tox client  |lightweight Tox client



--- Comment #2 from Robert-André Mauchin  ---
 - Done
 - I've elected to rename the package from uTox to utox


Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/82987b1/utox.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/tox/fedora-rawhide-x86_64/00657051-utox/utox-0.16.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: uTox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002



--- Comment #1 from Sandro Mani  ---
I'm not sure whether address sanitizer ought to be enabled in a release build,
since it is basically a memory error debugging aid. I'd go with ENABLE_ASAN=OFF
and remove libasan from the BRs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: uTox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002

Sandro Mani  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||manisan...@gmail.com
   Assignee|nob...@fedoraproject.org|manisan...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1508002] Review Request: uTox - The lightweight Tox client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1508002

Robert-André Mauchin  changed:

   What|Removed |Added

 Depends On||1507985, 1507986




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1507985
[Bug 1507985] Review Request: libfilteraudio - Lightweight audio filtering
library made from webrtc code
https://bugzilla.redhat.com/show_bug.cgi?id=1507986
[Bug 1507986] Review Request: toxcore - Peer to peer instant messenger
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org