[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119

Alfredo Moralejo  changed:

   What|Removed |Added

  Flags|needinfo?(lin.a.yang@intel. |fedora-review+
   |com)|



--- Comment #11 from Alfredo Moralejo  ---
Fedora review output:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.png is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or
 generated", "*No copyright* Apache (v2.0)". 36 files have unknown
 license. Detailed output of licensecheck in /tmp/1514119-python-
 rsdclient/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: Avoid bundling fonts in non-fonts packages.
 Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-rsdclient , python2-rsdclient-tests , 

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119



--- Comment #10 from Alfredo Moralejo  ---

SRPM URL:
https://amoralej.fedorapeople.org/rsdclient/python-rsdclient-0.1.1-1.fc28.src.rpm

Spec URL: https://amoralej.fedorapeople.org/rsdclient/python-rsdclient.spec

Successful scratch build in
https://koji.fedoraproject.org/koji/taskinfo?taskID=24097961

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119



--- Comment #9 from Alfredo Moralejo  ---
As this is for Fedora i think we need proper spec and srpm for last release as
we ded of rsd-lib package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119



--- Comment #8 from Alan Pevec  ---
nm, it does not work, also Spec has dlrn-ish Version/Release XXX (we could set
that to the actual versions in the initial RDO reviews, DLRN ignores them
anyway...)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119

Alan Pevec  changed:

   What|Removed |Added

 CC||ape...@redhat.com



--- Comment #7 from Alan Pevec  ---
Let's try with spec and srpm from the review.rdo?

Spec URL:
https://review.rdoproject.org/r/gitweb?p=openstack/rsdclient-distgit.git;a=blob_plain;f=python-rsdclient.spec;hb=313305ed805ddaddd7d8da39ec3f0495c75fb423

SRPM URL:
https://logs.rdoproject.org/20/10620/15/gate/DLRN-rpmbuild/Z7e0a7a43468047f59a31c27a87363a74/centos/current/python-rsdclient-0.1.1-0.20180106004216.f02d3fc.el7.centos.src.rpm

Description:
This is a client for the RSD Pod Manager API, which is based on OpenStack
client framework. It provides a Python API (rsdclient/v1 module) and a RSD
specific plugin for OpenStack client (rsdclient/osc).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119

Alfredo Moralejo  changed:

   What|Removed |Added

  Flags||needinfo?(lin.a.yang@intel.
   ||com)



--- Comment #6 from Alfredo Moralejo  ---
Could you create a spec and srpm for releases 0.1.1 based on the approved
version in https://review.rdoproject.org/r/#/c/10620 and upload to some public
location to do the official review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119

Jon Schlueter  changed:

   What|Removed |Added

 Blocks||1466874




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1466874
[Bug 1466874] [Intel OSP13] Discover and compose Intel RSD nodes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119



--- Comment #5 from Lin Yang  ---
@Alfredo It passed all unit tests right now. Could you please help to review it
when you get chance? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119

Lin Yang  changed:

   What|Removed |Added

 CC||lin.a.y...@intel.com



--- Comment #4 from Lin Yang  ---
@Alfredo Current the tests failed because of missing python-rsd-lib package,
now the rsd-lib rdo project has been merged. Any suggestion about how to fix
this failure? Thanks in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119



--- Comment #3 from Alfredo Moralejo  ---
$ licensecheck -r .
./.coveragerc: *No copyright* UNKNOWN
./.gitreview: *No copyright* UNKNOWN
./.mailmap: *No copyright* UNKNOWN
./.testr.conf: *No copyright* UNKNOWN
./CONTRIBUTING.rst: *No copyright* UNKNOWN
./HACKING.rst: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache (v2.0)
./README.rst: *No copyright* UNKNOWN
./babel.cfg: *No copyright* UNKNOWN
./requirements.txt: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache
./setup.py: Apache (v2.0) GENERATED FILE
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./doc/source/conf.py: *No copyright* Apache (v2.0)
./doc/source/index.rst: *No copyright* UNKNOWN
./doc/source/readme.rst: *No copyright* UNKNOWN
./releasenotes/source/conf.py: *No copyright* Apache (v2.0) GENERATED FILE
./releasenotes/source/index.rst: *No copyright* UNKNOWN
./releasenotes/source/unreleased.rst: *No copyright* UNKNOWN
./rsdclient/common/base.py: Apache (v2.0)
./rsdclient/common/command.py: Apache (v2.0)
./rsdclient/common/utils.py: Apache (v2.0)
./rsdclient/osc/plugin.py: Apache (v2.0)
./rsdclient/tests/base.py: Apache (v2.0)
./rsdclient/v1/client.py: Apache (v2.0)
./rsdclient/v1/fabric.py: Apache (v2.0)
./rsdclient/v1/node.py: Apache (v2.0)
./rsdclient/v1/storage_service.py: Apache (v2.0)
./doc/source/cli/index.rst: *No copyright* UNKNOWN
./doc/source/cli/osc_plugin_cli.rst: *No copyright* UNKNOWN
./doc/source/contributor/contributing.rst: *No copyright* UNKNOWN
./doc/source/contributor/index.rst: *No copyright* UNKNOWN
./doc/source/install/index.rst: *No copyright* UNKNOWN
./doc/source/reference/index.rst: *No copyright* UNKNOWN
./doc/source/user/index.rst: *No copyright* UNKNOWN
./rsdclient/osc/v1/fabric.py: Apache (v2.0)
./rsdclient/osc/v1/node.py: Apache (v2.0)
./rsdclient/osc/v1/storage_service.py: Apache (v2.0)
./rsdclient/tests/common/fakes.py: Apache (v2.0)
./rsdclient/tests/common/test_command.py: Apache (v2.0)
./rsdclient/tests/common/test_utils.py: Apache (v2.0)
./rsdclient/tests/v1/test_client.py: Apache (v2.0)
./rsdclient/tests/v1/test_fabric.py: Apache (v2.0)
./rsdclient/tests/v1/test_node.py: Apache (v2.0)
./rsdclient/tests/v1/test_storage_service.py: Apache (v2.0)


License is valid: Apache v2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1514119] Add python-rsdclient to RDO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1514119

Alfredo Moralejo  changed:

   What|Removed |Added

 Target Release|trunk   |---
 CC||package-review@lists.fedora
   ||project.org
  Component|Package Review  |Package Review
Version|trunk   |rawhide
 Blocks||1486366 (RDO-QUEENS)
Product|RDO |Fedora




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1486366
[Bug 1486366] Tracker: Blockers and Review requests for new RDO Queens
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org