[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2018-01-02 11:23:02 |2018-02-27 15:39:29



--- Comment #17 from Fedora Update System  ---
perl-Data-Integer-0.006-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #16 from Fedora Update System  ---
perl-Data-Integer-0.006-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-ea8e5d2eb5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #15 from Fedora Update System  ---
perl-Data-Integer-0.006-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-ea8e5d2eb5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #14 from Fedora Update System  ---
perl-Data-Integer-0.006-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-02 11:23:02



--- Comment #13 from Fedora Update System  ---
perl-Data-Integer-0.006-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #12 from Fedora Update System  ---
perl-Data-Integer-0.006-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-539a8b58e2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
perl-Data-Integer-0.006-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-56be76145f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #10 from Fedora Update System  ---
perl-Data-Integer-0.006-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-539a8b58e2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #9 from Fedora Update System  ---
perl-Data-Integer-0.006-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-56be76145f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #8 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Data-Integer. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Petr Pisar  ---
Spec file changes:

--- perl-Data-Integer.spec.old  2017-12-06 08:44:07.66600 +0100
+++ perl-Data-Integer.spec  2017-12-07 09:22:19.97800 +0100
@@ -4,9 +4,9 @@
 Summary:Details of the native integer data type
 License:GPL+ or Artistic
 URL:http://search.cpan.org/dist/Data-Integer/
-Source0:   
http://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Data-Integer-%{version}.tar.gz
+Source0:   
https://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Data-Integer-%{version}.tar.gz
 BuildArch:  noarch
-BuildRequires:  perl >= 5.6
+BuildRequires:  perl(:VERSION) >= 5.6
 BuildRequires:  perl-generators
 BuildRequires:  perl-interpreter
 BuildRequires:  perl(Carp)

> FIX: This is still not correct. The correct RPM symbol is `perl(:VERSION)',
> not `perl'.
Ok.

The source archive is original (SHA-256:
63b77ede3b639ce351525034863629af989abcbff4ab03b14fc4ead461ffa354). Ok.

$ rpmlint perl-Data-Integer.spec
../SRPMS/perl-Data-Integer-0.006-1.fc28.src.rpm
../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

Package builds in F28
(https://koji.fedoraproject.org/koji/taskinfo?taskID=23562824). Ok.

The package is good.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #6 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/044a039/perl-Data-Integer.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685165-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/044a03915082b110c40bbfbadc70c339554545de#diff-12ce820cb7d7c06d431cb39906fa6237

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #5 from Petr Pisar  ---
Spec file changes:

--- perl-Data-Integer.spec.old  2017-12-05 12:43:40.87900 +0100
+++ perl-Data-Integer.spec  2017-12-06 08:44:07.66600 +0100
@@ -6,7 +6,7 @@
 URL:http://search.cpan.org/dist/Data-Integer/
 Source0:   
http://www.cpan.org/authors/id/Z/ZE/ZEFRAM/Data-Integer-%{version}.tar.gz
 BuildArch:  noarch
-BuildRequires:  perl >= 0:5.006
+BuildRequires:  perl >= 5.6
 BuildRequires:  perl-generators
 BuildRequires:  perl-interpreter
 BuildRequires:  perl(Carp)
@@ -18,7 +18,7 @@
 BuildRequires:  perl(strict)
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Pod::Coverage)
-BuildRequires:  perl(Test::Pod)
+BuildRequires:  perl(Test::Pod) >= 1.00
 BuildRequires:  perl(warnings)
 Requires:   perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))

@@ -43,7 +43,7 @@
 ./Build test

 %files
-%doc Changes META.json README
+%doc Changes README
 %{perl_vendorlib}/*
 %{_mandir}/man3/*


> FIX: Write dependency on a Perl language as `perl(:VERSION) >= 5.6' instead
> as `perl >= 0:5.006'. The `perl' package uses epoch and it pulls in
> unneeded packages.

FIX: This is still not correct. The correct RPM symbol is `perl(:VERSION)', not
`perl'.

> TODO: Do not package META.json. It's not intended for end users.
Ok.

> TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.00' (t/pod_syn.t:5).
Ok.

Please fix the dependency and provide a new spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #4 from Robert-André Mauchin  ---
And thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #3 from Robert-André Mauchin  ---
Damn, wrong RPM again.

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/047fc7f/perl-Data-Integer.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00684655-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #2 from Robert-André Mauchin  ---
I have applied you recommendations, and will update all my other Perl packages
suffering from the same issues accordingly.

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/047fc7f/perl-Data-Integer.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00684655-perl-Data-Integer/perl-Data-Integer-0.006-1.fc28.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571



--- Comment #1 from Petr Pisar  ---
I believe the correct SRPM URL is
.
I will use that for this review.

URL and Source addresses are Ok.
Source archive (SHA-256:
63b77ede3b639ce351525034863629af989abcbff4ab03b14fc4ead461ffa354) is original.
Ok.
Summary verified from lib/Data/Integer.pm. Ok.
Description verified from lib/Data/Integer.pm. Ok.
License verified from lib/Data/Integer.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Write dependency on a Perl language as `perl(:VERSION) >= 5.6' instead as
`perl >= 0:5.006'. The `perl' package uses epoch and it pulls in unneeded
packages.
TODO: Do not package META.json. It's not intended for end users.
TODO: Constrain `perl(Test::Pod)' dependency with `>= 1.00' (t/pod_syn.t:5).

All tests pass. Ok.

$ rpmlint perl-Data-Integer.spec
../SRPMS/perl-Data-Integer-0.006-1.fc28.src.rpm
../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm
drwxr-xr-x2 rootroot0 Dec  5 14:09
/usr/share/doc/perl-Data-Integer
-rw-r--r--1 rootroot 3442 Aug  7 23:08
/usr/share/doc/perl-Data-Integer/Changes
-rw-r--r--1 rootroot 1633 Aug  7 23:08
/usr/share/doc/perl-Data-Integer/META.json
-rw-r--r--1 rootroot  741 Aug  7 23:08
/usr/share/doc/perl-Data-Integer/README
-rw-r--r--1 rootroot 8177 Dec  5 14:09
/usr/share/man/man3/Data::Integer.3pm.gz
drwxr-xr-x2 rootroot0 Dec  5 14:09
/usr/share/perl5/vendor_perl/Data
-rw-r--r--1 rootroot34570 Dec  5 14:09
/usr/share/perl5/vendor_perl/Data/Integer.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm
| sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.26.1)
  1 perl(Carp)
  1 perl(Exporter)
  1 perl(integer)
  1 perl(parent)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm
| sort -f | uniq -c
  1 perl(Data::Integer) = 0.006
  1 perl-Data-Integer = 0.006-1.fc28
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Data-Integer-0.006-1.fc28.noarch.rpm 
Binary dependencies resolvable. Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the `FIX' item, consider fixing the `TODO' items and provide a
new spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1520571] Review Request: perl-Data-Integer - Details of the native integer data type

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1520571

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1520572




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1520572
[Bug 1520572] Review Request: perl-Authen-DecHpwd - DEC VMS password
hashing
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org