[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2017-12-26 11:30:35 |2018-02-27 15:39:11



--- Comment #15 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #14 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-d314769f44

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #13 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.el7 has been submitted as an update to Fedora EPEL
7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2018-d314769f44

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #12 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc27 has been pushed to the Fedora 27 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2017-12-26 11:30:35



--- Comment #11 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc26 has been pushed to the Fedora 26 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #10 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc26 has been pushed to the Fedora 26 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f5d200ddd4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc27 has been pushed to the Fedora 27 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a9b144da91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #8 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-f5d200ddd4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #7 from Fedora Update System  ---
perl-Algorithm-Loops-1.032-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2017-a9b144da91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Algorithm-Loops. You may commit to the
branch "f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Jitka Plesnikova  ---
> Description 
> TODO: Please update the description to provide a bit more information. 
>   E.g. to something like this:
>   Algorithm::Loops provides several functions (NestedLoops, MapCar*, Filter,
>   and NextPermute*) for doing different types of looping constructs. By
>   default, no functions are exported into a namespace.
Ok.

> BuildRequires are ok
> FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to
>  6.76 or higher, because NO_PACKLIST option was added in this version.
Ok.

> $ rpm -qp --requires perl-Algorithm-Loops-1.032-1.fc28.noarch.rpm | sort |
> uniq -c
>   1 perl(Carp)
>   2 perl(Exporter)
>   1 perl(:MODULE_COMPAT_5.26.1)
>   2 perl(strict)
>   2 perl(vars)
>   1 perl(warnings)
>   1 rpmlib(CompressedFileNames) <= 3.0.4-1
>   1 rpmlib(FileDigests) <= 4.6.0-1
>   1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>   1 rpmlib(PayloadIsXz) <= 5.2-1
> Binary requires are almost Ok.
> FIX: Please remove explicit run-requires of 'perl(Exporter)',
>  'perl(strict)' and 'perl(vars)', because they are found by
>  generators.
Ok.


> TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
> %install.
Ok.

> TODO: Please add 'ex' to %doc.
Not change.

The package is approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #4 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/904e69f/perl-Algorithm-Loops.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00687227-perl-Algorithm-Loops/perl-Algorithm-Loops-1.032-1.fc28.src.rpm

SPEC diff:
https://github.com/eclipseo/packaging/commit/904e69f905dd3f3880c598e648252e75e789bb5c#diff-ba0616aa2dcad2bdef28209addda6e8f


Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #3 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok

Description 
TODO: Please update the description to provide a bit more information. 
  E.g. to something like this:
  Algorithm::Loops provides several functions (NestedLoops, MapCar*, Filter,
  and NextPermute*) for doing different types of looping constructs. By
  default, no functions are exported into a namespace.

URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: Please add the version restriction for perl(ExtUtils::MakeMaker) to
 6.76 or higher, because NO_PACKLIST option was added in this version.

$ rpm -qp --requires perl-Algorithm-Loops-1.032-1.fc28.noarch.rpm | sort | uniq
-c
  1 perl(Carp)
  2 perl(Exporter)
  1 perl(:MODULE_COMPAT_5.26.1)
  2 perl(strict)
  2 perl(vars)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are almost Ok.
FIX: Please remove explicit run-requires of 'perl(Exporter)',
 'perl(strict)' and 'perl(vars)', because they are found by
 generators.

$ rpm -qp --provides perl-Algorithm-Loops-1.032-1.fc28.noarch.rpm | sort | uniq
-c
  1 perl(Algorithm::Loops) = 1.032
  1 perl-Algorithm-Loops = 1.032-1.fc28
Binary provides are Ok.

$ rpmlint ./perl-Algorithm-Loops*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

TODO: Replace variable PERL_INSTALL_ROOT obsoleted with DESTDIR name in
%install.
TODO: Please add 'ex' to %doc.

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

The package is not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #2 from Robert-André Mauchin  ---
Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/bad0a50/perl-Algorithm-Loops.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685361-perl-Algorithm-Loops/perl-Algorithm-Loops-1.032-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917

Robert-André Mauchin  changed:

   What|Removed |Added

 Blocks||1520569




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1520569
[Bug 1520569] Review Request: perl-Crypt-UnixCrypt_XS - Perl xs interface
for a portable traditional crypt function
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1522917] Review Request: perl-Algorithm-Loops - Perl module for looping constructs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1522917



--- Comment #1 from Robert-André Mauchin  ---
Forgot some BR.

Spec URL:
https://raw.githubusercontent.com/eclipseo/packaging/01555df/perl-Algorithm-Loops.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/eclipseo/ravada/fedora-rawhide-x86_64/00685163-perl-Algorithm-Loops/perl-Algorithm-Loops-1.032-1.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org