[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717
Bug 1526717 depends on bug 1526716, which changed state.

Bug 1526716 Summary: Review Request: qcas - Qt5 GUI application for Giac
https://bugzilla.redhat.com/show_bug.cgi?id=1526716

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ZM73UZPFQS2EMXPJZWJYNL4TQDREFAQM/

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Antonio Trande  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2018-07-19 14:13:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/T6F3SDFIO63V5OP4GO7AZID54TQTZVWY/

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #21 from Fedora Update System  ---
giac-1.4.9.45-2.fc27, python-giacpy-0.6.5-3.fc27, qcas-0.5.3-5.fc27 has been
pushed to the Fedora 27 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #20 from Fedora Update System  ---
giac-1.4.9.45-2.fc26, python-giacpy-0.6.5-3.fc26, qcas-0.5.3-5.fc26 has been
pushed to the Fedora 26 stable repository. If problems still persist, please
make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #19 from Fedora Update System  ---
giac-1.4.9.45-2.fc27, python-giacpy-0.6.5-3.fc27, qcas-0.5.3-5.fc27 has been
pushed to the Fedora 27 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6fd9d49e4d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #18 from Fedora Update System  ---
giac-1.4.9.45-2.fc26, python-giacpy-0.6.5-3.fc26, qcas-0.5.3-5.fc26 has been
pushed to the Fedora 26 testing repository. If problems still persist, please
make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-20e6c0f7cc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #17 from Fedora Update System  ---
python-giacpy-0.6.5-3.fc27 qcas-0.5.3-5.fc27 giac-1.4.9.45-2.fc27 has been
submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6fd9d49e4d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #16 from Fedora Update System  ---
python-giacpy-0.6.5-3.fc26 qcas-0.5.3-5.fc26 giac-1.4.9.45-2.fc26 has been
submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-20e6c0f7cc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #15 from Fedora Update System  ---
python-giacpy-0.6.5-2.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-28145db148

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
python-giacpy-0.6.5-2.fc26 has been pushed to the Fedora 26 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e0bc7a4b2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #12 from Fedora Update System  ---
python-giacpy-0.6.5-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-28145db148

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #13 from Fedora Update System  ---
python-giacpy-0.6.5-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-5e0bc7a4b2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #10 from Fedora Update System  ---
python-giacpy-0.6.5-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-6942b9aeae

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #11 from Fedora Update System  ---
python-giacpy-0.6.5-1.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-d1ab3e4970

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #8 from Antonio Trande  ---
(In reply to Robert-André Mauchin from comment #7)
> Well the install script includes it for a reason I suppose.

Not always.
http://xcas.e.ujf-grenoble.fr/XCAS/viewtopic.php?f=24=1987#p9784

> 
> Package approved anyway.

Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #7 from Robert-André Mauchin  ---
Well the install script includes it for a reason I suppose.

Package approved anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #6 from Antonio Trande  ---
Because it's unnecessary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #5 from Robert-André Mauchin  ---
Why do you remove the CPP file instead of including it to the -devel
subpackages?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #4 from Antonio Trande  ---
Spec URL: https://sagitter.fedorapeople.org/giacpy/python-giacpy.spec
SRPM URL:
https://sagitter.fedorapeople.org/giacpy/python-giacpy-0.6.5-1.fc27.src.rpm

- Release 0.6.5
- Enable qcas support
- Packaging of the development files

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717



--- Comment #3 from Robert-André Mauchin  ---
 - You should put the development files in two -devel subpackages,
python2-giacpy-devel and python3-giacpy-devel:

Issues:
===
- Header files in -devel subpackage, if present.
  Note: python2-giacpy : /usr/lib64/python2.7/site-
  packages/giacpy/giacpymisc.h python3-giacpy : /usr/lib64/python3.6/site-
  packages/giacpy/giacpymisc.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

python2-giacpy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/giacpy/giacpy.cpp
python2-giacpy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.7/site-packages/giacpy/giacpymisc.h

python3-giacpy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/giacpy/giacpy.cpp
python3-giacpy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.6/site-packages/giacpy/giacpymisc.h


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: python2-giacpy : /usr/lib64/python2.7/site-
  packages/giacpy/giacpymisc.h python3-giacpy : /usr/lib64/python3.6/site-
  packages/giacpy/giacpymisc.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* GPL". 12 files have
 unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/python-giacpy/review-python-
 giacpy/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[!]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec 

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Antonio Trande  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #2 from Antonio Trande  ---
Spec URL: https://sagitter.fedorapeople.org/giacpy/python-giacpy.spec
SRPM URL:
https://sagitter.fedorapeople.org/giacpy/python-giacpy-0.6.5-1.fc27.src.rpm

- Release 0.6.5
- Source package renamed with python- suffix as required by Python guidelines
- Source url grabbed by pythonhosted.org's repository
- Building processes restricted to the original directory

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1526717] Review Request: python-giacpy - Python binding for Giac

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1526717

Antonio Trande  changed:

   What|Removed |Added

Summary|Review Request: giacpy -|Review Request:
   |Python binding for Giac |python-giacpy - Python
   ||binding for Giac



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org