[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527682

Robbie Harwood  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-02 13:43:46



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527682



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-requests-gssapi

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527682

Robbie Harwood  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|zebo...@gmail.com



--- Comment #5 from Robbie Harwood  ---
Setting assignee since limb requires that...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527682

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
  Flags||fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527682



--- Comment #3 from Robbie Harwood  ---
Thanks for the fast responses!  Updated accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527682

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #2 from Neal Gompa  ---
A few spec comments:

> BuildRequires: git

Use "BuildRequires: git-core" to shorten the dep chain for buildroot (cuts out
a lot of weird Perl things you're not even using ;) )

> %{?python_provide:%python_provide python2-%{sname}}

This needs to be part of the subpackage preamble, not the description. Also,
you need a version for the python 3 flavor, too.

This package also needs adjustments to build in EPEL 7 Python 3, as that's
going to be necessary for Koji.

See for an example:
https://src.fedoraproject.org/rpms/python-pika/blob/master/f/python-pika.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1527682] Review Request: python-requests-gssapi - A Python requests module for GSSAPI/SPNEGO

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1527682

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - You need to add the BR for nosetests to run:

BuildRequires:  python2-nose
BuildRequires:  python3-nose


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "Unknown or generated". 17 files have unknown license.
 Detailed output of licensecheck in /home/bob/packaging/review/python-
 requests-gssapi/review-python-requests-gssapi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
 -requests-gssapi , python3-requests-gssapi
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported