[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Björn "besser82" Esser  changed:

   What|Removed |Added

 Status|POST|CLOSED
   Fixed In Version||wlroots-0.0.1-0.6.20180102g
   ||it767df15.fc28
 Resolution|--- |RAWHIDE
Last Closed||2018-01-03 08:12:39



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352



--- Comment #9 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/wlroots

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+
   |needinfo?(quantum.analyst@g |
   |mail.com)   |



--- Comment #8 from Elliott Sales de Andrade  ---
APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Björn "besser82" Esser  changed:

   What|Removed |Added

  Flags||needinfo?(quantum.analyst@g
   ||mail.com)



--- Comment #7 from Björn "besser82" Esser  ---
I've made all reasonable changes to package and gave some clarification to
other things in question.  Could you please approve the package and set the
review flag to '+', bug status to 'POST'?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Tristan Cacqueray  changed:

   What|Removed |Added

 CC||tdeca...@redhat.com



--- Comment #6 from Tristan Cacqueray  ---
Just a little nit: it seems like you could use "mkdir" and "cp" directly
instead of the %{__ macros.
Otherwise it's LGTM!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352



--- Comment #5 from Björn "besser82" Esser  ---
(In reply to Elliott Sales de Andrade from comment #4)
> Iwicki is correct about those two points.

Yes, of course…  But his suggestions are more a matter of taste, then
'hard-coded' rules.


> Not sure why you added explicit install to %_pkgdocdir; you could just list
> the
> relative paths in %doc directly. Is it to be able to delete .*ignore* and
> meson.build from the installed version?

I did that, so all built (sub-)packages share the same dir for documentation;
if you simply add the relative paths using %%doc, every %package will get a
seperate dir laying inside of %%{_defaultdocdir}.


> Need to add BuildRequires on gcc and/or g++:
> https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

Fixed.


> A couple files are not MIT; they are not installed, but I think some
> transformation of them is. Not exactly sure what the legal meaning of that
> is,
> or if you need to mention that in the license field.

I added some clarification comment to the spec file.


> It would be nice if the description said a bit more than the summary.

Well, at some day in the future, when upstream writes a better one…


> Package Review
> ==
> 
> [!]: License field in the package spec file matches the actual license.
>  Note: Checking patched sources after %prep for licenses. Licenses
>  found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "NTP (legal
>  disclaimer)", "Unknown or generated". 197 files have unknown license.
>  Detailed output of licensecheck in
>  /home/elliott/rpmbuild/review/1529352-wlroots/licensecheck.txt

See added clarification in the spec file.

***

=== Updated package ===


Scratch build:

  Rawhide:  https://koji.fedoraproject.org/koji/taskinfo?taskID=23955196


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/wlroots.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/wlroots-0.0.1-0.4.20171229git80ed4d4.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Elliott Sales de Andrade  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Elliott Sales de Andrade  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||quantum.anal...@gmail.com
   Assignee|nob...@fedoraproject.org|quantum.anal...@gmail.com



--- Comment #4 from Elliott Sales de Andrade  ---
Iwicki is correct about those two points.

Not sure why you added explicit install to %_pkgdocdir; you could just list the
relative paths in %doc directly. Is it to be able to delete .*ignore* and
meson.build from the installed version?

Need to add BuildRequires on gcc and/or g++:
https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B

A couple files are not MIT; they are not installed, but I think some
transformation of them is. Not exactly sure what the legal meaning of that is,
or if you need to mention that in the license field.

It would be nice if the description said a bit more than the summary.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: wlroots-debugsource :
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "NTP (legal
 disclaimer)", "Unknown or generated". 197 files have unknown license.
 Detailed output of licensecheck in
 /home/elliott/rpmbuild/review/1529352-wlroots/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 348160 bytes in 18 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a 

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352

Iwicki Artur  changed:

   What|Removed |Added

 CC||fed...@svgames.pl



--- Comment #3 from Iwicki Artur  ---
>Source0: %{url}/archive/%{commit}.tar.gz#/%{name}-%{version}%{?gitver}.tar.gz
With GitHub, you can use "%{url}/archive/%{commit}/%{name}-%{commit}.tar.gz".

>%{__mkdir} -p %{buildroot}%{_pkgdocdir}
>%{__cp} -pr README.md examples %{buildroot}%{_pkgdocdir}
Macro forms of system executables should not be used.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352



--- Comment #2 from Björn "besser82" Esser  ---
=== Updated package ===


Scratch build:

  Rawhide:  https://koji.fedoraproject.org/koji/taskinfo?taskID=23924905


Urls:

  Spec URL: 
https://pagure.io/besser82/package-review/raw/master/f/wlroots.spec
  SRPM URL: 
https://pagure.io/besser82/package-review/raw/master/f/wlroots-0.0.1-0.2.20171227giteeb7cd8.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529352] Review Request: wlroots - Pluggable, composable modules for building a Wayland compositor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529352



--- Comment #1 from Björn "besser82" Esser  ---
Scratch build:

  Rawhide:  https://koji.fedoraproject.org/koji/taskinfo?taskID=23924347

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org