[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #14 from Fedora Update System  ---
persepolis-3.0.1-2.fc26 has been pushed to the Fedora 26 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-01-16 12:11:35



--- Comment #13 from Fedora Update System  ---
persepolis-3.0.1-2.fc27 has been pushed to the Fedora 27 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #12 from Fedora Update System  ---
persepolis-3.0.1-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-50c7ab5902

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #11 from Fedora Update System  ---
persepolis-3.0.1-2.fc26 has been pushed to the Fedora 26 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-50c7ab5902

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
persepolis-3.0.1-2.fc27 has been pushed to the Fedora 27 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e35b639c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #9 from Fedora Update System  ---
persepolis-3.0.1-2.fc26 has been submitted as an update to Fedora 26.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-50c7ab5902

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #8 from Fedora Update System  ---
persepolis-3.0.1-2.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-2e35b639c9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/persepolis. You may commit to the branch
"f27" in about 10 minutes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #6 from Hedayat Vatankhah  ---
Thanks a lot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Robert-André Mauchin  ---
All good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #4 from Hedayat Vatankhah  ---
Oops, you are right, I found what was my mistake :P
Anyway, this is the new SPEC & SRPM:
SPEC: https://hedayat.fedorapeople.org/reviews/persepolis/persepolis.spec
SRPM:
https://hedayat.fedorapeople.org/reviews/persepolis/persepolis-3.0.1-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #3 from Robert-André Mauchin  ---
It fails for me in mock with "-c".

See this Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=23965815

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891



--- Comment #2 from Hedayat Vatankhah  ---
Thank you for taking this review.

>  - You should remove -c to autosetup to apply your patch correctly:
> %autosetup -n %{name}-%{version}

Sorry, I don't understand. On my system, rpmbuild fails if I remove '-c'; and
also it seems that the patch is correctly applied right now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1529891] Review Request: persepolis - A powerful download manager powered by aria2

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1529891

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zebo...@gmail.com
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Robert-André Mauchin  ---
 - Add a comment explaining what's the patch is for.

 - Use:

%{_mandir}/man1/persepolis.1*

 - You should remove -c to autosetup to apply your patch correctly:

%autosetup -n %{name}-%{version}

 -Be more specific in %files:

%files
%license LICENSE
%doc README.md
%{_bindir}/%{name}
%{_datadir}/applications/%{name}.desktop
%{_datadir}/pixmaps/*
%{_mandir}/man1/%{name}.1*
%{python3_sitelib}/%{name}
%{python3_sitelib}/%{name}-%{version}-py?.?.egg-info



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "*No copyright* GPL (v3 or later)", "Unknown or generated". 230
 files have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/persepolis/review-
 persepolis/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final