[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541

Petr Viktorin  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-23 11:50:08



--- Comment #12 from Petr Viktorin  ---
Pushed and built in Rawhide.

https://koji.fedoraproject.org/koji/taskinfo?taskID=24400283

Thank you to all involved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #11 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/python2-django1.11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #10 from Petr Viktorin  ---
Waiting for repo creation, which failed somehow:
https://pagure.io/releng/fedora-scm-requests/issue/4231

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541

Matthias Runge  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Matthias Runge  ---
all issues are resolved now.

Package approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #8 from Petr Viktorin  ---
Spec URL:
https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/9252/24299252/python2-django1.11-1.11.9-1.fc28.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24299251

python_provide macros and Obsoletes added.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #7 from Miro Hrončok  ---
Please add this to the doc subpackage:

Obsoletes:  python-django-doc < 2
Obsoletes:  python2-django-doc < 2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #6 from Miro Hrončok  ---
The python provide macro should be used, so the main package provides
python-django1.11.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #5 from Petr Viktorin  ---
Spec URL:
https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/7064/24267064/python2-django1.11-1.11.9-1.fc28.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24267064


Thanks for the review. I did the changes.

Remaining rpmlint complaints I get:

python2-django1.11-doc.noarch: W: invalid-url URL:
http://www.djangoproject.com/ 

-- local connection issue

python2-django1.11.noarch: W: spelling-error %description -l en_US Django ->
Fandango

-- bogus

python2-django1.11.noarch: W: obsolete-not-provided python-django
python2-django1.11.noarch: W: obsolete-not-provided python2-django

-- intentional; see the Change and its contingency plan

python2-django1.11.noarch: E: zero-length
/usr/lib/python2.7/site-packages/django/conf/app_template/__init__.py-tpl
python2-django1.11.noarch: E: zero-length
/usr/lib/python2.7/site-packages/django/conf/app_template/migrations/__init__.py-tpl
python2-django1.11.noarch: E: wrong-script-interpreter
/usr/lib/python2.7/site-packages/django/conf/project_template/manage.py-tpl
/usr/bin/env python
python2-django1.11.noarch: E: zero-length
/usr/lib/python2.7/site-packages/django/conf/project_template/project_name/__init__.py-tpl

-- intentional; note that these are template files

python2-django1.11.noarch: W: no-manual-page-for-binary django-admin-1.11
2 packages and 0 specfiles checked; 4 errors, 6 warnings.

-- see comment in specfile


Also, the automatic dependency on /usr/bin/env is not needed, but it doesn't
really do any harm.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #4 from Miro Hrončok  ---
Also, note the /usr/bin/env.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541

Matthias Runge  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from Matthias Runge  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.txt is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- Binary eggs must be removed in %prep
  Note: Binary egg files not removed in %prep:
  ./tests/app_loading/eggs/brokenapp.egg
  ./tests/app_loading/eggs/nomodelapp.egg
  ./tests/app_loading/eggs/omelet.egg ./tests/app_loading/eggs/modelapp.egg
  ./tests/utils_tests/eggs/test_egg.egg
  ./tests/user_commands/eggs/basic.egg
  ./tests/template_tests/eggs/tagsegg.egg
  See:
 
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns


= MUST items =

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
 Note: Using prebuilt packages
The prebuilt package has been taken from koji

[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* GPL",
 "MIT/X11 (BSD like)", "PSF (v2)", "*No copyright* BSD (unspecified)",
 "BSD (3 clause)", "*No copyright* Apache (v2.0)". 5210 files have
 unknown license. Detailed output of licensecheck in
 /home/mrunge/review/review-python2-django1.11/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/sv, /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/fr/LC_MESSAGES,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/sq,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ja,
 /usr/lib/python2.7/site-packages/django/contrib/humanize/locale/hsb,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/sl,
 /usr/lib/python2.7/site-packages/django/contrib/sites/locale/hsb,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ca,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale,
 /usr/lib/python2.7/site-packages/django/contrib/sessions/locale/ast,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/cs,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/ka/LC_MESSAGES,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/fi/LC_MESSAGES,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/hr/LC_MESSAGES,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/bg/LC_MESSAGES,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/gl/LC_MESSAGES,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hu,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/hr,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/mn/LC_MESSAGES,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/he,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/sl/LC_MESSAGES,
 /usr/lib/python2.7/site-packages/django/contrib/auth/locale/udm,
 /usr/lib/python2.7/site-packages/django/conf/locale/ast,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/tr/LC_MESSAGES,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/pt_BR/LC_MESSAGES,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/cs/LC_MESSAGES,
 /usr/lib/python2.7/site-packages/django/contrib/postgres/locale/ar,
 /usr/lib/python2.7/site-packages/django/contrib/gis/locale/dsb,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/et/LC_MESSAGES,
 /usr/lib/python2.7/site-packages/django/contrib/gis/locale/ast,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/nl/LC_MESSAGES,
 /usr/lib/python2.7/site-packages/django/conf/locale/dsb,
 /usr/lib/python2.7/site-
 packages/django/contrib/postgres/locale/ca/LC_MESSAGES,
 /usr/lib/python2.7/site-

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541

Petr Viktorin  changed:

   What|Removed |Added

 Blocks||1534542




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1534542
[Bug 1534542] Django 2.0
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541

Matthias Runge  changed:

   What|Removed |Added

 CC||mru...@redhat.com
   Assignee|nob...@fedoraproject.org|mru...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541



--- Comment #2 from Petr Viktorin  ---
Spec URL:
https://raw.githubusercontent.com/encukou/distgit-python2-django1.11/master/python2-django1.11.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/1548/24111548/python2-django1.11-1.11.9-1.fc28.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24111548


Thanks! I fixed those issues.
The `cp` was useless here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1532541] Review Request: python2-django1.11 - Version 1.11 LTS of Django, a high-level Python Web framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1532541

Miro Hrončok  changed:

   What|Removed |Added

 CC||mhron...@redhat.com



--- Comment #1 from Miro Hrončok  ---
> python-memcached, python-sphinx

There's python2-memcached [1] and python2-sphinx [2].


> Requires:   python2-pytz

This seems like part of the test requires, I suggest to move it down a bit by
an extra new line before it.


> # build documentation
> ...
> cp -ar docs ..

What is the purpose of this cp?


> # remove .po files
> find $RPM_BUILD_ROOT -name "*.po" | xargs rm -f

Please use %{buildroot}, as you do in the rest of the file.


> %{__python} ./runtests.py --settings=test_sqlite --verbosity=2 --parallel 1

Use %{__python2} explicitly.


[1] https://koji.fedoraproject.org/koji/buildinfo?buildID=1011376
[2] https://koji.fedoraproject.org/koji/buildinfo?buildID=1015148

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org