[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #14 from Fedora Update System  ---
ejabberd-18.01-2.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2018-02-06 06:21:17



--- Comment #13 from Fedora Update System  ---
ejabberd-18.01-2.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
ejabberd-18.01-2.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #11 from Fedora Update System  ---
ejabberd-18.01-2.fc27 erlang-base64url-1.0-1.fc27
erlang-cache_tab-1.0.12-1.fc27 erlang-esip-1.0.21-1.fc27
erlang-ezlib-1.0.3-1.fc27 erlang-fast_tls-1.0.20-1.fc27
erlang-fast_xml-1.1.28-1.fc27 erlang-fast_yaml-1.0.12-1.fc27
erlang-fs-4.1-2.fc27 erlang-jose-1.8.4-1.fc27 erlang-stun-1.0.20-1.fc27
erlang-xmpp-1.1.19-1.fc27 has been submitted as an update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
ejabberd-18.01-1.fc27, erlang-base64url-1.0-1.fc27,
erlang-cache_tab-1.0.12-1.fc27, erlang-esip-1.0.21-1.fc27,
erlang-ezlib-1.0.3-1.fc27, erlang-fast_tls-1.0.20-1.fc27,
erlang-fast_xml-1.1.28-1.fc27, erlang-fast_yaml-1.0.12-1.fc27,
erlang-fs-4.1-2.fc27, erlang-jose-1.8.4-1.fc27, erlang-stun-1.0.20-1.fc27,
erlang-xmpp-1.1.19-1.fc27 has been pushed to the Fedora 27 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #9 from Fedora Update System  ---
erlang-xmpp-1.1.19-1.fc27 erlang-esip-1.0.21-1.fc27 erlang-stun-1.0.20-1.fc27
erlang-jose-1.8.4-1.fc27 erlang-base64url-1.0-1.fc27 erlang-fs-4.1-2.fc27
erlang-fast_xml-1.1.28-1.fc27 erlang-fast_yaml-1.0.12-1.fc27
erlang-fast_tls-1.0.20-1.fc27 erlang-ezlib-1.0.3-1.fc27
erlang-cache_tab-1.0.12-1.fc27 ejabberd-18.01-1.fc27 has been submitted as an
update to Fedora 27.
https://bodhi.fedoraproject.org/updates/FEDORA-2018-8d1658ffde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #8 from Randy Barlow  ---
https://pagure.io/releng/fedora-scm-requests/issue/4206

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Randy Barlow  changed:

   What|Removed |Added

   Fixed In Version||erlang-fs-4.1-2.fc28



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #7 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/erlang-fs

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #6 from Randy Barlow  ---
https://pagure.io/releng/fedora-scm-requests/issue/4198

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Peter Lemenkov  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Peter Lemenkov  ---
Ok, good. I don't see any other issues so this package is

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #4 from Randy Barlow  ---
Alright, I've got those two things fixed here. Thanks!

Spec URL: https://bowlofeggs.fedorapeople.org/erlang-fs.spec
SRPM URL: https://bowlofeggs.fedorapeople.org/erlang-fs-4.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #3 from Peter Lemenkov  ---
[+] rpmlint is silent (or produces only messages which can be safely ignored:

Auriga ~/rpmbuild/SPECS: rpmlint ~/rpmbuild/SRPMS/erlang-fs-4.1-1.fc27.src.rpm
~/rpmbuild/RPMS/x86_64/erlang-fs-4.1-1.fc27.x86_64.rpm 
erlang-fs.src: W: spelling-error %description -l en_US inotify -> notify, i
notify, bogotify
erlang-fs.x86_64: W: spelling-error %description -l en_US inotify -> notify, i
notify, bogotify
erlang-fs.x86_64: E: no-binary
erlang-fs.x86_64: W: only-non-binary-in-usr-lib
2 packages and 0 specfiles checked; 1 errors, 3 warnings.
Auriga ~/rpmbuild/SPECS:

See Erlang packaging Guidelines for the explanation of these warnings -
https://fedoraproject.org/wiki/User:Peter/Erlang_Packaging_Guidelines

[+] The package is named according to the Package Naming Guidelines.
[+] The spec file name matches the base package %{name}, in the format
%{name}.spec.
[+] The package meets the Packaging Guidelines.
[+] The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
[+] The License field in the package spec file matches the actual license
(ISC).
[+] The file, containing the text of the license(s) for the package, is
included in %doc and marked as %license.
[+] The spec file is written in American English.
[+] The spec file for the package is legible.
[+] The sources used to build the package matches the upstream source, as
provided in the spec URL.

Auriga ~/rpmbuild/SOURCES: sha256sum fs-4.1.tar.gz*
3dafd86145ca37aa3bbd69706ef8586f81f7eea89b29d01eb51a609609545303  fs-4.1.tar.gz
3dafd86145ca37aa3bbd69706ef8586f81f7eea89b29d01eb51a609609545303 
fs-4.1.tar.gz.1
Auriga ~/rpmbuild/SOURCES:

[+] The package successfully compiles and builds into binary rpms.
[+] All build dependencies are listed in BuildRequires.
[0] No need to handle locales.
[0] The package does not contain any shared library files.
[+] Packages does not bundle copies of system libraries.
[+] The package isn't designed to be relocatable.
[+] The package owns all directories that it creates.
[+] The package does not list a file more than once in the spec file's %files
listings.
[+] Permissions on files are set properly.
[+] The package consistently uses macros.
[+] The package contains code, or permissible content.
[0] No large documentation files.
[+] Anything, the package includes as %doc, does not affect the runtime of the
application.
[0] No static libraries.
[0] No -devel sub-package.
[+] The package does not contain any .la libtool archives.
[0] Not a GUI application.
[+] The package does not own files or directories already owned by other
packages.
[+] All filenames in rpm packages are valid UTF-8.

I've spotted only the following two issues:

* Missing Requires: inotify-tools
* Erlang dependency generator complains about not available M:F/A, so the
following patch is required -
https://peter.fedorapeople.org/packages/erlang-fs-0001-Unbundle-https-github.com-synrc-mad.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Randy Barlow  changed:

   What|Removed |Added

 Blocks||1494854




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1494854
[Bug 1494854] ejabberd needs to be able to use port 5281 for ejabberd_http
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Peter Lemenkov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lemen...@gmail.com
   Assignee|nob...@fedoraproject.org|lemen...@gmail.com
  Flags||fedora-review?



--- Comment #2 from Peter Lemenkov  ---
I'll review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188



--- Comment #1 from Randy Barlow  ---
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=24181586

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1534188] Review Request: erlang-fs - Native filesystem listeners for Erlang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1534188

Randy Barlow  changed:

   What|Removed |Added

 Blocks||1516062




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1516062
[Bug 1516062] ejabberd-18.01 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org