[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565

Miroslav Lichvar  changed:

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2018-01-25 07:28:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #6 from Gwyn Ciesla  ---
(fedrepo-req-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/ntp-refclock

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #5 from Miroslav Lichvar  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565

Robert-André Mauchin  changed:

   What|Removed |Added

 Status|NEW |POST
   Assignee|nob...@fedoraproject.org|zebo...@gmail.com
  Flags||fedora-review+



--- Comment #4 from Robert-André Mauchin  ---
All good, package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #3 from Miroslav Lichvar  ---
It was suggested on the list to use Provides: bundled(ntp) instead of adding
the ntp version to the release string.

Spec URL: https://mlichvar.fedorapeople.org/tmp/ntp-refclock.spec
SRPM URL: https://mlichvar.fedorapeople.org/tmp/ntp-refclock-0.1-2.fc28.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565



--- Comment #2 from Miroslav Lichvar  ---
Thanks for the review.

I've asked on the packaging list about the version/release:
https://lists.fedoraproject.org/archives/list/packag...@lists.fedoraproject.org/thread/4YUJLK34CW6XSL35IWDJJURFQSZYCYST/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1536565] Review Request: ntp-refclock - Drivers for hardware reference clocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1536565

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
I'm not sure using ntp%{ntp_version} in the Release field is approved… Please
ask if this is ok on the mailing list.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "ISC BSD (3 clause)", "Beerware NTP", "GPL (v3 or
 later)", "Unknown or generated", "BSD (4 clause)", "MIT/X11 (BSD
 like)", "NTP", "BSD (2 clause) NTP", "ISC BSD (4 clause)", "ISC BSD (2
 clause)", "ISC", "FSF All Permissive", "Beerware", "GPL (v2 or later)
 (with incorrect FSF address)", "BSD (3 clause)", "BSD (2 clause)",
 "LGPL (v2.1 or later)", "ISC Public domain", "GPL (v3)". 1341 files
 have unknown license. Detailed output of licensecheck in
 /home/bob/packaging/review/ntp-refclock/review-ntp-
 refclock/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 419840 bytes in 46 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package