[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Kevin Kofler  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
  Flags|needinfo?(kevin@tigcc.tical |
   |c.org)  |
Last Closed||2020-07-14 02:21:52



--- Comment #6 from Kevin Kofler  ---
I think we can close this at this point. The review got stalled because the
reviewer demanded changes that were not actually required by the packaging
guidelines (at least at the time of the review). In the meantime, the package
got renamed upstream to nx-firewall. I also found that the user interface is
highly impractical to use (see
https://github.com/nx-desktop/nx-firewall/issues/15 and
https://github.com/nx-desktop/nx-firewall/issues/16 ) and the issues have not
been addressed. (In fact, not much has happened upstream other than the
rename.) And the plan upstream is still to rewrite everything to use another
backend ( https://github.com/nx-desktop/nx-firewall/issues/21 ). So I decided
against shipping this package in Kannolo, and hence lost interest in it.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

needinfo canceled: [Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

Product: Fedora
Version: rawhide
Component: Package Review

Kevin Kofler  has canceled Package Review
's request for Kevin Kofler
's needinfo:
Bug 1537677: Review Request: nomad-firewall - UFW control module for KDE Plasma
5 and Nomad Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #6 from Kevin Kofler  ---
I think we can close this at this point. The review got stalled because the
reviewer demanded changes that were not actually required by the packaging
guidelines (at least at the time of the review). In the meantime, the package
got renamed upstream to nx-firewall. I also found that the user interface is
highly impractical to use (see
https://github.com/nx-desktop/nx-firewall/issues/15 and
https://github.com/nx-desktop/nx-firewall/issues/16 ) and the issues have not
been addressed. (In fact, not much has happened upstream other than the
rename.) And the plan upstream is still to rewrite everything to use another
backend ( https://github.com/nx-desktop/nx-firewall/issues/21 ). So I decided
against shipping this package in Kannolo, and hence lost interest in it.
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #4 from Robert-André Mauchin  ---
>I don't like virtual BRs all that much, but I can make this change if you 
>think it is an improvement (but I should probably use the full list of used 
>modules then: e.g., the CMakeLists.txt uses more than just Qt5Core from 
>qt5-qtbase).

Please do.

> I think we should include as many digits as allowed of the commit hash to 
> avoid running into hash collisions.

That's unlikely but do as you wish, it's just the usual practice, not a
requirement per se.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #3 from Kevin Kofler  ---
Correction: all 40 digits, not 64.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677



--- Comment #2 from Kevin Kofler  ---
>  - Use cmake for your BR, as it is usual for KDE packages:
>
> BuildRequires:  cmake(Qt5Core)
> BuildRequires:  cmake(Qt5Qml)
> BuildRequires:  cmake(Qt5X11Extras)
> BuildRequires:  kf5-rpm-macros
> BuildRequires:  cmake(KF5CoreAddons)
> BuildRequires:  cmake(KF5KCMUtils)
> BuildRequires:  cmake(KF5I18n)
> BuildRequires:  cmake(KF5Plasma)
> BuildRequires:  cmake(KF5KDELibs4Support)
> BuildRequires:  cmake(KF5Declarative)
> BuildRequires:  cmake(KF5Auth)
> BuildRequires:  cmake(KF5Config)

Is it really? All the ones I have seen so far use package names or pkgconfig
BRs. But I guess that's because the cmake(*) Provides are a recent addition
(which is also why I haven't thought of using them). I don't like virtual BRs
all that much, but I can make this change if you think it is an improvement
(but I should probably use the full list of used modules then: e.g., the
CMakeLists.txt uses more than just Qt5Core from qt5-qtbase).

> - The short hash for Github is usually 7 characters long, not 13.

According to
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots
"The packager MAY include up to 17 characters of additional information after
the date."
"git" is 3 characters, that leaves up to 14 for the commit version.

I think we should include as many digits as allowed of the commit hash to avoid
running into hash collisions. I'd put all 64 if I were allowed to. I should
change it from 13 to 14 characters though, some older version of the guidelines
only allowed up to 13 characters (which is why I picked that number in all my
git snapshot packages), now it allows up to 14.

You can note that for the GitHub Source0 URL itself (the only part that is ever
sent to GitHub), I actually use all 64 digits of the commit hash, not my 13
characters, which are only for the Release tag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Robert-André Mauchin  changed:

   What|Removed |Added

 CC||zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin  ---
 - Use cmake for your BR, as it is usual for KDE packages:

BuildRequires:  cmake(Qt5Core)
BuildRequires:  cmake(Qt5Qml)
BuildRequires:  cmake(Qt5X11Extras)
BuildRequires:  kf5-rpm-macros
BuildRequires:  cmake(KF5CoreAddons)
BuildRequires:  cmake(KF5KCMUtils)
BuildRequires:  cmake(KF5I18n)
BuildRequires:  cmake(KF5Plasma)
BuildRequires:  cmake(KF5KDELibs4Support)
BuildRequires:  cmake(KF5Declarative)
BuildRequires:  cmake(KF5Auth)
BuildRequires:  cmake(KF5Config)

 - The short hash for Github is usually 7 characters long, not 13.

 - You should "Requires: dbus" to own these dbus directories
 Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms,
 /usr/share/kpackage/kcms, /usr/share/dbus-1/system-services,
 /usr/share/dbus-1, /etc/dbus-1, /etc/dbus-1/system.d


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
 generated". 51 files have unknown license. Detailed output of
 licensecheck in /home/bob/packaging/review/nomad-firewall/review-
 nomad-firewall/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/kpackage/kcms
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms,
 /usr/share/kpackage/kcms, /usr/share/dbus-1/system-services,
 /usr/share/dbus-1, /etc/dbus-1, /etc/dbus-1/system.d
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the 

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Kevin Kofler  changed:

   What|Removed |Added

 Blocks||656997 (kde-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1537677] Review Request: nomad-firewall - UFW control module for KDE Plasma 5 and Nomad Desktop

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1537677

Kevin Kofler  changed:

   What|Removed |Added

  Alias||nomad-firewall



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org